mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Chris Babroski <cbabroski@nvidia.com>
To: <netdev-bot+sinfo@kernel.org>
Cc: <andrew+netdev@lunn.ch>, <cbabroski@nvidia.com>,
	<davem@davemloft.net>, <davthompson@nvidia.com>,
	<edumazet@kernel.org>, <kuba@kernel.org>,
	<linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>,
	<pabeni@redhat.com>
Subject: Re: [PATCH net-next v1 0/2] mlxbf_gige: disable MAC after panic
Date: Fri, 20 Nov 2026 15:43:09 -0500	[thread overview]
Message-ID: <20261120204309.587701-1-cbabroski@nvidia.com> (raw)
In-Reply-To: <179520642352.3294.1018427060462107443@kernel.org>

> This is an automated message. This series looks like a fix, but its
> commit messages seem to be missing some information:
> 
>  - How the issue was discovered, e.g. hit in production, hit during
>    development, syzbot report, manual code inspection, LLM or static
>    analysis tool scan.

This is a theoretical issue that has not yet been seen in production. It
can, however, be reproduced manually. It was found because we hit a
similar issue in production last year that caused OOB network traffic to
stop when our UEFI FW could not process packets fast enough during HTTP
boot to keep the RX FIFO drained (see cover letter for more background
about how this affects the network).

After fixing the FW to prevent that case from occurring, we decided it
would be good to add protection to our kernel driver to ensure that a
kernel panic does not leave the OOB MAC in a state where the RX FIFO can
continue to fill while nothing can drain it.

Chris


      reply	other threads:[~2026-11-20 20:43 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-20 20:24 Chris Babroski
2026-11-20 20:24 ` [PATCH net-next v1 1/2] mlxbf_gige: protect against MAC disable during TX Chris Babroski
2026-11-20 20:24 ` [PATCH net-next v1 2/2] mlxbf_gige: disable MAC after kernel panic Chris Babroski
2026-11-20 20:27 ` [PATCH net-next v1 0/2] mlxbf_gige: disable MAC after panic netdev-bot+sinfo
2026-11-20 20:43   ` Chris Babroski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261120204309.587701-1-cbabroski@nvidia.com \
    --to=cbabroski@nvidia.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=davthompson@nvidia.com \
    --cc=edumazet@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev-bot+sinfo@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®