From: Eric Biggers <ebiggers@kernel.org>
To: Anvik Loitongbam <permissiontogallop@gmail.com>
Cc: Alasdair Kergon <agk@redhat.com>,
Mike Snitzer <snitzer@kernel.org>,
Mikulas Patocka <mpatocka@redhat.com>,
Benjamin Marzinski <bmarzins@redhat.com>,
dm-devel@lists.linux.dev, Jonathan Corbet <corbet@lwn.net>,
Shuah Khan <skhan@linuxfoundation.org>,
Randy Dunlap <rdunlap@infradead.org>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dm-inlinecrypt: emit key type as an optional table argument
Date: Fri, 20 Nov 2026 20:58:21 +0000 [thread overview]
Message-ID: <20261120205821.GA3048696@google.com> (raw)
In-Reply-To: <20261120163601.114199-1-permissiontogallop@gmail.com>
On Fri, Nov 20, 2026 at 10:06:01PM +0530, Anvik Loitongbam wrote:
> inlinecrypt_status() emits ctx->key_type as a positional argument between
> the key and iv_offset:
>
> <cipher> <key> <key_type> <iv_offset> <dev_path> <start>
>
> but inlinecrypt_ctr() parses the base table as:
>
> <cipher> <key> <iv_offset> <dev_path> <start>
>
> and keytype, is an optional feature argument parsed by
> inlinecrypt_ctr_optional(). Resulting in STATUSTYPE_TABLE output for every
> dm-inlinecrypt device to be not reloadable, the constructor reads key_type as
> iv_offset and shifts the remaining fields.
>
> Keep the base table in constructor order and emit a non-default key type
> as keytype:hw-wrapped in the optional feature list. Raw keys remain the
> default and are not emitted, preserving the existing table text for
> raw-key devices.
>
> The two dmsetup examples in the documentation acquired
> the same extra positional key-type field, so removed it there as well.
>
> Fixes: f9f57971da38 ("dm-inlinecrypt: add support for hardware-wrapped keys")
> Cc: stable@vger.kernel.org
> Signed-off-by: Anvik Loitongbam <permissiontogallop@gmail.com>
The original Sashiko review of this commit mentioned this bug already
(https://sashiko.dev/#/patchset/20260525121348.1321282-2-linlin.zhang%40oss.qualcomm.com).
Might be worth adding a Reported-by if you found it from there.
> + if (ctx->key_type != BLK_CRYPTO_KEY_TYPE_RAW)
> + num_feature_args++;
> if (ctx->sector_size != SECTOR_SIZE)
> num_feature_args += 2;
> if (num_feature_args != 0) {
> DMEMIT(" %d", num_feature_args);
> + if (ctx->key_type != BLK_CRYPTO_KEY_TYPE_RAW)
> + DMEMIT(" keytype:%s",
> + ctx->key_type == BLK_CRYPTO_KEY_TYPE_HW_WRAPPED ?
> + "hw-wrapped" : "raw");
The "raw" fallback case doesn't make much sense, because it was just
checked above that it is *not* raw. So if it is ever reached due to a
new enum value it will be wrong anyway. Maybe just leave that out and
simply do DMEMIT(" keytype:hw-wrapped").
Otherwise this fix looks good, thanks.
- Eric
prev parent reply other threads:[~2026-11-20 20:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-20 16:36 Anvik Loitongbam
2026-11-20 20:58 ` Eric Biggers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261120205821.GA3048696@google.com \
--to=ebiggers@kernel.org \
--cc=agk@redhat.com \
--cc=bmarzins@redhat.com \
--cc=corbet@lwn.net \
--cc=dm-devel@lists.linux.dev \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mpatocka@redhat.com \
--cc=permissiontogallop@gmail.com \
--cc=rdunlap@infradead.org \
--cc=skhan@linuxfoundation.org \
--cc=snitzer@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®