mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Svyatoslav Ryhel <clamor95@gmail.com>
Cc: "Thierry Reding" <thierry.reding@kernel.org>,
	"Jonathan Hunter" <jonathanh@nvidia.com>,
	"Sowjanya Komatineni" <skomatineni@nvidia.com>,
	"Luca Ceresoli" <luca.ceresoli@bootlin.com>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Mauro Carvalho Chehab" <mchehab@kernel.org>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Mikko Perttunen" <mperttunen@nvidia.com>,
	"Hans Verkuil" <hverkuil+cisco@kernel.org>,
	"Sakari Ailus" <sakari.ailus@linux.intel.com>,
	"Cong Nguyen" <congnt264@gmail.com>,
	"Faisal Mukhtar" <mukhtarfaisal03@gmail.com>,
	"Dan Carpenter" <error27@gmail.com>,
	"Hungyu Lin" <dennylin0707@gmail.com>,
	"Hao-Qun Huang" <alvinhuang0603@gmail.com>,
	"Yury Norov" <ynorov@nvidia.com>,
	"Uwe Kleine-König" <u.kleine-koenig@baylibre.com>,
	linux-media@vger.kernel.org, linux-tegra@vger.kernel.org,
	dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev
Subject: Re: [PATCH v1 01/10] staging: media: tegra-video: Move driver to media/platform/nvidia
Date: Fri, 20 Nov 2026 23:31:16 +0200	[thread overview]
Message-ID: <20261120213116.GB2472094@killaraus.ideasonboard.com> (raw)
In-Reply-To: <CAPVz0n3u3oe1+H_w9jE2afb9PQT0VLtYVqfHeVNc3D+tLN6NDQ@mail.gmail.com>

On Fri, Nov 20, 2026 at 05:31:17PM +0200, Svyatoslav Ryhel wrote:
> пт, 20 лист. 2026 р. о 16:31 Laurent Pinchart пише:
> > On Fri, Nov 13, 2026 at 06:18:10PM +0200, Svyatoslav Ryhel wrote:
> > > The Tegra Video Input drivers are mature and developed enough to be moved
> > > from staging into the media subsystem. No other changes are introduced.
> >
> > The driver should at least be converted to be MC-centric before being
> > moved out of staging. I haven't checked if other changes would also be
> > needed.
> 
> Does the media subsystem deny video-centric devices from even being
> moved into it? I have not seen this restriction imposed; could you
> please point me to where this is stated in the media subsystem
> documentation?

There's a consensus that devices that require control of camera sensors
(i.e. "MIPI" cameras) must be MC-centric. That's not documented, we
should probably fix that.

> I would like to convert this device, but that may take quite some time
> and may case regressions if not done carefully. This patchset apart
> from moving to media is mostly fixes to work correctly with mt9m114
> and tegra114 bring-up which is quite simple and straight forward
> change.

Converting to the MC API will require some changes in userspace. That's
why it's important to make this change before destaging the driver.

> BTW, may you ack mt9m114 get_fwnode_pad change[1]. I have updated it
> to your liking, Sakari seems to ignore it.
> 
> [1] - https://lore.kernel.org/lkml/20261006153619.304520-1-clamor95@gmail.com/

In the review of v1, I wrote in my last message
(https://lore.kernel.org/linux-media/20260721103845.GJ50424@killaraus.ideasonboard.com/)
that the issue seems to come from a bug in the VI driver. Let's continue
the discussion there.

> > > Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com>
> > > ---
> > >  drivers/media/platform/nvidia/Kconfig                           | 2 ++
> > >  drivers/media/platform/nvidia/Makefile                          | 1 +
> > >  .../media => media/platform/nvidia}/tegra-video/Kconfig         | 0
> > >  .../media => media/platform/nvidia}/tegra-video/Makefile        | 0
> > >  .../{staging/media => media/platform/nvidia}/tegra-video/TODO   | 0
> > >  .../{staging/media => media/platform/nvidia}/tegra-video/csi.c  | 0
> > >  .../{staging/media => media/platform/nvidia}/tegra-video/csi.h  | 0
> > >  .../media => media/platform/nvidia}/tegra-video/tegra20.c       | 0
> > >  .../media => media/platform/nvidia}/tegra-video/tegra210.c      | 0
> > >  .../{staging/media => media/platform/nvidia}/tegra-video/vi.c   | 0
> > >  .../{staging/media => media/platform/nvidia}/tegra-video/vi.h   | 0
> > >  .../media => media/platform/nvidia}/tegra-video/video.c         | 0
> > >  .../media => media/platform/nvidia}/tegra-video/video.h         | 0
> > >  .../{staging/media => media/platform/nvidia}/tegra-video/vip.c  | 0
> > >  .../{staging/media => media/platform/nvidia}/tegra-video/vip.h  | 0
> > >  drivers/staging/media/Kconfig                                   | 2 --
> > >  drivers/staging/media/Makefile                                  | 1 -
> > >  17 files changed, 3 insertions(+), 3 deletions(-)
> > >  rename drivers/{staging/media => media/platform/nvidia}/tegra-video/Kconfig (100%)
> > >  rename drivers/{staging/media => media/platform/nvidia}/tegra-video/Makefile (100%)
> > >  rename drivers/{staging/media => media/platform/nvidia}/tegra-video/TODO (100%)
> > >  rename drivers/{staging/media => media/platform/nvidia}/tegra-video/csi.c (100%)
> > >  rename drivers/{staging/media => media/platform/nvidia}/tegra-video/csi.h (100%)
> > >  rename drivers/{staging/media => media/platform/nvidia}/tegra-video/tegra20.c (100%)
> > >  rename drivers/{staging/media => media/platform/nvidia}/tegra-video/tegra210.c (100%)
> > >  rename drivers/{staging/media => media/platform/nvidia}/tegra-video/vi.c (100%)
> > >  rename drivers/{staging/media => media/platform/nvidia}/tegra-video/vi.h (100%)
> > >  rename drivers/{staging/media => media/platform/nvidia}/tegra-video/video.c (100%)
> > >  rename drivers/{staging/media => media/platform/nvidia}/tegra-video/video.h (100%)
> > >  rename drivers/{staging/media => media/platform/nvidia}/tegra-video/vip.c (100%)
> > >  rename drivers/{staging/media => media/platform/nvidia}/tegra-video/vip.h (100%)
> >
> > --
> > Regards,
> >
> > Laurent Pinchart

-- 
Regards,

Laurent Pinchart

  reply	other threads:[~2026-11-20 21:31 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-13 16:18 [PATCH v1 00/10] Tegra Video Input updates Svyatoslav Ryhel
2026-11-13 16:18 ` [PATCH v1 01/10] staging: media: tegra-video: Move driver to media/platform/nvidia Svyatoslav Ryhel
2026-11-20 14:31   ` Laurent Pinchart
2026-11-20 15:31     ` Svyatoslav Ryhel
2026-11-20 21:31       ` Laurent Pinchart [this message]
2026-11-13 16:18 ` [PATCH v1 02/10] dt-bindings: display: tegra: Remove Tegra30 fallback Svyatoslav Ryhel
2026-11-13 16:18 ` [PATCH v1 03/10] media: tegra-video: vi: Diverge Tegra20 and Tegra30 VI SoC descriptions Svyatoslav Ryhel
2026-11-13 16:18 ` [PATCH v1 04/10] media: tegra-video: vi: Switch to media_entity_remote_source_pad_unique() helper Svyatoslav Ryhel
2026-11-13 16:18 ` [PATCH v1 05/10] media: tegra-video: vi: Use entity function to check subdev type Svyatoslav Ryhel
2026-11-13 16:18 ` [PATCH v1 06/10] media: tegra-video: vi: Adjust pad assignment logic Svyatoslav Ryhel
2026-11-13 16:18 ` [PATCH v1 07/10] dt-bindings: display: tegra: Document Tegra114 CSI Svyatoslav Ryhel
2026-11-13 16:18 ` [PATCH v1 08/10] media: tegra-video: Add CSI support for Tegra114 Svyatoslav Ryhel
2026-11-13 16:18 ` [PATCH v1 09/10] ARM: tegra: Remove fallback compatible from Tegra30 VI node Svyatoslav Ryhel
2026-11-14  9:22   ` Krzysztof Kozlowski
2026-11-13 16:18 ` [PATCH v1 10/10] ARM: tegra: Add CSI node for Tegra114 Svyatoslav Ryhel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261120213116.GB2472094@killaraus.ideasonboard.com \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=alvinhuang0603@gmail.com \
    --cc=clamor95@gmail.com \
    --cc=congnt264@gmail.com \
    --cc=conor+dt@kernel.org \
    --cc=dennylin0707@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=error27@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hverkuil+cisco@kernel.org \
    --cc=jonathanh@nvidia.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=linux-tegra@vger.kernel.org \
    --cc=luca.ceresoli@bootlin.com \
    --cc=mchehab@kernel.org \
    --cc=mperttunen@nvidia.com \
    --cc=mukhtarfaisal03@gmail.com \
    --cc=robh@kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    --cc=skomatineni@nvidia.com \
    --cc=thierry.reding@kernel.org \
    --cc=u.kleine-koenig@baylibre.com \
    --cc=ynorov@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®