mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tristan Madani <tristmd@gmail.com>
To: Jeff Chen <jeff.chen_1@nxp.com>
Cc: Francesco Dolcini <francesco@dolcini.it>,
	linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
	stable@vger.kernel.org,
	Tristan Madani <tristan@talencesecurity.com>
Subject: [PATCH v2 wireless 0/2] wifi: nxpwifi: firmware response validation fixes
Date: Fri, 20 Nov 2026 22:59:31 +0000	[thread overview]
Message-ID: <20261120225933.1148680-1-tristan@talencesecurity.com> (raw)

The nxpwifi driver trusts several size fields from firmware responses
without validating them against actual buffer lengths. This series
adds bounds checks to prevent reads past the buffer when firmware
provides inflated sizes.

Changes in v2:
- Dropped the HE capability TLV length patch (was 1/3), superseded by
  commit f17e2eda1630a ("wifi: nxpwifi: bound the TLV lengths in the
  11AX_CFG response")
- Patch 2/2: moved the response size check after timer_delete_sync()
  so the command timer is properly cancelled before the early return,
  as pointed out by Jeff Chen

Tristan Madani (2):
  wifi: nxpwifi: validate ext_scan buf_size against event buffer length
  wifi: nxpwifi: validate command response size against buffer length

 drivers/net/wireless/nxp/nxpwifi/cmdevt.c | 14 ++++++++++++++
 drivers/net/wireless/nxp/nxpwifi/scan.c   |  9 +++++++++
 2 files changed, 23 insertions(+)

-- 
2.47.3

             reply	other threads:[~2026-11-20 22:59 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-20 22:59 Tristan Madani [this message]
2026-11-20 22:59 ` [PATCH v2 wireless 1/2] wifi: nxpwifi: validate ext_scan buf_size against event buffer length Tristan Madani
2026-11-20 22:59 ` [PATCH v2 wireless 2/2] wifi: nxpwifi: validate command response size against " Tristan Madani

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261120225933.1148680-1-tristan@talencesecurity.com \
    --to=tristmd@gmail.com \
    --cc=francesco@dolcini.it \
    --cc=jeff.chen_1@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=tristan@talencesecurity.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®