From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=202.12.124.144 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795184456; b=WycmSbDEqjr5B2fHBBL03FGckpJNVE1ANVuvH1/qq+ZjG6os8TM42o++dRc5BZ2ltEqG 8T8xFXz1bnc7r54u63cv4uR4fPR85L/hjjY2zoyfWit9Zi8tN1vHj67CUy6ZR01TAeyLP IwmNY8FhhPwlj5l4y/LB346MeB2Nomuv5jKv4gt+r2R9XU91wqB/0IOiQE3KIMZ9Y9pth 4Ipa30Px1tjULNS/739mezUBJu56YIRHk0jOReE1VUjiRcHwx3OcmxYn6MkqdjWZtwwgU NgPi/gjIdp4Fv6t+mhuHI16JkupEK+KoayZMLwKTuAYvZW0Uu38ReCasdEhy4lwIVgQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795184456; h=DMARC-Filter:Received:Received:DKIM-Signature:DKIM-Signature: X-DKIM2-Info:DKIM2-Signature:X-DKIM2-Info:Message-Instance: X-ME-Sender:X-ME-Received:X-ME-Proxy-Cause:X-ME-Proxy:Feedback-ID: Received:Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; bh=vTQ4E2JgOTpZe0dib1eo5BcGfkwG6YBsKTtMFnWJdVs=; b=rDQ3nFaY8UQyF287WGhgmA3LdGt8KnPDfMeDv6zWxpQRs3wFm6+iBzKb5KKks5YRTGFR GNWT7h8TaVSnFuRFfwGlNw6+Uqn8gIZi8jJrVjRK4rYDmgL9cOdzl1vKvirMSdkwINPu5 z6l8i3DhVvVtAvuSnyUh1RUAo6hDAgCDDY/U8WxA/ejUTcyIZIb5vlfa3uSvNo9m9B4G7 UKJAHKXsUv/cpe6Jz2RZXHb3aCNd4YjnB1G//7pykl7Wzwv5BbKxMOSGNJWvBzMsRLtC0 jFv/QE2KTsOg1SJY8yrIUYq+wmeiK6hgg8dHgWSiGw/cJ2ZcYWKUZoGI97QZ5CM0GnA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=kroah.com; spf=pass smtp.mailfrom=kroah.com; dkim=pass header.d=kroah.com header.i=@kroah.com header.a=rsa-sha256 header.s=fm3 header.b=nlVZAP5t; dkim=pass header.d=messagingengine.com header.i=@messagingengine.com header.a=rsa-sha256 header.s=fm3 header.b=R3t6QVPq; arc=none smtp.remote-ip=202.12.124.144 Received: from fout-b1-smtp.messagingengine.com (fout-b1-smtp.messagingengine.com [202.12.124.144]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9A0A6606A325 for ; Fri, 20 Nov 2026 14:20:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 9A0A6606A325 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=kroah.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kroah.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=kroah.com header.i=@kroah.com header.a=rsa-sha256 header.s=fm3 header.b=nlVZAP5t; dkim=pass (2048-bit key, unprotected) header.d=messagingengine.com header.i=@messagingengine.com header.a=rsa-sha256 header.s=fm3 header.b=R3t6QVPq Received: from phl-compute-11.internal (phl-compute-11.internal [10.202.2.51]) by mailfout.stl.internal (Postfix) with ESMTP id 2224F1D00477 for ; Fri, 20 Nov 2026 09:20:55 -0500 (EST) Received: from phl-frontend-03 ([10.202.2.162]) by phl-compute-11.internal (MEProxy); Fri, 20 Nov 2026 09:20:55 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kroah.com; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm3; t=1795184454; x=1795270854; bh=vTQ4E2JgOT pZe0dib1eo5BcGfkwG6YBsKTtMFnWJdVs=; b=nlVZAP5tC2kFKEt/YRH4MoOk1b KOiMTw0RTs/hwUoIbhY8EdigVvr2y97QulUBE4DJTsNo1Nu8fNp9I8M/u1p3/95U xnMDE9F+W91uX5zsltbQpqi5xutBp4Zj8o3B31wfwxhwpH8kus+vPevhHs1He3l9 eMhT5EYXTwdoOPwRGbnkl/mBpoRXJ64RhbbAf5lySUmZIU9Y9uuLCBKpB3f4C0G2 fgOpGRuONyx4X/6AhtKs4eDWn087LmHmMHDwC2C90ccmqRwvGW8W8ZmP15vFd7WL WD0kLuM/q9TcAaGRfakU2nEfhDFrZ7Pt4tluBofntg4+aE44ePF6MxKwHpvw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1795184454; x=1795270854; bh=vTQ4E2JgOTpZe0dib1eo5BcGfkwG6YBsKTt MFnWJdVs=; b=R3t6QVPq+zXQ5xBKZfZOWk7bXp/6p3rcrVOAclCSWWBN6mknU5L c3xgwB/PlzxUJv/Po75+qFHh5VUFMK9nWmp2RnJphdfsGZJlzUg9W25o5W4101hT p7vMN5tgNBnpaxsNULvqAUtFfxNrKJB0RHFP6imObkfl4w4uVJn+A3dgAsqJsy/W bZijFGubvb++oQFg88FL6FT5Moeql9DfAPWtj/M5XuG+8P+khuxr998/ubRVe7YI 0woLHYFVZJYMSfFqkQqeXDlg+To5blz0WZEbe7xIZr9hz8X7dZeyjY0wFYG4MxKf aIW5QjPtS84R1N/dYkgySyDs1016eO32Pfg== X-DKIM2-Info: draft=ietf-dkim-dkim2-spec-09; repo=github.com/dkim2wg/interop; date=2026-11-03; sw=lmtpprox; action=sign d=kroah.com a=rsa-sha256; DKIM2-Signature: i=1; m=1; t=1795184454; d=kroah.com; mf=PGdyZWdAa3JvYWguY29tPg==; rt=PGxpbnV4LWtlcm5lbEB2Z2VyLmtlcm5lbC5vcmc+; s=fm3:rsa-sha256:erCAObISbsZ8FqGTxglqA2XCPsIkQdu+PIjie4/8xh0LfRf lQgdgKqNjNekpC8fVzhNcLIo85kZrjlD0pntdFVfj/K1/t/dyO7VngQSOojcfGAn SwTY/hfRZR0Np7bmj8xCOdMPg26UhdRdLSuAqUaMWxezPR/8e7xhbfVu5nCZrBaU /Fu0jAqCjP0HuSXY2uuyGOJNbK5C2hj2xCNyJ7CsTAcVyhln+h/UvYPtYHfeZo9M +FLFIrKOjGExQ/4ZagaVevv/0k6aVQfNrQTR4rDbzVcZaxt+LeCDpCoS8opsHRik Qe+/cYBFYEdJZJ0lIHoExDnIxk/dtLsjW91/RVw==; X-DKIM2-Info: draft=ietf-dkim-dkim2-spec-09; repo=github.com/dkim2wg/interop; date=2026-11-03; sw=lmtpprox; action=mi-m=1; hc=12; hn=cc,content-disposition,content-type,date,feedback-id,from, in-reply-to,message-id,mime-version,references,subject,to; Message-Instance: m=1; h=sha256:10OOwfHanLGyvJXV4Bcjvvs+9je8p+0OqKqMSMUTDqU=:x+SezIyNLy9Fjjuka6QAhFaautpL2/BTBPmmGUxiupo=; X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: dmFkZTFQvFPS8uzFw3fizoTJiHl4+yszpt9afFpYdF9q1dr+wRPIuZWxdM+KRSug6iCh6h Hipe1vK+8TH7a4AaHTzHgl6l0Zp6xgMbAxQiZSCg6HfpX4Hj2FuHp69N5mKed4AHqMQJCV PbJRvWr7lERxihA7Nyfdfmj5XHWlr8boIn0XHONiNPjbv4Ri0SZ7jC5bQIOwbRrR8PiLLK Zt/cT5vRdvNxn4vdsafaURH4jANnOWsFTcZaNcpmlR9ecuqlAcIVVUw82F3/OJa76eilC5 m1uwAXxqeYSLGMG282U2B1/B1YUfxc9HuFxHJ5h3t4C3YRCgMmJBjpqaFmeSnj8MvQ+aD0 KNZyChj8qgVsLMKI1c1W7daIp8+SdYvMzrTSEVEb8y9lvbbzDS5qhIjjNkQ7CRH1abhEmA S2OP7dyGKK/nL2y8Ti7F3L3kFapVDl9umpqmZr5zIdEgQB1NNHuWWtM8C5jIScPuD6LlsX 2XGldj+zFHZultdFEepjuX+ZIxiwl3Yj4Gahvn03cLilwPZwri1SVOo3fr7rcIN6b6/k79 19evwBYDHGrljw5SmlN6h99g3cLL/iAMFalw9/7ChWrCTMz4cXBdVl8MUx+kxcGF3aHi0q PL9b+ka2d9e9z+0o9xURta4WA06Fg3lCLtp9WE1hmAKbf5SyD851RDFXFREQ X-ME-Proxy: Feedback-ID: i787e41f1:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 20 Nov 2026 09:20:53 -0500 (EST) Date: Fri, 20 Nov 2026 15:20:51 +0100 From: Greg KH To: Ginger Li Cc: vz@mleia.com, piotr.wojtaszczyk@timesys.com, linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] usb: gadget: lpc32xx_udc: Fix a race in lpc32xx_get_frame() Message-ID: <2026112029-eloquent-slimy-c43f@gregkh> References: <20260922065357.18103-1-ginger.jzllee@gmail.com> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260922065357.18103-1-ginger.jzllee@gmail.com> On Tue, Sep 22, 2026 at 02:53:57PM +0800, Ginger Li wrote: > lpc32xx_get_frame() tests udc->clocked before it takes udc->lock, but > udc->clocked is cleared by udc_clk_set() with the lock held, for example from > lpc32xx_vbus_session() when the session is disconnected, which also gates the > UDC clock. > > When the test passes on a stale value, udc_get_current_frame() then reads UDC > registers whose clock has already been turned off. Check udc->clocked inside > the critical section so that the state can not change between the check and > the register access. > > Fixes: 24a28e428351 ("USB: gadget driver for LPC32xx") > Signed-off-by: Ginger Li > --- > drivers/usb/gadget/udc/lpc32xx_udc.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) How was this found and tested? > > diff --git a/drivers/usb/gadget/udc/lpc32xx_udc.c b/drivers/usb/gadget/udc/lpc32xx_udc.c > --- a/drivers/usb/gadget/udc/lpc32xx_udc.c > +++ b/drivers/usb/gadget/udc/lpc32xx_udc.c > @@ -2403,10 +2403,12 @@ static int lpc32xx_get_frame(struct usb_gadget *gadget > unsigned long flags; > struct lpc32xx_udc *udc = to_udc(gadget); > > - if (!udc->clocked) > - return -EINVAL; > + spin_lock_irqsave(&udc->lock, flags); guard()?