From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: yusuke8h@gmail.com
Cc: Florian Fainelli <florian.fainelli@broadcom.com>,
Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
linux-staging@lists.linux.dev,
linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: bcm2835-audio: remove unused bcm2835_audio_retrieve_buffers() declaration
Date: Fri, 20 Nov 2026 08:21:51 +0100 [thread overview]
Message-ID: <2026112041-suffrage-bonanza-e079@gregkh> (raw)
In-Reply-To: <20261112-bcm2835-audio-unused-decl-v1-1-3b63a24b033b@gmail.com>
On Thu, Nov 12, 2026 at 04:29:55AM +0000, Yusuke Hayashi via B4 Relay wrote:
> From: Yusuke Hayashi <yusuke8h@gmail.com>
>
> bcm2835_audio_retrieve_buffers() is declared in bcm2835.h, but its
> definition and sole caller were removed in commit d7ca3a71545b
> ("staging: bcm2835-audio: Operate non-atomic PCM ops").
>
> Remove the orphaned function declaration.
>
> Signed-off-by: Yusuke Hayashi <yusuke8h@gmail.com>
> ---
> Found while scanning staging headers for declarations without definitions
> with an AI coding assistant, verified against commit d7ca3a71545b, and
> compile-tested with Clang 18 (LLVM=1 W=1 C=2) and GCC 13 (W=1 C=2) with
> CONFIG_SND_BCM2835=m.
> ---
> drivers/staging/vc04_services/bcm2835-audio/bcm2835.h | 1 -
> 1 file changed, 1 deletion(-)
Please read: https://lore.kernel.org/r/2026080354-skater-urgent-31b2@gregkh
next prev parent reply other threads:[~2026-11-20 7:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-12 4:29 Yusuke Hayashi via B4 Relay
2026-11-20 7:21 ` Greg Kroah-Hartman [this message]
2026-11-20 7:58 ` Yusuke Hayashi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026112041-suffrage-bonanza-e079@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=florian.fainelli@broadcom.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux-staging@lists.linux.dev \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
--cc=yusuke8h@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®