From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795264100; b=QWlBOfwnbmAiWjNlDreFdPpzw0wDQCGVashedCmUwU8arRLVz2TdFyKDIWqJBpo/CiP0 dmsA1JHaB1YpNsp1HXloNn5445SfNJ9f8wcZ/svaRDkf3e1yTCAiqEhLWcOFBtm2PJI1V /BnPpbVuH22yl80rj+Ekb58dG+dNEanbSSPWINoDIvcuI2DlCCV0gdhdgAgk+j8RR329w 7m3fqVLxD+HqrxE9R730jq905xD/gQs++LsnscJDD+7NUwMo50u0RArz5KRClbs6ESYbk G57f3Gd4VwrkxDJqHk0caKVvcC0W3zIA8lHNqpp2R8jfQzXNuIFitRyDi80qZnygcQg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795264100; h=Received:DKIM-Signature:Date:From:To:Cc:Subject:Message-ID: References:MIME-Version:Content-Type:Content-Disposition:In-Reply-To; bh=7H6yTJgiXVjurwuVwDh2bU2c+2wm8uECQPTv4Fe2SXA=; b=fmxgws+/NLKIOAC4YhPc9nxBat99vY524jJmvVgbQWJirb4KzfK+a2BWWlR/SA1wUL8H iWU8xxLyJyCQVOGmqFXtGMemyhZSIAMSSJfpluIJqfFlOVIkLCFvvLH8QiiHvW6UlME8v hq3E1Bahy4tEDftw/IMLRmYDL/WDezvpTFA1/TsH/JukgW0FilvAgO4bRcN1pV9OdYnmr V2VebIOVp/Nu1GqwMrfA+WFmtwK164yJpSv5PzKO9iC3vG9bXmkCcSMfZ+Rha5RbOE+4W 3MOUagaD/6Q5BvI8k1TvjIeZsdwGKuT6GM2fX6vTH9F5kbrIsAq6YcUQNcj5APgqjfw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=FwLhBHfu; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 24329606A320; Sat, 21 Nov 2026 12:28:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=FwLhBHfu Received: by smtp.kernel.org (Postfix) with ESMTPSA id E8C5C1F000C4; Sat, 21 Nov 2026 12:28:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1795264099; bh=7H6yTJgiXVjurwuVwDh2bU2c+2wm8uECQPTv4Fe2SXA=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=FwLhBHfufqwXZeNQ6Ov4B6OaGsVBAJ7XCHmXMbe+iEf3NnGJNqugTCNnCqhTQoYAb BBJp9SNsbW6yhDKVEJ6/M/hBR73MRngtUM1/NljbzqQvRj6n7crSDUsPfgMX/4eVTK jV7+LrLJwBAe4skUxuniF7o5VLOvOgLLlBO6ViiFZsG+hhgRLcpEFHLKBUjSQDDmGk L4Fh3bTgM354j6HGyg4U40vIUnu0IGVPRJ4Fs9vivT+LojFuv7a/Ff82Olf3RxtMKF ts2RqWuYnMTRfEfKclwTJSoFxVWJ1701Bek1Vgt8Uz1SODFtG4+KtBrH9xBQyD6p18 BfLyZtdUxyjIA== Date: Sat, 21 Nov 2026 13:28:16 +0100 From: Krzysztof Kozlowski To: Madhavan Ganesan Cc: Johannes Berg , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jeff Johnson , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , linux-wireless@vger.kernel.org, devicetree@vger.kernel.org, ath12k@lists.infradead.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev Subject: Re: [PATCH ath-next v3 15/15] wifi: ath12k: add Wi-Fi 8 PCI driver scaffolding for QCN9575 Message-ID: <20261121-astute-calculating-hippogriff-69ecfc@quoll> References: <20261118-wifi8_qcn9575_bringup-v3-0-9875d2a3953f@oss.qualcomm.com> <20261118-wifi8_qcn9575_bringup-v3-15-9875d2a3953f@oss.qualcomm.com> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20261118-wifi8_qcn9575_bringup-v3-15-9875d2a3953f@oss.qualcomm.com> On Wed, Nov 18, 2026 at 01:45:38PM +0530, Madhavan Ganesan wrote: > Add QCN9575 PCI window register constants (WINDOW_VALUE_MASK [25:19], > WINDOW_STATIC_MASK [31:7], CE_WINDOW_MASK [13:7], UMAC_WINDOW_MASK > [20:14]) and a Wi-Fi 8 reg_base instance (ath12k_wifi8_reg_base) for > per-device window selection. Implement ath12k_wifi8_pci_probe() to > configure QCN9575-specific PCI settings: MSI vector layout (3 MHI, 5 CE, > 8 DP vectors), static window mapping, window register address (0x3278), > and hardware revision. Call ath12k_wifi8_hw_init() at the end of probe > to complete hardware initialization. Define the Wi-Fi 8 PCI driver > struct with the probe callback, and register it with > ath12k_pci_register_driver() in ath12k_wifi8_pci_init(). > > This series only adds Wi-Fi 8 platform scaffolding; QCN9575's CP, DP, > and MAC datapath support will be posted as a follow-up series. > QCN9575_DEVICE_ID is intentionally left out of > ath12k_wifi8_pci_id_table for now, so no physical device can match and > probe until that follow-up series lands. The id_table entry will be > added in the final patch of that series, once QCN9575 is actually > functional. > > Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.6-01243-QCAHKSWPL_SILICONZ-1 > Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.1.c7-00108-QCAHMTSWPL_V1.0_V2.0_SILICONZ_UPSTREAM-3 > > Signed-off-by: Madhavan Ganesan > --- > drivers/net/wireless/ath/ath12k/hal.h | 2 + > drivers/net/wireless/ath/ath12k/wifi7/hal.h | 2 - > drivers/net/wireless/ath/ath12k/wifi8/hal.h | 1 + > drivers/net/wireless/ath/ath12k/wifi8/pci.c | 89 ++++++++++++++++++++++++++++- > 4 files changed, 91 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/wireless/ath/ath12k/hal.h b/drivers/net/wireless/ath/ath12k/hal.h > index 9e88bdf4a93b..b30a8039b2ec 100644 > --- a/drivers/net/wireless/ath/ath12k/hal.h > +++ b/drivers/net/wireless/ath/ath12k/hal.h > @@ -11,6 +11,8 @@ > > struct ath12k_base; > > +#define HAL_CE_WFSS_CE_REG_BASE 0x01b80000 > + > #define HAL_DESC_REO_NON_QOS_TID 16 > > #define HAL_INVALID_PEERID 0x3fff > diff --git a/drivers/net/wireless/ath/ath12k/wifi7/hal.h b/drivers/net/wireless/ath/ath12k/wifi7/hal.h > index 19e02bb16ff2..fe880b0befcb 100644 > --- a/drivers/net/wireless/ath/ath12k/wifi7/hal.h > +++ b/drivers/net/wireless/ath/ath12k/wifi7/hal.h > @@ -31,8 +31,6 @@ > ((hal)->regs->umac_ce1_dest_reg_base) > #define HAL_SEQ_WCSS_UMAC_WBM_REG 0x00a34000 > > -#define HAL_CE_WFSS_CE_REG_BASE 0x01b80000 > - > #define HAL_TCL_SW_CONFIG_BANK_ADDR 0x00a4408c > > /* SW2TCL(x) R0 ring configuration address */ > diff --git a/drivers/net/wireless/ath/ath12k/wifi8/hal.h b/drivers/net/wireless/ath/ath12k/wifi8/hal.h > index c99521abdcb3..89fa9a7f3fd9 100644 > --- a/drivers/net/wireless/ath/ath12k/wifi8/hal.h > +++ b/drivers/net/wireless/ath/ath12k/wifi8/hal.h > @@ -11,6 +11,7 @@ > #include "hal_desc.h" > > /* WCSS Relative address */ > +#define HAL_SEQ_WCSS_UMAC_OFFSET 0xf00000 > #define HAL_SEQ_WCSS_UMAC_CE0_SRC_REG(hal) \ > ((hal)->regs->umac_ce0_src_reg_base) > #define HAL_SEQ_WCSS_UMAC_CE0_DST_REG(hal) \ > diff --git a/drivers/net/wireless/ath/ath12k/wifi8/pci.c b/drivers/net/wireless/ath/ath12k/wifi8/pci.c > index 3975081d167b..fd0489f8333f 100644 > --- a/drivers/net/wireless/ath/ath12k/wifi8/pci.c > +++ b/drivers/net/wireless/ath/ath12k/wifi8/pci.c > @@ -5,14 +5,101 @@ > > #include > > +#include "../core.h" > +#include "../hal.h" > +#include "../hif.h" > +#include "../mhi.h" > +#include "../pci.h" > +#include "hal.h" > +#include "hw.h" > +#include "mhi.h" > #include "pci.h" > > +#define QCN9575_DEVICE_ID 0x1113 > +#define WINDOW_REG_ADDRESS 0x3278 > + > +#define WINDOW_VALUE_MASK GENMASK(25, 19) > +#define WINDOW_STATIC_MASK GENMASK(31, 7) > +#define CE_WINDOW_MASK GENMASK(13, 7) > +#define UMAC_WINDOW_MASK GENMASK(20, 14) > + > +static const struct pci_device_id ath12k_wifi8_pci_id_table[] = { > + {} Why do you need an empty table? > +}; > + > +MODULE_DEVICE_TABLE(pci, ath12k_wifi8_pci_id_table); ... > +static struct ath12k_pci_driver ath12k_wifi8_pci_driver = { > + .name = "ath12k_wifi8_pci", > + .id_table = ath12k_wifi8_pci_id_table, I actually wonder how does it work with such table - what is its purpose? > + .ops.probe = ath12k_wifi8_pci_probe, > + .reg_base = &ath12k_wifi8_reg_base, > +}; Best regards, Krzysztof