From: Suyuan Wang via B4 Relay <devnull+shyckless.gmail.com@kernel.org>
To: tsbogend@alpha.franken.de
Cc: linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 0/2] MIPS: rtlx: Fix two error paths in rtlx_open()
Date: Sat, 21 Nov 2026 15:33:00 +0000 [thread overview]
Message-ID: <20261121-rtlx-v1-0-bc05d6763ec1@gmail.com> (raw)
Two error paths in rtlx_open() leave state behind: a failed
rtlx_init() skips the in_open decrement, so the channel stays busy for
good, and a signal while waiting for the SP program leaves the stack
wait entry on the queue.
Found with a static analysis tool and checked by hand. Compile tested
on mips (maltaaprp_defconfig, W=1); I don't have the hardware.
---
Suyuan Wang (2):
MIPS: rtlx: Drop in_open count when rtlx_init() fails
MIPS: rtlx: Call finish_wait() when rtlx_open() is interrupted
arch/mips/kernel/rtlx.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
next reply other threads:[~2026-11-21 15:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-21 15:33 Suyuan Wang via B4 Relay [this message]
2026-11-21 15:33 ` [PATCH 1/2] MIPS: rtlx: Drop in_open count when rtlx_init() fails Suyuan Wang via B4 Relay
2026-11-21 15:33 ` [PATCH 2/2] MIPS: rtlx: Call finish_wait() when rtlx_open() is interrupted Suyuan Wang via B4 Relay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261121-rtlx-v1-0-bc05d6763ec1@gmail.com \
--to=devnull+shyckless.gmail.com@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=shyckless@gmail.com \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®