From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=103.168.172.150 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795262123; b=pBhOKe04iXVMlNC5m/Um4ul5KktZyrgKz3qlXWqpiBoQEGCjyz381BQi0sfaczwhhR+g 6Njn7BvPJKPotL37E42YMDjnHjXf4GRArwte4r1lEsugXfRaexsmY41x32bK7YO0IjiGW u1AYNcI3p30r2f6JIMMPL80h3TOlyD486BBGJq1NHuJcwMSxlS4QEyhB45jOIkMIS1cO1 k910lhr4/cSlxvIQ6CO5lMJ+BracIti0Ta6PW78kC0T/QwqbvEzRW+VoUvPIPSTv2HOU1 YNYeZ73muFIZm9Q4oAr4ac+dBwEe2FHNZzftBpbF9hfXbaRaRbQWsPkmcIyP3O9GfyA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795262123; h=DMARC-Filter:Received:Received:DKIM-Signature:DKIM-Signature: X-DKIM2-Info:DKIM2-Signature:X-DKIM2-Info:Message-Instance: X-ME-Sender:X-ME-Received:X-ME-Proxy-Cause:X-ME-Proxy:Feedback-ID: Received:From:Date:Subject:MIME-Version:Content-Type: Content-Transfer-Encoding:Message-Id:X-B4-Tracking:X-Change-ID:To:Cc: X-Mailer:X-Developer-Signature:X-Developer-Key; bh=dVICqIJ5zW3htHU6bK76kpvRAK5XFcaQeHCRH3i7ebE=; b=riwFQr92KGgLvBPB0JqTdbBMqRTfOhXnyjTs8pLQoTFJ5gFSM0Tqk/6j8r8PtYNkTpnl Ln1JTevU3SmzBu6uHKfnIw3oiHkQkOUj57OLiNihk3KqEmionorP3fio/C+QnfKvgusSk xliOygevm42FDB25fBlwa1066zllKJWwhLyVOE8En8wWMKeHN+BpufBse/MZ4kwARSLPY g+zrs5e25yUFeDDvM6gZUMPINFoqAWjPNbRrLYg+soYTsaj/lP/af8gaWzYF6o73VRGP1 Icx9sk1pg02Iq9ssh4PNmoNjDxOU3nZpKP6dBhwz5wZlw6eNq8JfqEcfAoTk244rYKA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=ragnatech.se; spf=pass smtp.mailfrom=ragnatech.se; dkim=pass header.d=ragnatech.se header.i=@ragnatech.se header.a=rsa-sha256 header.s=fm2 header.b=tRGhujpv; dkim=pass header.d=messagingengine.com header.i=@messagingengine.com header.a=rsa-sha256 header.s=fm3 header.b=RLYk5YWP; arc=none smtp.remote-ip=103.168.172.150 Received: from fout-a7-smtp.messagingengine.com (fout-a7-smtp.messagingengine.com [103.168.172.150]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4632D606A325 for ; Sat, 21 Nov 2026 11:55:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 4632D606A325 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ragnatech.se Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ragnatech.se Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=ragnatech.se header.i=@ragnatech.se header.a=rsa-sha256 header.s=fm2 header.b=tRGhujpv; dkim=pass (2048-bit key, unprotected) header.d=messagingengine.com header.i=@messagingengine.com header.a=rsa-sha256 header.s=fm3 header.b=RLYk5YWP Received: from phl-compute-02.internal (phl-compute-02.internal [10.202.2.42]) by mailfout.phl.internal (Postfix) with ESMTP id 1E083EC0AE9 for ; Sat, 21 Nov 2026 06:55:21 -0500 (EST) Received: from phl-frontend-04 ([10.202.2.163]) by phl-compute-02.internal (MEProxy); Sat, 21 Nov 2026 06:55:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ragnatech.se; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:message-id:mime-version:reply-to :subject:subject:to:to; s=fm2; t=1795262121; x=1795348521; bh=dV ICqIJ5zW3htHU6bK76kpvRAK5XFcaQeHCRH3i7ebE=; b=tRGhujpvQvIP5foq1K b74ljqwV2nta3YSI2v+L01tAAmw1JKm4lxyEv072pT7hwqbB6r5PscshIhhRVubx 7CDP+Q/WmhYRhGizr4FcP2L4Vd3tmQI9SJLORfAp0MHae5GU97Ddcjjm0kH7rfQo y+jUwwLRMpx3Odf8E39keppfz+zO2pdwgSFRTripJNOxiw4BN5yf3O73HJ9HFEIX EcfYRngN+tcVtvyyqkj/jSx8M9puCObZ6EtmN05aB6xlqBQiHwIRykTXhoZEYT2S 0b8xFaLhoVOrlz0XaMoMxlKgcZoMTZ6jh0WUkeeTveXIqTkPMTHfRSPTEp5LvngQ 2sAg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:message-id:mime-version:reply-to:subject :subject:to:to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1795262121; x=1795348521; bh=dVICqIJ5zW3htHU6bK76kpvRAK5X FcaQeHCRH3i7ebE=; b=RLYk5YWPqdO7TBm0japvS+ficlihwTSgbshKvETG01gI ZrbkgrZqeMgqlQ7hfiCW1+xm4h3L9y/UKR0ayzqTU6FDjV+/jN4lw0BrIvTISw3a kYTewDmNB3N2AuvxSx4oBnXxk04QIV7aNWBpwP9/EzxsrildMX6ttxRgLM8P3F17 IcRmK+tLL5nRD3zzuolT8RuN6/8ayUw64B9p0I0BOzAaLJCldc39YSJJLj7PjdAQ xFichONXPLSPCJO031N5jwFNyoPEbsu9uyHm7m7qdRCu0FZZ2wy7p2XIw6ydlFC2 7aEa03JJtCOjAFfensBrG7Ga/8KB53tKru/rdYv7OA== X-DKIM2-Info: draft=ietf-dkim-dkim2-spec-09; repo=github.com/dkim2wg/interop; date=2026-11-03; sw=lmtpprox; action=sign d=ragnatech.se a=rsa-sha256; DKIM2-Signature: i=1; m=1; t=1795262121; d=ragnatech.se; mf=PG5pa2xhcy5zb2Rlcmx1bmRAcmFnbmF0ZWNoLnNlPg==; rt=PGxpbnV4LWtlcm5lbEB2Z2VyLmtlcm5lbC5vcmc+; s=fm2:rsa-sha256:GCyOQGIKC4vFapWQuxSym0OLM8nw1Whd0jQAtM1YDoDVdn9 eLcH++Oq1oxIo0ipbinb3WN156ZxxtvKHd9/n/mmIhl4wEUmPZ/8E9THFScGLWHP Sc9f4jSL2rqzuRmMyDgeVkvQjrA0X0b3S1Nw8W5YY9lYeyrK0jVIm4LTbkOSI1/S Rk7JrakjfFBDM/Om3sbYXPXfSSFNKa4WEh8HqvKE4lYFA21uxAmurpSwzNqBoHNq +HeJiQIgoWvYRnvUGEK+zt+226nt5LDOtmB51f3Ue/mKtR50yBMZTeGxikbj+Dbr NPEEaGYhkh75+uzIqsDaXnB9AX3wbRXyZd4R/+Q==; X-DKIM2-Info: draft=ietf-dkim-dkim2-spec-09; repo=github.com/dkim2wg/interop; date=2026-11-03; sw=lmtpprox; action=mi-m=1; hc=10; hn=cc,content-transfer-encoding,content-type,date,feedback-id, from,message-id,mime-version,subject,to; Message-Instance: m=1; h=sha256:k75Lbqr2aptnmP7uvf/rvhh3qgUcTsN/Zc3kWBC6fwU=:8x0hF+wkjYDw5ltkamw4MuqQUv0aAsAeETkZeQggL08=; X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: dmFkZTEKe1GzsAlymTs/w9XW2L2vFYNarLnQj5xO2bQE+sZGJy3roUZsHHtT3VjtiT45ZG Yj5b4wQoN25GgfnB9UfAXaRa4+Fl8TPJpF7i2IKUwwmdIE5CnaOemfLBTtsJO2VeKO/Kr8 5X62fLGt2FQeaMPIUs99VQWaO7sa884Eedv4gQkxyfV/Dcc33IXZ7mxOocw5IdGZKQsjSi 09Jhaa8TvmjxUQu0S1QFqHkuxyGjFx5d9ojfKBm3VBioxi70bBzMduDQ8awe11DifVXrOQ O6dnm/sAaczRwshrc2h2m6/KDI1MzqVwe9ccZ6BrvI2er3rL77VwoOEHaz+GZRRaM2oqpn lRKjzFOY6vL31oFABitet7AY2tGv+jobdCDckK303PXJRgISjW4cryEE0JG6vBkmOKUVBA 1r01kIK4Lyyyit+E9MCjtOMlRORMiypgD67xx3UKST2KEIne8QCPHxI71u/bh3ipHW3rbt 5Bk/UV4vurpFaLJPk/M8u/okDxy5y/ecaUy0mV7uBdONOgJJSVwkgEsVEIg9Z55CtcUq1Y DsbDezuyIc87QWR7jtgFsDCEOCr0Un7kOWFktLAIhEymMR9vB00i/XhHB4XNC1DW7rorRz 0k/2nkBbYvRGbpTeR8IY9LeE269DlIWaIYPiNr/EqKtQBC+W6LEwEGn33hdg X-ME-Proxy: Feedback-ID: i80c9496c:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 21 Nov 2026 06:55:20 -0500 (EST) From: =?utf-8?q?Niklas_S=C3=B6derlund?= Date: Sat, 21 Nov 2026 12:54:59 +0100 Subject: [PATCH v2] media: rcar-vin: Return unused buffers correctly X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Message-Id: <20261121-vin-fix-vb2-v2-1-602a3d876853@ragnatech.se> X-B4-Tracking: v=1; b=H4sIAAAAAAAC/22NwQ6CMBBEf4Xs2TV0g1A88R+GQ1sXWA/FtNhoC P9uwavHl5l5s0LkIBzhWqwQOEmU2WegUwFuMn5klHtmoJLqUpPGJB4HeWOyhKRZWUuVqZWGvHg GztFhu/U/ji/7YLfsir0xSVzm8Dnuktp7/81JocK2YauGamguru2CGb1Z2E3nyNBv2/YFRdYQ1 LsAAAA= X-Change-ID: 20260828-vin-fix-vb2-28e1bb24a618 To: =?utf-8?q?Niklas_S=C3=B6derlund?= , Mauro Carvalho Chehab , Geert Uytterhoeven , Magnus Damm , Jacopo Mondi Cc: linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, =?utf-8?q?Niklas_S=C3=B6derlund?= X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1550; i=niklas.soderlund+renesas@ragnatech.se; h=from:subject:message-id; bh=8x0hF+wkjYDw5ltkamw4MuqQUv0aAsAeETkZeQggL08=; b=owEBbQKS/ZANAwAKAQm0/3kE+U0kAcsmYgBrAYafR4cljYFsvw9CBk9hPyZGDeQEinQPTtzYf 0KFRZACqdSJAjMEAAEKAB0WIQRwy9J0OLNPX3a0+3gJtP95BPlNJAUCawGGnwAKCRAJtP95BPlN JGyKD/9w7UomngTaGPHnXNxVPV9gxFnNchUp2UBiurm/5FfDIg+rMhVuye8T6me+fJ8ZcuTyJFV RlT+bNzsp+QjmUQ0nGZ1NCM+igiqxq9yGmrFTauYrexPUrU6R1NnNhVtwwdZ1pW+NE4dEuNtRhW MztvKqH5MgfSN1wvWPXrJGrFILnc/AaUNSxbFj+H8rM4PpRZhzk9Rq3y5yqHC0qlnXOEgxVYION ephQwXq7fu1OBo0QmW/+0y2rGBmAt9/kqJvUHqJ0jak1kcM0IpGZgJFyxAo/9IkWMXECmH1nOkj T6ICqJW1uEBo99kArfqat8qQVfZYSVZEb/GUTeqbrUV6DHC8fDBL3heRNv47ieo7UF2Iap6reci gJMehHmMQ8eWNjP8ZNwYcs+Xg3nBSBjN95wCj4JIXh2swyaQd95V3Qi95VOSI1RaPnMR62fqC1q 1l93hGozHRUiOhTSNowRzohYvBg8YMGc3S82FzPb+sskb8pBDbni2FAQVA7by6V+U6NTug4QRUD BO+0s9ndYosn7YgTjz6uMR2pGbKlxU4PElSzCKgLgWokCcbbcE6PiUQlbJKWerKO+Xpwu7Kr7Z6 HW2o7ou/sFWwrxv/+Q87YIOEOgnnK7L/E4bJPPKEqR29XoteobI+B3VGY+O4kL114nArEb1mY6h iotuSRgvk9J6L1g== X-Developer-Key: i=niklas.soderlund+renesas@ragnatech.se; a=openpgp; fpr=9976695FE98693307BF360A2F1591ABD9588DA5F Unused VB2 buffers should be returned with state DONE not ERROR when stopping. Signed-off-by: Niklas Söderlund --- Changes in v2: - Link to v1: https://patch.msgid.link/20260828-vin-fix-vb2-v1-1-97eb1f4f75c9@ragnatech.se --- * Changes since v1 - Fix unused buffers returned in rvin_stop_streaming() too. --- drivers/media/platform/renesas/rcar-vin/rcar-dma.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/renesas/rcar-vin/rcar-dma.c b/drivers/media/platform/renesas/rcar-vin/rcar-dma.c index 5e515d16c164..d3d1af47f8b1 100644 --- a/drivers/media/platform/renesas/rcar-vin/rcar-dma.c +++ b/drivers/media/platform/renesas/rcar-vin/rcar-dma.c @@ -1434,7 +1434,7 @@ void rvin_stop_streaming(struct rvin_dev *vin) for (unsigned int i = 0; i < HW_BUFFER_NUM; i++) { if (vin->buf_hw[i].buffer) vb2_buffer_done(&vin->buf_hw[i].buffer->vb2_buf, - VB2_BUF_STATE_ERROR); + VB2_BUF_STATE_DONE); } } @@ -1449,7 +1449,7 @@ static void rvin_stop_streaming_vq(struct vb2_queue *vq) dma_free_coherent(vin->dev, vin->format.sizeimage, vin->scratch, vin->scratch_phys); - return_unused_buffers(vin, VB2_BUF_STATE_ERROR); + return_unused_buffers(vin, VB2_BUF_STATE_DONE); } static const struct vb2_ops rvin_qops = { --- base-commit: aa0f4c41d4870a18e65772a1817af16427200371 change-id: 20260828-vin-fix-vb2-28e1bb24a618 Best regards, -- Niklas Söderlund