mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Bjorn Helgaas <helgaas@kernel.org>
To: Yazen Ghannam <yazen.ghannam@amd.com>
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
	bhelgaas@google.com, Lukas Wunner <lukas@wunner.de>,
	Kuppuswamy Sathyanarayanan
	<sathyanarayanan.kuppuswamy@linux.intel.com>,
	Jon Pan-Doh <pandoh@google.com>
Subject: Re: [PATCH 2/4] PCI/AER: Clamp negative ratelimit burst to zero
Date: Fri, 20 Nov 2026 18:12:02 -0600	[thread overview]
Message-ID: <20261121001202.GA917755@bhelgaas> (raw)
In-Reply-To: <20261120211307.GA1524494@yaz-khff2.amd.com>

On Fri, Nov 20, 2026 at 04:13:07PM -0500, Yazen Ghannam wrote:
> On Fri, Nov 20, 2026 at 12:10:43PM -0600, Bjorn Helgaas wrote:
> > On Tue, Nov 10, 2026 at 03:56:12PM -0600, Yazen Ghannam wrote:
> > > The correctable and nonfatal "_ratelimit_burst" attributes store
> > > whatever kstrtoint() parses, so a negative value lands directly in
> > > ratelimit_state.burst.
> > > 
> > > ___ratelimit() reads a negative burst as an uninitialized
> > > ratelimit_state and gives a WARNing.
> > > 
> > > Clamp negative values to zero and document the clamping behavior.
> > > ...
> > 
> > > Fixes: b4fe7398def6 ("PCI/AER: Add sysfs attributes for log ratelimits")
> > > Reported-by: Sashiko <sashiko-bot@kernel.org>
> > > Closes: https://lore.kernel.org/linux-pci/20260714191826.BA81E1F000E9@smtp.kernel.org/
> > > Signed-off-by: Yazen Ghannam <yazen.ghannam@amd.com>
> > > ---
> > >  .../ABI/testing/sysfs-bus-pci-devices-aer     | 21 ++++++++++++-------
> > >  drivers/pci/pcie/aer.c                        |  3 +++
> > >  2 files changed, 17 insertions(+), 7 deletions(-)
> > > 
> > > diff --git a/Documentation/ABI/testing/sysfs-bus-pci-devices-aer b/Documentation/ABI/testing/sysfs-bus-pci-devices-aer
> > > index 5ed284523956..215cf8bd4c30 100644
> > > --- a/Documentation/ABI/testing/sysfs-bus-pci-devices-aer
> > > +++ b/Documentation/ABI/testing/sysfs-bus-pci-devices-aer
> > > @@ -130,9 +130,10 @@ What:		/sys/bus/pci/devices/<dev>/aer/correctable_ratelimit_interval_ms
> > >  Date:		May 2025
> > >  KernelVersion:	6.16.0
> > >  Contact:	linux-pci@vger.kernel.org
> > > -Description:	Writing 0 disables AER correctable error log ratelimiting.
> > > -		Writing a positive value sets the ratelimit interval in ms.
> > > -		Default is DEFAULT_RATELIMIT_INTERVAL (5000 ms).
> > > +Description:	Writing 0, or any negative value, disables AER correctable
> > > +		error log ratelimiting. Writing a positive value sets the
> > > +		ratelimit interval in ms. Default is
> > > +		DEFAULT_RATELIMIT_INTERVAL (5000 ms).
> > >  
> > >  What:		/sys/bus/pci/devices/<dev>/aer/correctable_ratelimit_burst
> > >  Date:		May 2025
> > > @@ -143,14 +144,17 @@ Description:	Ratelimit burst for correctable error logs. Writing a value
> > >  		before ratelimiting. Reading gets the current ratelimit
> > >  		burst. Default is DEFAULT_RATELIMIT_BURST (10).
> > >  
> > > +		Writing 0, or any negative value, suppresses all logs
> > > +		unless the interval attribute is also 0.
> > > +
> > >  What:		/sys/bus/pci/devices/<dev>/aer/nonfatal_ratelimit_interval_ms
> > >  Date:		May 2025
> > >  KernelVersion:	6.16.0
> > >  Contact:	linux-pci@vger.kernel.org
> > > -Description:	Writing 0 disables AER non-fatal uncorrectable error log
> > > -		ratelimiting. Writing a positive value sets the ratelimit
> > > -		interval in ms. Default is DEFAULT_RATELIMIT_INTERVAL
> > > -		(5000 ms).
> > > +Description:	Writing 0, or any negative value, disables AER non-fatal
> > > +		uncorrectable error log ratelimiting. Writing a positive
> > > +		value sets the ratelimit interval in ms. Default is
> > > +		DEFAULT_RATELIMIT_INTERVAL (5000 ms).
> > >  
> > >  What:		/sys/bus/pci/devices/<dev>/aer/nonfatal_ratelimit_burst
> > >  Date:		May 2025
> > > @@ -161,3 +165,6 @@ Description:	Ratelimit burst for non-fatal uncorrectable error logs.
> > >  		allowed per interval before ratelimiting. Reading gets the
> > >  		current ratelimit burst. Default is DEFAULT_RATELIMIT_BURST
> > >  		(10).
> > > +
> > > +		Writing 0, or any negative value, suppresses all logs
> > > +		unless the interval attribute is also 0.
> > > diff --git a/drivers/pci/pcie/aer.c b/drivers/pci/pcie/aer.c
> > > index 6f2460231422..401cd3a1b3d0 100644
> > > --- a/drivers/pci/pcie/aer.c
> > > +++ b/drivers/pci/pcie/aer.c
> > > @@ -752,6 +752,9 @@ const struct attribute_group aer_stats_attr_group = {
> > >  		if (kstrtoint(buf, 0, &burst) < 0)			\
> > >  			return -EINVAL;					\
> > >  									\
> > > +		if (burst < 0)						\
> > > +			burst = 0;					\
> > 
> > Why don't we just return -EINVAL if the user writes a negative value
> > to either *_ratelimit_interval_ms or *_ratelimit_burst?
> > 
> > I don't think there's any reasonable interpretation of negative
> > values in either case.
> 
> Right, that's fair. I think the reason to clamp was to be consistent
> with the current code.
> 
> Would you like a follow up patch?
> 
> > Any non-negative value for the interval makes sense (0 disables).
> > 
> > Any positive value makes sense for burst; I don't know what a 0 burst
> > value could mean, so maybe that should be an error too?
> 
> "burst == 0" came from here:
> 084a990ded63 ("ratelimit: Allow zero ->burst to disable ratelimiting")
> 
> IIUC, the goal is to **always** hide/disable the messages. IOW, keep
> logging the errors internally based on the interval, but don't print any
> kernel messages for them. The user can still get the error logs from the
> trace event and leave the kernel buffer alone.

OK, so burst==0 should have the "usual" semantics (disable
ratelimiting IIUC).

Can we make a replacement for this patch?

  - Return -EINVAL for negative values written to either
    *_ratelimit_interval_ms or *_ratelimit_burst 

  - I think the existing *_ratelimit_interval_ms documentation would
    be fine, no change required

  - *_ratelimit_burst documentation needs something, but I don't know
    what.  084a990ded63 ("ratelimit: Allow zero ->burst to disable
    ratelimiting") suggests that burst==0 disables ratelimiting, but 
    you wrote "suppresses all logs", which sounds like the opposite of
    disabling ratelimiting.

    Also, I don't know what "unless the interval attribute is also 0"
    means.  What *does* happen when interval==0 and burst==0?

The pci/aer branch is mutable, so we can just replace the existing
patch.

  reply	other threads:[~2026-11-21  0:12 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-10 21:56 [PATCH 0/4] AER sysfs fixes Yazen Ghannam
2026-11-10 21:56 ` [PATCH 1/4] MAINTAINERS: Add the AER sysfs ABI file to PCI SUBSYSTEM Yazen Ghannam
2026-11-10 21:56 ` [PATCH 2/4] PCI/AER: Clamp negative ratelimit burst to zero Yazen Ghannam
2026-11-20 18:10   ` Bjorn Helgaas
2026-11-20 21:13     ` Yazen Ghannam
2026-11-21  0:12       ` Bjorn Helgaas [this message]
2026-11-10 21:56 ` [PATCH 3/4] PCI/AER: Report the ratelimit interval in milliseconds Yazen Ghannam
2026-11-18 16:39   ` Sang-Heon Jeon
2026-11-10 21:56 ` [PATCH 4/4] PCI/AER: Hide the "aer" sysfs directory on devices without AER Yazen Ghannam
2026-11-19  0:02 ` [PATCH 0/4] AER sysfs fixes Bjorn Helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261121001202.GA917755@bhelgaas \
    --to=helgaas@kernel.org \
    --cc=bhelgaas@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lukas@wunner.de \
    --cc=pandoh@google.com \
    --cc=sathyanarayanan.kuppuswamy@linux.intel.com \
    --cc=yazen.ghannam@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®