From: "Pali Rohár" <pali@kernel.org>
To: Brian Mak <bmak@nvidia.com>
Cc: "Hans de Goede" <hansg@kernel.org>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Kurt Borja" <kuurtb@gmail.com>,
"Stuart Hayes" <stuart.w.hayes@gmail.com>,
"Matthew Garrett" <mjg59@srcf.ucam.org>,
"Lyndon Sanche" <lsanche@lyndeno.ca>,
"Armin Wolf" <W_Armin@gmx.de>,
"Prasanth Ksr" <prasanth.ksr@dell.com>,
"Jonathan Corbet" <corbet@lwn.net>,
"Shuah Khan" <skhan@linuxfoundation.org>,
"Randy Dunlap" <rdunlap@infradead.org>,
platform-driver-x86@vger.kernel.org, Dell.Client.Kernel@dell.com,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/8] platform: dell: Allow DELL_LAPTOP to be arch-independent
Date: Sat, 21 Nov 2026 01:48:28 +0100 [thread overview]
Message-ID: <20261121004828.rk2k2cq4id2ixkal@pali> (raw)
In-Reply-To: <20261121000556.173028-5-bmak@nvidia.com>
On Friday 20 November 2026 16:05:50 Brian Mak wrote:
> CONFIG_DELL_LAPTOP is currently not available on ARM64, due to a
> dependency on CONFIG_SERIO_I8042. This dependency is actually not
> necessary, as there is a fallback. Make it optional.
i8042 is used for controlling touchpad LED and for receiving rfkill
events when the dell-rbtn is not supported on the particular machine.
Touchpad led is available on more Vostro and Inspirion machines and
there is no fallback or detection of i8042 at all. Even there is no
error checking.
And for receiving rfkill events it is same situation.
So the dell-laptop driver expects that the SERIO_I8042 is enabled and
compiled in.
If none of these functionality is available on arm64 HW, then it makes
sense to make the SERIO_I8042 only for x86. And then in the dell-laptop
driver marking the x86 specific dependency via ifdefs. Which allows to
compile driver on arm64 without those specific functionalities.
> Signed-off-by: Brian Mak <bmak@nvidia.com>
> ---
> drivers/platform/dell/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/dell/Kconfig b/drivers/platform/dell/Kconfig
> index 7030f817b6af..0223e2373508 100644
> --- a/drivers/platform/dell/Kconfig
> +++ b/drivers/platform/dell/Kconfig
> @@ -77,7 +77,7 @@ config DELL_LAPTOP
> depends on ACPI_VIDEO || ACPI_VIDEO = n
> depends on RFKILL || RFKILL = n
> depends on DELL_WMI || DELL_WMI = n
> - depends on SERIO_I8042
> + depends on SERIO_I8042 || SERIO_I8042 = n
> depends on DELL_SMBIOS
> select POWER_SUPPLY
> select LEDS_CLASS
> --
> 2.53.0
>
next prev parent reply other threads:[~2026-11-21 0:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-21 0:05 [PATCH 0/8] platform: dell: Move out of x86 and support Dell XPS 16 Creator Edition Brian Mak
2026-11-21 0:05 ` [PATCH 1/8] platform/x86: dell: Make uart-backlight x86 only Brian Mak
2026-11-21 0:05 ` [PATCH 2/8] platform: dell: Move out of x86 directory Brian Mak
2026-11-21 0:05 ` [PATCH 3/8] MAINTAINERS: Add Dell platform drivers entry Brian Mak
2026-11-21 0:05 ` [PATCH 4/8] platform: dell: Allow DELL_LAPTOP to be arch-independent Brian Mak
2026-11-21 0:48 ` Pali Rohár [this message]
2026-11-21 0:05 ` [PATCH 5/8] platform: dell: smbios-wmi: Fix probe on RTX Spark Brian Mak
2026-11-21 0:05 ` [PATCH 6/8] platform: dell: smbios: Add quirk for non-functional calling interface Brian Mak
2026-11-21 0:38 ` Pali Rohár
2026-11-21 0:45 ` Brian Mak
2026-11-21 0:51 ` Pali Rohár
2026-11-21 0:05 ` [PATCH 7/8] platform: dell: laptop: Don't load if SMBIOS calls are non-functional Brian Mak
2026-11-21 0:05 ` [PATCH 8/8] platform: dell: pc: " Brian Mak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261121004828.rk2k2cq4id2ixkal@pali \
--to=pali@kernel.org \
--cc=Dell.Client.Kernel@dell.com \
--cc=W_Armin@gmx.de \
--cc=bmak@nvidia.com \
--cc=corbet@lwn.net \
--cc=hansg@kernel.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=kuurtb@gmail.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lsanche@lyndeno.ca \
--cc=mjg59@srcf.ucam.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=prasanth.ksr@dell.com \
--cc=rdunlap@infradead.org \
--cc=skhan@linuxfoundation.org \
--cc=stuart.w.hayes@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®