mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Borislav Petkov <bp@alien8.de>
To: Melody Wang <huibo.wang@amd.com>
Cc: x86@kernel.org, LKML <linux-kernel@vger.kernel.org>,
	Tom Lendacky <thomas.lendacky@amd.com>,
	ardb@kernel.org
Subject: Re: [PATCH v6 5/7] x86/sev: Register Alternate Injection protocol during OVMF boot
Date: Fri, 20 Nov 2026 19:30:52 -0800	[thread overview]
Message-ID: <20261121033052.GDawEQbFJ7XyDOM-K-@fat_crate.local> (raw)
In-Reply-To: <bc08967cc41dd4454c75e9315e37dbe34225e258.1793926736.git.huibo.wang@amd.com>

On Fri, Nov 06, 2026 at 01:25:31AM +0000, Melody Wang wrote:
> The SVSM provides the SVSM_APIC_CONFIG_EMULATION protocol to register
> and deregister Alternate Injection. This configuration must be completed

Unknown word [deregister] in commit message. Use "unregister".

But you said that the spec calls it "deregister". Oh well...

> before ExitBootServices() is called. Therefore, OVMF needs to invoke
> this protocol early to set up Alternate Injection for SEV-SNP guests.
> 
> Implement this registration by default for guests that have SEV-SNP
> Alternate Injection enabled.
> 
> Signed-off-by: Melody Wang <huibo.wang@amd.com>
> ---
>  drivers/firmware/efi/libstub/efistub.h  | 11 ++++++++
>  drivers/firmware/efi/libstub/x86-stub.c | 36 ++++++++++++++++++++++++-
>  include/linux/efi.h                     |  2 ++
>  3 files changed, 48 insertions(+), 1 deletion(-)

...

> diff --git a/drivers/firmware/efi/libstub/x86-stub.c b/drivers/firmware/efi/libstub/x86-stub.c
> index a2f193da9bde..878f61cd6fab 100644
> --- a/drivers/firmware/efi/libstub/x86-stub.c
> +++ b/drivers/firmware/efi/libstub/x86-stub.c
> @@ -786,6 +786,39 @@ static efi_status_t exit_boot(struct boot_params *boot_params, void *handle)
>  	return EFI_SUCCESS;
>  }
>  
> +/*
> + * When the guest is running at VMPL2 with Alternate Injection enabled,
> + * register Alternate Injection before ExitBootServices().
> + *
> + * Return true in the first conditional to mean that this is not an Alternate
> + * Injection guest and boot can continue. If it is an Alternate Injection guest,
> + * both failure to locate the protocol and to register it, means fail the boot.
> + */

So since we have a CONFIG_AMD_ALTERNATE_INJ config symbol, the intent is to
put all that functionality behind it so you can do something like this:

> +static bool svsm_register_alt_inj(void)
> +{
> +	efi_guid_t alt_inj_proto = OVMF_SEV_ALT_INJ_REGISTER_PROTOCOL_GUID;
> +	sev_alt_inj_register_protocol_t *proto;
> +	efi_status_t status;

        if (!IS_ENABLED(CONFIG_AMD_ALTERNATE_INJ))
                return true;

> +
> +	if (!early_is_sevsnp_guest() || !snp_vmpl ||
> +	    !(sev_get_status() & MSR_AMD64_SNP_ALTERNATE_INJ))
> +		return true;
> +
> +	status = efi_bs_call(locate_protocol, &alt_inj_proto, NULL, (void **)&proto);
> +	if (status != EFI_SUCCESS) {
> +		efi_err("Alternate Injection registration protocol not exist\n");
> +		return false;
> +	}
> +
> +	status = efi_call_proto(proto, sev_register_alt_inj);
> +	if (status != EFI_SUCCESS) {
> +		efi_err("Alternate Injection registration protocol failed\n");
> +		return false;
> +	}
> +
> +	return true;
> +}

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette

  reply	other threads:[~2026-11-21  3:31 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-06  1:25 [PATCH v6 0/7] Alternate Injection: Secure Interrupt Delivery for SEV-SNP Guests - Guest Support Melody Wang
2026-11-06  1:25 ` [PATCH v6 1/7] x86/sev: Add support for Alternate Injection Melody Wang
2026-11-08  2:12   ` Borislav Petkov
2026-11-20 17:04   ` Tom Lendacky
2026-11-06  1:25 ` [PATCH v6 2/7] x86/apic: Add an SVSM APIC driver Melody Wang
2026-11-20 20:47   ` Tom Lendacky
2026-11-06  1:25 ` [PATCH v6 3/7] x86/sev: Route unsupported APIC register accesses to the hypervisor APIC emulation Melody Wang
2026-11-19  6:19   ` Borislav Petkov
2026-11-20 20:56   ` Tom Lendacky
2026-11-06  1:25 ` [PATCH v6 4/7] x86/sev: Add a function to contain all SEV-specific setup operations Melody Wang
2026-11-06  1:25 ` [PATCH v6 5/7] x86/sev: Register Alternate Injection protocol during OVMF boot Melody Wang
2026-11-21  3:30   ` Borislav Petkov [this message]
2026-11-06  1:25 ` [PATCH v6 6/7] x86/sev: Allow the guest to configure interrupt vectors for the hypervisor Melody Wang
2026-11-06  1:25 ` [PATCH v6 7/7] x86/sev: Indicate that Alternate Injection is supported in the guest Melody Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261121033052.GDawEQbFJ7XyDOM-K-@fat_crate.local \
    --to=bp@alien8.de \
    --cc=ardb@kernel.org \
    --cc=huibo.wang@amd.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=thomas.lendacky@amd.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®