From: Matthew Laux <matthew.laux@gmail.com>
To: Mauro Carvalho Chehab <mchehab@kernel.org>,
Hans Verkuil <hverkuil@kernel.org>,
Mehdi Djait <mehdi.djait@bootlin.com>
Cc: linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
Matthew Laux <matthew.laux@gmail.com>
Subject: [PATCH v7 07/12] media: tw9900: power down analog blocks in runtime suspend
Date: Fri, 20 Nov 2026 21:55:18 -0600 [thread overview]
Message-ID: <20261121035523.26764-8-matthew.laux@gmail.com> (raw)
In-Reply-To: <20261121035523.26764-1-matthew.laux@gmail.com>
On boards without a controllable supply or reset GPIO, runtime suspend
leaves the decoder fully powered. Set the CLK/Y/C power-down bits in
ANALOG_CTL and the PLL power-down bit in ANAL_CTL_II before cutting
power. Runtime resume rewrites both registers from the init table.
Signed-off-by: Matthew Laux <matthew.laux@gmail.com>
---
drivers/media/i2c/tw9900.c | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/drivers/media/i2c/tw9900.c b/drivers/media/i2c/tw9900.c
index 585509c1b41d..b2b754e898c2 100644
--- a/drivers/media/i2c/tw9900.c
+++ b/drivers/media/i2c/tw9900.c
@@ -34,6 +34,9 @@
#define TW9900_REG_CKHY_HSDLY 0x04
#define TW9900_REG_OUT_CTRL_I 0x05
#define TW9900_REG_ANALOG_CTL 0x06
+#define TW9900_REG_ANALOG_CTL_CLK_PDN BIT(3)
+#define TW9900_REG_ANALOG_CTL_Y_PDN BIT(2)
+#define TW9900_REG_ANALOG_CTL_C_PDN BIT(1)
#define TW9900_REG_CROP_HI 0x07
#define TW9900_REG_VDELAY_LO 0x08
#define TW9900_REG_VACTIVE_LO 0x09
@@ -48,6 +51,7 @@
#define TW9900_REG_HUE 0x15
#define TW9900_REG_VBI_CNTL 0x19
#define TW9900_REG_ANAL_CTL_II 0x1A
+#define TW9900_REG_ANAL_CTL_II_PLL_PDN BIT(6)
#define TW9900_REG_OUT_CTRL_II 0x1B
#define TW9900_REG_STD 0x1C
#define TW9900_REG_STD_AUTO_PROGRESS BIT(7)
@@ -689,6 +693,13 @@ static int tw9900_runtime_suspend(struct device *dev)
mutex_lock(&tw9900->mutex);
+ tw9900_write_reg(tw9900->client, TW9900_REG_ANALOG_CTL,
+ TW9900_REG_ANALOG_CTL_CLK_PDN |
+ TW9900_REG_ANALOG_CTL_Y_PDN |
+ TW9900_REG_ANALOG_CTL_C_PDN);
+ tw9900_write_reg(tw9900->client, TW9900_REG_ANAL_CTL_II,
+ TW9900_REG_ANAL_CTL_II_PLL_PDN);
+
if (tw9900->reset_gpio)
gpiod_set_value_cansleep(tw9900->reset_gpio, 1);
--
2.47.3
next prev parent reply other threads:[~2026-11-21 3:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-21 3:55 [PATCH v7 00/12] Add driver for StarTech USB3HDCAP capture device Matthew Laux
2026-11-21 3:55 ` [PATCH v7 01/12] media: tw9900: Disable regulator on runtime resume failure Matthew Laux
2026-11-21 3:55 ` [PATCH v7 02/12] media: tw9900: release the device when stopping the stream fails Matthew Laux
2026-11-21 3:55 ` [PATCH v7 03/12] media: tw9900: accept the TW9910 chip ID Matthew Laux
2026-11-21 3:55 ` [PATCH v7 04/12] media: tw9900: add saturation, hue and sharpness controls Matthew Laux
2026-11-21 3:55 ` [PATCH v7 05/12] media: tw9900: program all mode registers in the PAL table Matthew Laux
2026-11-21 3:55 ` [PATCH v7 06/12] media: tw9900: power off the device on remove if still active Matthew Laux
2026-11-21 3:55 ` Matthew Laux [this message]
2026-11-21 3:55 ` [PATCH v7 08/12] media: tw9900: use runtime PM autosuspend Matthew Laux
2026-11-21 3:55 ` [PATCH v7 09/12] media: tw9900: allow board-specific register tables via platform data Matthew Laux
2026-11-21 3:55 ` [PATCH v7 10/12] media: tw9900: add S-Video input and progressive source detection Matthew Laux
2026-11-21 3:55 ` [PATCH v7 11/12] media: Add subdevice driver for the Mstar MST3367 HDMI receiver Matthew Laux
2026-11-21 3:55 ` [PATCH v7 12/12] media: add driver for StarTech USB3HDCAP Matthew Laux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261121035523.26764-8-matthew.laux@gmail.com \
--to=matthew.laux@gmail.com \
--cc=hverkuil@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=mehdi.djait@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®