mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Maurizio Casciano <mauriziocasciano7@gmail.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Sakari Ailus <sakari.ailus@iki.fi>
Cc: Maurizio Casciano <mauriziocasciano7@gmail.com>,
	Sakari Ailus <sakari.ailus@linux.intel.com>,
	Jacopo Mondi <jacopo.mondi@ideasonboard.com>,
	Nicholas Roth <nicholas@rothemail.net>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Bingbu Cao <bingbu.cao@amd.com>,
	Dan Scally <dan.scally@ideasonboard.com>,
	Hans de Goede <hansg@kernel.org>,
	Andy Shevchenko <andy@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Andy Shevchenko <andriy.shevchenko@intel.com>,
	linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-staging@lists.linux.dev
Subject: Re: [PATCH v10 02/15] media: ov8858: support 19.2 MHz clock and manual white balance
Date: Sat, 21 Nov 2026 14:31:29 +0100	[thread overview]
Message-ID: <20261121133148.1240789-2-mauriziocasciano7@gmail.com> (raw)
In-Reply-To: <20261112212234.GA699509@killaraus.ideasonboard.com>

Hi Sakari and Laurent,

Thanks for the review. I split the OV8858 clock support out into a
local test patch.

> Any others notices that should be added?

The 2017 Intel notice in v10 came from the OV5670 manual white-balance
code, which I dropped from the clock-only change. The retained OV8858
register table matches 18 of 23 address/value pairs in Intel's GPLv2
OV8858 initialization table from the Yoga Book vendor kernel [1].
One more pair, 0x3f08 = 0x08, is also present in the existing Linux
OV8858 driver. I can trace the four changed PLL values (0x0300, 0x0302,
0x030b and 0x030d) back to the first public Yoga Book patch. Their
earlier source is still unverified. The revised clock-only patch
cites [1], carries its 2014 Intel OV8858 notice and records where
the four adjusted values first appeared. I removed the notice
that came with the dropped OV5670 manual white-balance code.

> The Assisted-by: tags are no longer used, please remove them.

I removed those trailers from the local series and kept the description
of Codex's contribution in the clock patch commit message.

> The 24 MHz configurations are lane number (and variant) dependent.

The only 19.2 MHz configuration I have is for an OV8858 R2A with four
data lanes and a 360 MHz link frequency. The test patch rejects other
revision and lane combinations at 19.2 MHz. At 24 MHz it retains the
existing register values for R1A with two lanes and R2A with two or four
lanes. I compared the table writes and final values for both modes in
each configuration. The clock writes move later in the sequence, and
24 MHz still needs a hardware test.

The Media CI review of v10 patch 02 flagged the same issue [2]. The
unconditional 19.2 MHz table selection in v10 could replace the PLL
settings chosen for a two-lane sensor. The revision and lane check in
the local patch prevents that override.

Laurent wrote:
> That's indeed not a good UAPI.

I dropped the red and blue balance controls from both sensor changes
in the local series. The existing scalar digital-gain control remains.
Any proposal for per-component gain can be reviewed separately.

On the X91L with the local 7.4.0-rc1 integration kernel, raw capture
produced 30 distinct frames on each pass in a front, rear, front test.
The rear OV8858 ran with four lanes at a 360 MHz link frequency. On
the front capture node, v4l2-compliance reported 40 passes, 7 failures
and no warnings. The same seven checks failed with the same diagnostics
on the 7.2 baseline using the same node, camera and tool version.
I repeated the capture sequence with the AtomISP and WV517S fixes in
place after retrying the front sensor probe.
On the exact revised 7.4 image, OV8858 bound automatically and
captured 30 distinct rear RAW frames before and after lens rebind.

[1] https://github.com/jekhor/yogabook-linux-android-kernel/blob/574bae692716f1b14093497bfab8a007fe8e460b/drivers/external_drivers/camera/drivers/media/i2c/ov8858.h
[2] https://linuxtv.org/mailman3/hyperkitty/list/media-ci@linuxtv.org/message/PWB2NAGYQ7EZVEDZNXK3R3UKZ7GGYAQY/

With Best Regards,
Maurizio Casciano

  reply	other threads:[~2026-11-21 13:32 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-02  8:57 [PATCH v10 00/15] media: Add Lenovo Yoga Book camera support Maurizio Casciano via B4 Relay
2026-10-02  8:57 ` [PATCH v10 01/15] media: ov8858: Extract digital gain programming Maurizio Casciano via B4 Relay
2026-10-02  9:54   ` Andy Shevchenko
2026-10-02  8:57 ` [PATCH v10 02/15] media: ov8858: support 19.2 MHz clock and manual white balance Maurizio Casciano via B4 Relay
2026-11-12 21:04   ` Sakari Ailus
2026-11-12 21:22     ` Laurent Pinchart
2026-11-21 13:31       ` Maurizio Casciano [this message]
2026-10-02  8:57 ` [PATCH v10 03/15] media: ov2740: Use C99 initializers for ACPI IDs Maurizio Casciano via B4 Relay
2026-10-02  8:57 ` [PATCH v10 04/15] media: ov2740: Add OVTI2740 ACPI ID Maurizio Casciano via B4 Relay
2026-10-02  8:57 ` [PATCH v10 05/15] media: ov8858: Add INT3477 " Maurizio Casciano via B4 Relay
2026-11-12 21:07   ` Sakari Ailus
2026-10-02  8:57 ` [PATCH v10 06/15] media: intel: ipu-bridge: Add Yoga Book camera sensors Maurizio Casciano via B4 Relay
2026-10-02  8:57 ` [PATCH v10 07/15] media: atomisp: Add Yoga Book camera configuration Maurizio Casciano via B4 Relay
2026-10-02  8:57 ` [PATCH v10 08/15] media: ov2740: support 288 MHz link frequency Maurizio Casciano via B4 Relay
2026-10-02  8:57 ` [PATCH v10 09/15] media: intel: ipu-bridge: select OV2740 frequency by IPU ID Maurizio Casciano via B4 Relay
2026-10-03 14:41   ` Andy Shevchenko
2026-10-02  8:57 ` [PATCH v10 10/15] media: atomisp: derive CSI-2 timing from sensor link frequency Maurizio Casciano via B4 Relay
2026-10-02  8:57 ` [PATCH v10 11/15] media: ov2740: release group hold after gain write errors Maurizio Casciano via B4 Relay
2026-10-02  8:57 ` [PATCH v10 12/15] media: ov2740: add manual white balance controls Maurizio Casciano via B4 Relay
2026-10-02  8:57 ` [PATCH v10 13/15] media: atomisp: Use struct v4l2_area for padding Maurizio Casciano via B4 Relay
2026-10-02  8:57 ` [PATCH v10 14/15] media: atomisp: allow raw Bayer capture Maurizio Casciano via B4 Relay
2026-10-02  8:57 ` [PATCH v10 15/15] media: i2c: Add WV517S lens actuator driver Maurizio Casciano via B4 Relay
2026-11-21 13:31 ` [PATCH v10 00/15] media: Add Lenovo Yoga Book camera support Maurizio Casciano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261121133148.1240789-2-mauriziocasciano7@gmail.com \
    --to=mauriziocasciano7@gmail.com \
    --cc=andriy.shevchenko@intel.com \
    --cc=andy@kernel.org \
    --cc=bingbu.cao@amd.com \
    --cc=dan.scally@ideasonboard.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hansg@kernel.org \
    --cc=jacopo.mondi@ideasonboard.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=mchehab@kernel.org \
    --cc=nicholas@rothemail.net \
    --cc=sakari.ailus@iki.fi \
    --cc=sakari.ailus@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®