mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Suyuan Wang via B4 Relay <devnull+shyckless.gmail.com@kernel.org>
Cc: shyckless@gmail.com, netdev@vger.kernel.org, edumazet@kernel.org,
	davem@davemloft.net, linux-kernel@vger.kernel.org,
	elb12345@hotmail.co.uk, horms@kernel.org, pabeni@redhat.com
Subject: Re: [PATCH net] vlan: require real device netns admin to change GVRP and MVRP
Date: Sat, 21 Nov 2026 15:15:32 -0800	[thread overview]
Message-ID: <20261121151532.56c16e89@kernel.org> (raw)
In-Reply-To: <20261117-vlan-gvrp-v1-1-53a6b0775953@gmail.com>

On Tue, 17 Nov 2026 13:04:41 +0000 Suyuan Wang via B4 Relay wrote:
> The same gap in macsec was fixed in commit ed502e485685 ("macsec:
> require CAP_NET_ADMIN in the device netns for changelink"). Its author
> described the identical VLAN case there and said a separate VLAN patch
> would follow; I could not find one on netdev, so this is sent
> independently.

We can apply this as hardening but I'm not sure this is an issue.
netns can already "disable" the vlan by deleting the interface.
I guess we shouldn't let netns enable the vlan. But then again
I don't see the use case for having a vlan that's not announced,
or the harm announcing it would cause.

  reply	other threads:[~2026-11-21 23:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17 13:04 Suyuan Wang via B4 Relay
2026-11-21 23:15 ` Jakub Kicinski [this message]
2026-11-21 23:20 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261121151532.56c16e89@kernel.org \
    --to=kuba@kernel.org \
    --cc=davem@davemloft.net \
    --cc=devnull+shyckless.gmail.com@kernel.org \
    --cc=edumazet@kernel.org \
    --cc=elb12345@hotmail.co.uk \
    --cc=horms@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=shyckless@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®