mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Vinny Horgan <vinnyhorgan@gmail.com>
To: Richard Weinberger <richard@nod.at>
Cc: linux-kernel@vger.kernel.org, upstream+x86@sigma-star.at,
	rppt@kernel.org, peterz@infradead.org, hpa@zytor.com,
	x86@kernel.org, dave.hansen@linux.intel.com, bp@alien8.de,
	mingo@redhat.com, tglx@kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] x86/Kconfig: enable ROX also when STRICT_KERNEL_RWX is present
Date: Sat, 21 Nov 2026 16:30:03 +0100	[thread overview]
Message-ID: <20261121153003.2499592-1-vinnyhorgan@gmail.com> (raw)
In-Reply-To: <20260625090627.1501095-1-richard@nod.at>

On Thu, Jun 25, 2026 at 11:06:27AM +0200, Richard Weinberger wrote:
> Running a kernel with CONFIG_MODULES=n causes the W+X page dectection
> to trigger:
> x86/mm: Found insecure W+X mapping at address 0xffffffffc033a000

Same here, on a ThinkPad T490 (i5-8365U; "Spectre V2 : Mitigation:
Enhanced / Automatic IBRS", "ITS: Mitigation: Aligned branch/return
thunks") with a CONFIG_MODULES=n kernel based on 7.3.4:

  x86/mm: Found insecure W+X mapping at address 0xffffffffc03f3000

With this patch on top of 7.3.5, the same machine and config boot with
"x86/mm: Checked W+X mappings: passed, no W+X pages found."

Tested-by: Vinny Horgan <vinnyhorgan@gmail.com>

It doesn't seem to have been applied yet: arch/x86/Kconfig in v7.4-rc3,
tip/master and next-20261120 still has the old condition.

QEMU without KVM could not reproduce it: TCG offers no IBRS, so
spectre_v2 falls back to retpolines and no ITS thunk pages are
allocated, with or without indirect_target_selection=force.

I found this, and wrote this reply, with the help of an AI assistant
(Claude) while building a custom kernel for the T490; the results above
are from that machine.

      parent reply	other threads:[~2026-11-21 15:30 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-25  9:06 Richard Weinberger
2026-06-25  9:17 ` Mike Rapoport
2026-06-25  9:19 ` Peter Zijlstra
2026-11-21 15:30 ` Vinny Horgan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261121153003.2499592-1-vinnyhorgan@gmail.com \
    --to=vinnyhorgan@gmail.com \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=richard@nod.at \
    --cc=rppt@kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=tglx@kernel.org \
    --cc=upstream+x86@sigma-star.at \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®