mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Viral Patel <viral8854@gmail.com>
Cc: "David Lechner" <dlechner@baylibre.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Andy Shevchenko" <andy@kernel.org>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Dixit Parmar" <dixitparmar19@gmail.com>,
	"Victor Chernyakin" <chernyakin.victor.j@outlook.com>,
	linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: iio: magnetometer: infineon,tlv493d-a1b6: add TLE493D-W2B6
Date: Sat, 21 Nov 2026 19:29:59 +0000	[thread overview]
Message-ID: <20261121192959.1ea94de9@jic23-hlaptop> (raw)
In-Reply-To: <20261121-tle493d-v2-1-92d7e57cec89@gmail.com>

On Sat, 21 Nov 2026 11:25:10 +0530
Viral Patel <viral8854@gmail.com> wrote:

> Add the Infineon TLE493D-W2B6, a 3D Hall effect magnetic sensor with
> 12-bit resolution per axis and an integrated temperature sensor,
> accessed over I2C. It is a second-generation sibling of the
> TLV493D-A1B6 with a different register interface, so it gets its own
> compatible, but it has the same supply range and the same /INT output
> sharing the SCL pin, so it fits the existing binding.
> 
> The A0 to A3 variants of the part only differ in their default I2C
> address, so a single compatible covers all of them.
> 
> Signed-off-by: Viral Patel <viral8854@gmail.com>
Hi Viral

A few comments inline.  Nothing to stop me merging this if nothing
else comes up though!

Jonathan

> ---
>  .../bindings/iio/magnetometer/infineon,tlv493d-a1b6.yaml   | 14 ++++++++++++--
>  MAINTAINERS                                                |  6 ++++++
>  2 files changed, 18 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/iio/magnetometer/infineon,tlv493d-a1b6.yaml b/Documentation/devicetree/bindings/iio/magnetometer/infineon,tlv493d-a1b6.yaml
> index dd23a9370a71..3f0058cbf538 100644
> --- a/Documentation/devicetree/bindings/iio/magnetometer/infineon,tlv493d-a1b6.yaml
> +++ b/Documentation/devicetree/bindings/iio/magnetometer/infineon,tlv493d-a1b6.yaml
> @@ -4,17 +4,27 @@
>  $id: http://devicetree.org/schemas/iio/magnetometer/infineon,tlv493d-a1b6.yaml#
>  $schema: http://devicetree.org/meta-schemas/core.yaml#
>  
> -title: Infineon Technologies TLV493D Low-Power 3D Magnetic Sensor
> +title: Infineon Technologies TLV493D and TLE493D 3D Magnetic Sensors
>  
>  maintainers:
>    - Dixit Parmar <dixitparmar19@gmail.com>
> +  - Viral Patel <viral8854@gmail.com>
> +
> +description: |

Don't need to retain line wraps so IIRC > rather than | is appropriate.

> +  3D Hall effect magnetic sensors with an I2C interface. The /INT output
> +  shares a pin with SCL.
> +
> +  The A0 to A3 variants of the TLE493D-W2B6 only differ in their default
> +  I2C address (0x35, 0x22, 0x78 and 0x44).

For a binding I'm not sure we need this level of detail.  Perhaps
just keep the first sentence.  I don't mind either way on this one.

>  
>  properties:
>    $nodename:
>      pattern: '^magnetometer@[0-9a-f]+$'
>  
>    compatible:
> -    const: infineon,tlv493d-a1b6
> +    enum:
> +      - infineon,tle493d-w2b6
> +      - infineon,tlv493d-a1b6
>  
>    reg:
>      maxItems: 1
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 02015eaec312..c3004f683e78 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -13117,6 +13117,12 @@ S:	Maintained
>  F:	Documentation/devicetree/bindings/sound/infineon,peb2466.yaml
>  F:	sound/soc/codecs/peb2466.c
>  
> +INFINEON TLE493D-W2B6 DRIVER
> +M:	Viral Patel <viral8854@gmail.com>
> +L:	linux-iio@vger.kernel.org
> +S:	Maintained
> +F:	Documentation/devicetree/bindings/iio/magnetometer/infineon,tlv493d-a1b6.yaml
I guess this is fine for most scripts, but I wonder if anything will drip up over
a file being listed in two maintainers entries.  I wouldn't necessarily worry
about adding the binding to here as you have that line in the actual file anyway
to point people to include you on changes etc.


> +
>  INFINEON TLV493D Driver
>  M:	Dixit Parmar <dixitparmar19@gmail.com>
>  L:	linux-iio@vger.kernel.org
> 


  reply	other threads:[~2026-11-21 19:30 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-21  5:55 [PATCH v2 0/2] iio: magnetometer: add Infineon TLE493D-W2B6 support Viral Patel
2026-11-21  5:55 ` [PATCH v2 1/2] dt-bindings: iio: magnetometer: infineon,tlv493d-a1b6: add TLE493D-W2B6 Viral Patel
2026-11-21 19:29   ` Jonathan Cameron [this message]
2026-11-21  5:55 ` [PATCH v2 2/2] iio: magnetometer: add Infineon TLE493D-W2B6 driver Viral Patel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261121192959.1ea94de9@jic23-hlaptop \
    --to=jic23@kernel.org \
    --cc=andy@kernel.org \
    --cc=chernyakin.victor.j@outlook.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dixitparmar19@gmail.com \
    --cc=dlechner@baylibre.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    --cc=robh@kernel.org \
    --cc=viral8854@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®