mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Joshua Crofts <crofts@kernel.org>
Cc: "Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
	"Marcelo Schmitt" <marcelo.schmitt@analog.com>,
	"Cristian Ciocaltea" <cristian.ciocaltea@collabora.com>,
	linux@analog.com, linux-iio@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	"Michael Hennerich" <michael.hennerich@analog.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Esteban Blanc" <eblanc@baylibre.com>,
	"Jonathan Cameron" <jic23@kernel.org>,
	"David Lechner" <dlechner@baylibre.com>,
	"Andy Shevchenko" <andy@kernel.org>
Subject: Re: [PATCH v2 0/3] iio: adc: Provide mult_fract() and make use of it
Date: Sat, 21 Nov 2026 22:23:13 +0000	[thread overview]
Message-ID: <20261121222313.6352e414@jic23-hlaptop> (raw)
In-Reply-To: <7d50b14d-2df8-4616-ac66-d6dbb1d24061@kernel.org>

On Fri, 20 Nov 2026 11:28:35 +0100
Joshua Crofts <crofts@kernel.org> wrote:

> On 19/11/2026 20:19, Andy Shevchenko wrote:
> > In a couple of IIO ADC driver the suggested new helper mult_fract()
> > may be used. So, provide it and update the straightforward users.
> > 
> > The helper has potential treewide, hence it's provided directly in math.h.
> > 
> > In v2:
> > - updated commit message in patch 1 (Sashiko, c/o Joshua)
> > - used local variable to avoid double evaluation (Sashiko, c/o Joshua)
> > - collected tags (Marcelo)
> > 
> > v1: <20261117091638.1463621-1-andriy.shevchenko@linux.intel.com>
> > 
> > Andy Shevchenko (3):
> >   math.h: Add mult_fract() that takes struct __Txx_fract as argument
> >   iio: adc: ad4030: Switch to use mult_fract() helper
> >   iio: adc: ltc2378: Switch to use mult_fract() helper
> > 
> >  drivers/iio/adc/ad4030.c  | 13 ++++++-------
> >  drivers/iio/adc/ltc2378.c |  4 +++-
> >  include/linux/math.h      |  7 +++++++
> >  3 files changed, 16 insertions(+), 8 deletions(-)
> >   
> 
> Fine now.
> 
> Reviewed-by: Joshua Crofts <crofts@kernel.org>
> 
I briefly wondered if we should wait for some tags related to math.h
but then I couldn't figure out who would be paying attention to that other
than Andy.  So I guess we are fine without. 

Applied to the testing branch of iio.git.

Thanks,

Jonathan



      reply	other threads:[~2026-11-21 22:23 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-19 19:19 Andy Shevchenko
2026-11-19 19:19 ` [PATCH v2 1/3] math.h: Add mult_fract() that takes struct __Txx_fract as argument Andy Shevchenko
2026-11-19 19:19 ` [PATCH v2 2/3] iio: adc: ad4030: Switch to use mult_fract() helper Andy Shevchenko
2026-11-19 19:19 ` [PATCH v2 3/3] iio: adc: ltc2378: " Andy Shevchenko
2026-11-20 10:28 ` [PATCH v2 0/3] iio: adc: Provide mult_fract() and make use of it Joshua Crofts
2026-11-21 22:23   ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261121222313.6352e414@jic23-hlaptop \
    --to=jic23@kernel.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=andy@kernel.org \
    --cc=cristian.ciocaltea@collabora.com \
    --cc=crofts@kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=eblanc@baylibre.com \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@analog.com \
    --cc=marcelo.schmitt@analog.com \
    --cc=michael.hennerich@analog.com \
    --cc=nuno.sa@analog.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®