From: Omokefe Emmanuel Onanaroghene <emmaonana18@gmail.com>
To: tianyi@cloudflare.com, hangbin.liu@linux.dev
Cc: ast@kernel.org, bpf@vger.kernel.org, daniel@iogearbox.net,
davem@davemloft.net, edumazet@kernel.org, emmaonana18@gmail.com,
hawk@kernel.org, horms@kernel.org, john.fastabend@gmail.com,
kernel-team@cloudflare.com, kuba@kernel.org,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
netdev@vger.kernel.org, pabeni@redhat.com, sdf@fomichev.me,
shuah@kernel.org, skhan@linuxfoundation.org,
tianyi.gao@linux.dev
Subject: Re: [PATCH net v4 0/3] selftests: net: veth: propagate check failures to exit status
Date: Sat, 21 Nov 2026 23:41:05 +0100 [thread overview]
Message-ID: <20261121224105.6288-1-emmaonana18@gmail.com> (raw)
In-Reply-To: <20261119012940.32838-1-tianyi@cloudflare.com>
On Thu, 19 Nov 2026 01:29:40 +0000 Tianyi Gao wrote:
> 1. Patch 3 lost its subject prefix. It went out as "[PATCH]
> selftests: net: veth: derive invalid-tx test value from kernel
> max", so patchwork put it in a series of its own [1].
>
> 2. Patch 3 should come first. Patch 1 makes a chk_channels()
> failure fail the script, and from then on the nproc + 1 check
> can fail on a correct kernel. With the fix first, no commit in
> the series reports a false failure.
>
> 3. v4 was posted as a reply to my review of v3. A new version
> should start a new thread, and its change log should link the
> previous postings [2].
Thank you for the thorough review, I appreciate it. All
three are addressed in v5:
https://lore.kernel.org/all/20261121182217.4609-1-emmaonana18@gmail.com/
next prev parent reply other threads:[~2026-11-21 22:42 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-15 21:47 [PATCH net v2] selftests: net: veth: propagate channel-check " Omokefe Emmanuel Onanaroghene
2026-11-16 0:45 ` Tianyi Gao
2026-11-16 0:56 ` Hangbin Liu
2026-11-16 8:41 ` [PATCH net v3 0/2] selftests: net: veth: propagate check " Omokefe Emmanuel Onanaroghene
2026-11-16 8:41 ` [PATCH net v3 1/2] selftests: net: veth: propagate channel-check " Omokefe Emmanuel Onanaroghene
2026-11-19 0:40 ` netdev-bot+sashiko
2026-11-16 8:41 ` [PATCH net v3 2/2] selftests: net: veth: propagate bad-settings check " Omokefe Emmanuel Onanaroghene
2026-11-16 14:04 ` Tianyi Gao
2026-11-19 0:29 ` [PATCH net v4 0/3] selftests: net: veth: propagate " Omokefe Emmanuel Onanaroghene
2026-11-19 0:30 ` [PATCH net v4 1/3] selftests: net: veth: propagate channel-check " Omokefe Emmanuel Onanaroghene
2026-11-19 0:30 ` [PATCH net v4 2/3] selftests: net: veth: propagate bad-settings check " Omokefe Emmanuel Onanaroghene
2026-11-19 0:30 ` [PATCH] selftests: net: veth: derive invalid-tx test value from kernel max Omokefe Emmanuel Onanaroghene
2026-11-19 1:29 ` [PATCH net v4 0/3] selftests: net: veth: propagate check failures to exit status Tianyi Gao
2026-11-19 21:12 ` Jakub Kicinski
2026-11-21 22:41 ` Omokefe Emmanuel Onanaroghene [this message]
2026-11-16 13:08 ` [PATCH net v3 0/2] " Tianyi Gao
2026-11-16 21:50 ` [PATCH net v2] selftests: net: veth: propagate channel-check " netdev-bot+sashiko
2026-11-19 0:40 ` Omokefe Emmanuel Onanaroghene
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261121224105.6288-1-emmaonana18@gmail.com \
--to=emmaonana18@gmail.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=hangbin.liu@linux.dev \
--cc=hawk@kernel.org \
--cc=horms@kernel.org \
--cc=john.fastabend@gmail.com \
--cc=kernel-team@cloudflare.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sdf@fomichev.me \
--cc=shuah@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=tianyi.gao@linux.dev \
--cc=tianyi@cloudflare.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®