From: bryan.odonoghue@linaro.org
To: Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>,
Loic Poulain <loic.poulain@oss.qualcomm.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Hans Verkuil <hverkuil@kernel.org>
Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org, Bryan O'Donoghue <bod@kernel.org>
Subject: [PATCH 0/3] media: qcom: camss: Two routing fixes and one tidy-up
Date: Sun, 22 Nov 2026 02:10:47 +0000 [thread overview]
Message-ID: <20261122-camss-routing-fixes-v1-0-0deeeaca2622@kernel.org> (raw)
This series lands late-enough in the kernel cycle and applies against the
camss-next branch staging to linux-media/next.
Link: https://gitlab.freedesktop.org/linux-media/users/bodonoghue/-/tree/camss-next
First up a patch drops the declaration of CSID2 from x1e/Hamoa since this
CSID doesn't have a corresponding VFE it is entirely useless and violates
our 1:1 mapping between VFE and CSID. Since CSID2 routes nowhere there's no
reason to keep it around.
Second is a fix for a longstanding error in CAMSS which as stemmed from
the original development of post ISPIF devices. These devices have a 1:1
mapping between CSID and VFE so the mapping we have given to user-space
which declares each CSID as connecting to each VFE is just plain wrong on
these devices and has always been.
So the second patch addresses that longstanding issue but, I've been
holding off on fixing this for a while since I believed it might require
extensive surgery, but in the end its quite simple to do.
Finally the third patch is a tidy-up patch which inverts our current logic
of continuously adding new elements to the src_pad_code switch for new SoCs
filtering those SoCs down to a default: statement. In fact is is the old
SoCs which are the exceptional case so, just do the switch for the old and
the default for the new.
Signed-off-by: Bryan O'Donoghue <bod@kernel.org>
---
Bryan O'Donoghue (3):
media: qcom: camss: x1e80100: Fix CSID2 routing to nowhere
media: qcom: camss: Fix CSID to VFE routing for non ISPIF platforms
media: qcom: camss: vfe: Eliminate ever expanding src_pad_code switch logic
drivers/media/platform/qcom/camss/camss-vfe.c | 20 +--------
drivers/media/platform/qcom/camss/camss.c | 59 ++++++++++-----------------
2 files changed, 23 insertions(+), 56 deletions(-)
---
base-commit: 2ad58ca589da80990b7afbcff018777851577f89
change-id: 20261122-camss-routing-fixes-b178bdb84f20
Best regards,
--
---
bod
next reply other threads:[~2026-11-22 2:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-22 2:10 bryan.odonoghue [this message]
2026-11-22 2:10 ` [PATCH 1/3] media: qcom: camss: x1e80100: Fix CSID2 routing to nowhere bryan.odonoghue
2026-11-22 2:10 ` [PATCH 2/3] media: qcom: camss: Fix CSID to VFE routing for non ISPIF platforms bryan.odonoghue
2026-11-22 2:10 ` [PATCH 3/3] media: qcom: camss: vfe: Eliminate ever expanding src_pad_code switch logic bryan.odonoghue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261122-camss-routing-fixes-v1-0-0deeeaca2622@kernel.org \
--to=bryan.odonoghue@linaro.org \
--cc=bod@kernel.org \
--cc=hverkuil@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=loic.poulain@oss.qualcomm.com \
--cc=mchehab@kernel.org \
--cc=vladimir.zapolskiy@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®