mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Jorijn van der Graaf <jorijnvdgraaf@catcrafts.net>
Cc: linux-iio@vger.kernel.org,
	"David Lechner" <dlechner@baylibre.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Andy Shevchenko" <andy@kernel.org>,
	"Eddie James" <eajames@linux.ibm.com>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	"Paulius Zaleckas" <paulius.zaleckas@gmail.com>,
	"Rupesh Majhi" <zoone.rupert@gmail.com>,
	"Joshua Crofts" <crofts@kernel.org>,
	"Luca Weiss" <luca.weiss@fairphone.com>
Subject: Re: [PATCH 3/3] iio: pressure: dps310: add Goermicro SPL07-003 support
Date: Sun, 22 Nov 2026 01:41:45 +0000	[thread overview]
Message-ID: <20261122014145.1bb27261@jic23-hlaptop> (raw)
In-Reply-To: <20261117083954.335814-4-jorijnvdgraaf@catcrafts.net>

On Tue, 17 Nov 2026 09:39:54 +0100
Jorijn van der Graaf <jorijnvdgraaf@catcrafts.net> wrote:

> The Goermicro SPL07-003 needs what the ZTS8032 chip data already
> describes: c31 and c40 in the pressure polynomial, and TMP_CFG bit 7, a
> rate bit on this chip too, left clear. Its TMP_EXT is MEAS_CFG bit 3 and
> stays at the reset value, the internal sensor the datasheet recommends.
> 
> Its c31 and c40 are 12 bit values packed into 0x22-0x24, where the
> ZTS8032 has 16 bit values in 0x22-0x25, so the coefficient block is 21
> bytes. Add a chip flag for that layout, the chip data and the I2C and OF
> IDs.
> 
> Tested on a Fairphone (Gen. 6). The DPS310 temperature workaround skips
> this unit: bit 1 of register 0x32 is set.
> 
> Datasheet: https://media.digikey.com/pdf/Data%20Sheets/Goertek%20Microelectronics%20PDFs/SPL07-003.pdf
> Signed-off-by: Jorijn van der Graaf <jorijnvdgraaf@catcrafts.net>

Applied with one minor tweak to the testing branch of iio.git. That means
they are queued up for the next merge window.

thanks,

Jonathan

> @@ -1495,12 +1517,14 @@ static int dps310_probe(struct i2c_client *client)
>  
>  static const struct i2c_device_id dps310_id[] = {
>  	{ .name = "dps310", .driver_data = (kernel_ulong_t)&dps310_chip_info },
> +	{ .name = "spl07-003", .driver_data = (kernel_ulong_t)&spl07_chip_info },

Only thing I tweaked was to swap the two above around so we are in the same order
in both tables. The reasoning being that all sorts of bugs are a result
of mismatched entrees and having them on same order makes that less likely.

>  	{ .name = "zts8032", .driver_data = (kernel_ulong_t)&zts8032_chip_info },
>  	{ }
>  };
>  MODULE_DEVICE_TABLE(i2c, dps310_id);
>  
>  static const struct of_device_id dps310_of_match[] = {
> +	{ .compatible = "goermicro,spl07-003", .data = &spl07_chip_info },
>  	{ .compatible = "infineon,dps310", .data = &dps310_chip_info },
>  	{ .compatible = "zilltek,zts8032", .data = &zts8032_chip_info },
>  	{ }


      parent reply	other threads:[~2026-11-22  1:41 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17  8:39 [PATCH 0/3] iio: pressure: dps310: add Goermicro SPL07-003 Jorijn van der Graaf
2026-11-17  8:39 ` [PATCH 1/3] dt-bindings: vendor-prefixes: Add Goermicro Jorijn van der Graaf
2026-11-17 10:07   ` Krzysztof Kozlowski
2026-11-17  8:39 ` [PATCH 2/3] dt-bindings: iio: pressure: infineon,dps310: Add Goermicro SPL07-003 Jorijn van der Graaf
2026-11-17 10:08   ` Krzysztof Kozlowski
2026-11-17  8:39 ` [PATCH 3/3] iio: pressure: dps310: add Goermicro SPL07-003 support Jorijn van der Graaf
2026-11-17  9:49   ` Andy Shevchenko
2026-11-22  1:41   ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261122014145.1bb27261@jic23-hlaptop \
    --to=jic23@kernel.org \
    --cc=andy@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=crofts@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=eajames@linux.ibm.com \
    --cc=jorijnvdgraaf@catcrafts.net \
    --cc=krzk+dt@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luca.weiss@fairphone.com \
    --cc=nuno.sa@analog.com \
    --cc=paulius.zaleckas@gmail.com \
    --cc=robh@kernel.org \
    --cc=zoone.rupert@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®