From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=74.125.82.174 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795317865; b=2IAbiBNfjHFbj47f4Ks8ZYZPvKz6TPg3hpFJ1DnI26KLMSCvllnZsorg7jVu8S+wJBbF AModv6qcISAcM/mHkiZkVHpHmtud49/94XOxTBzpPrzbQdkX5b8+wh3ULwP6zxykLLGBr h7GDJ6D4j0Okr2PRkEMIdSAztbIKC0kvNTEWiekxWs5Wd4QIX8tvEQbFw/+rJPgGujyqP zQA99k/CQAn2z105L/uTVHXYGe6emVkCA4C9PPQTWPqTbAes06RHnODkpm1KaeisW7vOn G0sD/ETL5G89nNHUIO0MPGDmJx/lFb6MAn4tdGwSoR2UpXQZRECNAbqCkxrwHEYBRXA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795317865; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: From:To:Cc:Subject:Date:Message-ID:X-Mailer:MIME-Version: Content-Transfer-Encoding; bh=aOEFqW5lAtaSkNAkzmdyW59DFMhZhiBwu6iv961rMbY=; b=KQC2av8rZkrtdPP+e3nCpF0ByCHsqFfrhikU/rxFPvd4cg4iS0pBXPvKzAGhBVipdVKt n+KE7A7exhWiUzwNwzlEeutVX/VPw9vYaBCk6pbkcTzl7YxIT2vauonnRcUbgqOucoKGa 7Zx1K4n+DmMaFG0agv745iBl5vGHwFPV24rFLv6jB3gV6LxP+TH8e9sZMwV7GEC/Gvh/p rbqVHnwd85mMbkZsUeNhpP/77rsUb7k5QU9poyDusZnzqP1f7EeONcp5hBZ6VSsARGv9i sszNrf/iZ6B5UbajD15Y2PdN8GslVTYpLx4LbTS7nlR5bzf6DGRjV+4k4uTGAjnxO/A== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=dXDsO4qb; arc=none smtp.remote-ip=74.125.82.174 Received: from mail-dy1-f174.google.com (mail-dy1-f174.google.com [74.125.82.174]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4C00B606A320 for ; Sun, 22 Nov 2026 03:24:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 4C00B606A320 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=dXDsO4qb Received: by mail-dy1-f174.google.com with SMTP id 5a478bee46e88-386ab9ab619so5670eec.1 for ; Sat, 21 Nov 2026 19:24:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1795317863; x=1795922663; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=aOEFqW5lAtaSkNAkzmdyW59DFMhZhiBwu6iv961rMbY=; b=dXDsO4qb0doDtTMPH3tLoq9v83nS7b29jfcyAu/fHLbG1yUJbLOtM4zTPtgZOhgdhR xyUTRUoHjmXB93YQticpO+2B0ZudRoXzH7Pa1W/ErCR/2wT0ky97OhdCZP3nQiUy0mZZ FGK/P/6ETNynPyEEZOEGBraKyCE/WXOFl9ykOIW39ySwK7KjhcGodOEN3eHjZfKmK4PA FSmmTHazG5LH+n0LwdfeclARlcGr+pthC3oQMe4ude1jYjLwCCBkfy27poDq3Q4FQZS4 uL/aQhdfhy2Z4c7cVHMplBZ/yr0rTo8QqHqsVV6a1gdr+q0n/hN0MQNtWe2K4qgERlpr cF0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1795317863; x=1795922663; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=aOEFqW5lAtaSkNAkzmdyW59DFMhZhiBwu6iv961rMbY=; b=2Ag3OlZswWPNzGqhV/d3L8i5Q3R4/2zHhQOMKCgFZjUXbyjlix+m4ui4WxDGl+QUj9 UZ29jXCJzxSB9JIwEpfakqMQu80E0VrlZYEIS7zWdemy61Y6wYQeDqfA0u5uzd00yV3U a4Xjvk/9ARE6Hqm36K/CNNI7AtQLPySTwUi7KzrDHqdB0TAmYQMjLf7N20lZkq9JBDFw 7r5NVRS3qfZ8c95ErGR7utiCyPRzD2TqRork9jpn5xspQYs+phttQJcuv845MXqRMYxH ZYS5bxn8CVtwijid9OQaVWOKy+yJIPBTHa65iNOyfxfG/FkzzdUEfXHT5wV15YLCRvFX TrpQ== X-Forwarded-Encrypted: i=1; AL+hErHNlN1rE+JUD539iQxAUKa0KHj3teQdQhtdi/m+qRv05xOiTcGnC+C9uiGGxsnZ+x01trU2SjXsrwEa63U=@vger.kernel.org X-Gm-Message-State: APuU4Z9gcNlybcUNUW4YETi+q/MWvI61RER8vM5LsPVDWHOK5xEZumFT Z6Utg/t8RrAnHTa8XokitFZ5q7GRBpi5KgEgJFqKe00Z9nuN0GHU1S1o X-Gm-Gg: AZFdTZfMUwBlK568+zkPHv3KNjxvr3jfnFXSMgBrkAIo6ulANFQwaefIQjZTRPraJP1 anrg5ReWqoO9VZg3XEBgC1xLazrwBz1+TgVkh5m8x6atnVeOvlDg9iY961bqqVJGINENL/07DeX WqorwKs4ApuITCct8de7xEMdgUe7ZZ90zVYF5vOaM2mRNx4LIac2fsfFeuT6bDeWV5hakRlPc+r ZwcZ6lKXWAyA2u3rEQDVtrlgPdNYfxqhZqICxnhXEj5Kge7Eryg3SQSPS4pytUvX1fSKRcMKJ2U q7wtFQvhyGjxrXox60ByPI59rLlqEhsI4PRJzuTSRVaShxdYQMeSIUZqacAcRtM5K41XHEnvoCK y3W5s8+eB2r7snEQHn+1YRQ0KevsHclJ9pXDUQKE9kuqSaTs8f+mFatIPAWINEcsZmAeJX82baP dFNeD0U6VEYXSd5Yw4aPLfALAAhXKYjB4g9vVhtL+wtXABM+0vtEbm62bm4IWpZ0Dk0sjDIZSy9 oHcvfz4WPt64r667NLZax5FA9T1BxOuT+9XOtg5iFOQqsz1q35m6vSJvm98HbW1a4JRv+4Ywohb MSKadKFjFiaLLT6RxC7gsH/v/GK7CdfndtjVa9FRYRUWlv9YKxqnViEiHfB/tsnCpu5/WXv8TG5 rXjDeh/KuYEPLGKkiYwFNMIf3eO6IpKXogPpj8pCSWPRwVBtXIaLGz4AwzQR5+GyLeh6uqFlsJD If3BDvNA+rm+Bi11xuDiWxJCnKoD/haRIrv1G1SfjcWw== X-Received: by 2002:a05:7301:391c:b0:384:df31:69fd with SMTP id 5a478bee46e88-3856fb6a672mr9572437eec.14.1795317863249; Sat, 21 Nov 2026 19:24:23 -0800 (PST) Received: from kapoor.iiserb.ac.in ([203.18.51.239]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-385c6830815sm18931379eec.20.2026.11.21.19.24.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 21 Nov 2026 19:24:22 -0800 (PST) From: Arnav Kapoor To: Jonathan Cameron Cc: Mudit Sharma , Andy Shevchenko , Matti Vaittinen , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Arnav Kapoor Subject: [PATCH v4] iio: light: bh1745: fix 16-bit register accesses Date: Sun, 22 Nov 2026 08:54:13 +0530 Message-ID: <20261122032415.20042-1-kapoorarnav43@gmail.com> X-Mailer: git-send-email 2.53.0 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The 16-bit colour data and threshold registers are little-endian LSB/MSB pairs, but the driver accesses them through regmap_bulk_read() and regmap_bulk_write() with an int or u16 buffer and no byte-order conversion: - bh1745_read_raw() reads 2 bytes into an uninitialised int, so the upper 16 bits returned to user space are stack contents. - bh1745_read_thresh() reads 2 bytes straight into *val, which the IIO core leaves uninitialised, with the same result for the event threshold attributes. - bh1745_write_thresh() writes the first 2 bytes of an int, which are the upper (zero) bytes on big-endian. - bh1745_trigger_handler() pushes the raw register bytes, which are little-endian, to a buffer whose scan type is IIO_CPU, so user space gets the samples byte-swapped on big-endian. Use an __le16 for the sysfs paths and convert with le16_to_cpu() / cpu_to_le16(). For the buffer, read straight into the scan and mark the channels IIO_LE, leaving the conversion to user space as usual. Fixes: eab35358aae7 ("iio: light: ROHM BH1745 colour sensor") Reviewed-by: Andy Shevchenko Reviewed-by: Matti Vaittinen Signed-off-by: Arnav Kapoor --- Changes in v4: - Mark the channels IIO_LE and push the samples little-endian instead of converting them in the trigger handler (Jonathan) - Read straight into scan.chans[] (Jonathan) v3: https://lore.kernel.org/all/20261118104534.159876-1-kapoorarnav43@gmail.com/ v2: https://lore.kernel.org/all/20261117110327.198084-1-kapoorarnav43@gmail.com/ v1: https://lore.kernel.org/all/20261116194214.45174-1-kapoorarnav43@gmail.com/ Compile-tested only (W=1, checkpatch --strict clean); I don't have BH1745 hardware. drivers/iio/light/bh1745.c | 35 ++++++++++++++++++++++------------- 1 file changed, 22 insertions(+), 13 deletions(-) diff --git a/drivers/iio/light/bh1745.c b/drivers/iio/light/bh1745.c index 2b8ff36071b8..68baf5cc14b5 100644 --- a/drivers/iio/light/bh1745.c +++ b/drivers/iio/light/bh1745.c @@ -16,6 +16,9 @@ #include #include #include +#include + +#include #include #include @@ -210,7 +213,7 @@ static const struct iio_event_spec bh1745_event_spec[] = { .sign = 'u', \ .realbits = 16, \ .storagebits = 16, \ - .endianness = IIO_CPU, \ + .endianness = IIO_LE, \ }, \ } @@ -421,19 +424,20 @@ static int bh1745_read_raw(struct iio_dev *indio_dev, int *val, int *val2, long mask) { struct bh1745_data *data = iio_priv(indio_dev); + __le16 value; int ret; - int value; switch (mask) { case IIO_CHAN_INFO_RAW: if (!iio_device_claim_direct(indio_dev)) return -EBUSY; - ret = regmap_bulk_read(data->regmap, chan->address, &value, 2); + ret = regmap_bulk_read(data->regmap, chan->address, &value, + sizeof(value)); iio_device_release_direct(indio_dev); if (ret) return ret; - *val = value; + *val = le16_to_cpu(value); return IIO_VAL_INT; @@ -503,6 +507,7 @@ static int bh1745_read_thresh(struct iio_dev *indio_dev, enum iio_event_info info, int *val, int *val2) { struct bh1745_data *data = iio_priv(indio_dev); + __le16 value; int ret; switch (info) { @@ -510,18 +515,22 @@ static int bh1745_read_thresh(struct iio_dev *indio_dev, switch (dir) { case IIO_EV_DIR_RISING: ret = regmap_bulk_read(data->regmap, BH1745_TH_LSB, - val, 2); + &value, sizeof(value)); if (ret) return ret; + *val = le16_to_cpu(value); + return IIO_VAL_INT; case IIO_EV_DIR_FALLING: ret = regmap_bulk_read(data->regmap, BH1745_TL_LSB, - val, 2); + &value, sizeof(value)); if (ret) return ret; + *val = le16_to_cpu(value); + return IIO_VAL_INT; default: @@ -547,6 +556,7 @@ static int bh1745_write_thresh(struct iio_dev *indio_dev, enum iio_event_info info, int val, int val2) { struct bh1745_data *data = iio_priv(indio_dev); + __le16 value; int ret; switch (info) { @@ -554,10 +564,12 @@ static int bh1745_write_thresh(struct iio_dev *indio_dev, if (val < 0x0 || val > 0xFFFF) return -EINVAL; + value = cpu_to_le16(val); + switch (dir) { case IIO_EV_DIR_RISING: ret = regmap_bulk_write(data->regmap, BH1745_TH_LSB, - &val, 2); + &value, sizeof(value)); if (ret) return ret; @@ -565,7 +577,7 @@ static int bh1745_write_thresh(struct iio_dev *indio_dev, case IIO_EV_DIR_FALLING: ret = regmap_bulk_write(data->regmap, BH1745_TL_LSB, - &val, 2); + &value, sizeof(value)); if (ret) return ret; @@ -738,21 +750,18 @@ static irqreturn_t bh1745_trigger_handler(int interrupt, void *p) struct iio_dev *indio_dev = pf->indio_dev; struct bh1745_data *data = iio_priv(indio_dev); struct { - u16 chans[4]; + __le16 chans[4]; aligned_s64 timestamp; } scan = { }; - u16 value; int ret; int i; int j = 0; iio_for_each_active_channel(indio_dev, i) { ret = regmap_bulk_read(data->regmap, BH1745_RED_LSB + 2 * i, - &value, 2); + &scan.chans[j++], sizeof(scan.chans[0])); if (ret) goto err; - - scan.chans[j++] = value; } iio_push_to_buffers_with_ts(indio_dev, &scan, sizeof(scan), base-commit: 51b83d4cb0f5c1342868c7aa1edbf0c4867477aa -- 2.53.0