mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Hongliang Yang <hongliang.yang@cixtech.com>
To: krzk@kernel.org
Cc: vkoul@kernel.org, neil.armstrong@linaro.org, mani@kernel.org,
	robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
	p.zabel@pengutronix.de, Gary.Yang@cixtech.com,
	fugang.duan@cixtech.com, linux-phy@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, cix-kernel-upstream@cixtech.com,
	Hongliang Yang <hongliang.yang@cixtech.com>
Subject: Re: [PATCH v8 1/2] dt-bindings: phy: Add CIX Sky1 USB3 PHY
Date: Sun, 22 Nov 2026 11:36:00 +0800	[thread overview]
Message-ID: <20261122033600.25806-1-hongliang.yang@cixtech.com> (raw)
In-Reply-To: <20261121-friendly-slim-jackal-fecccb@quoll>

> Neither two clocks from clock controller are separate devices... that's
> really not the point. I don't get what exactly is here common between
> these two lanes, but you have several per-lane registers suggesting they
> might be independent.

The lanes are the two lanes of one PHY. The two controllers above it are
separate devices, each with its own PIPE interface:

                        Sky1 SoC
  +----------------------------------------------------------+
  | usb3_typea_drd_tcp                                       |
  |                                                          |
  |   +--------------------+     +--------------------+      |
  |   | usb3_typea_drd0    |     | usb3_typea_drd1    |      |
  |   |                    |     |                    |      |
  |   |   USB3 Ctrl        |     |   USB3 Ctrl        |      |
  |   |       | UTMI       |     |       | UTMI       |      |
  |   |       v            |     |       v            |      |
  |   |   USB2 PHY         |     |   USB2 PHY         |      |
  |   +-------+------------+     +-------+------------+      |
  |           | PIPE                     | PIPE              |
  |           v                          v                   |
  |   +------------------------------------------------+     |
  |   |              USB3 PHY, 2 lanes                 |     |
  |   |                                                |     |
  |   |  lane 0      common block          lane 1      |     |
  |   |  TX 0x4000   bias, calibration     TX 0x4200   |     |
  |   |  RX 0x8000   PLLs, at 0x0000       RX 0x8200   |     |
  |   +------------------------------------------------+     |
  |                                                          |
  |   one register range, one APB clock, one reference       |
  |   clock, one reset pair for the whole block              |
  +----------------------------------------------------------+

The per-lane registers are the two PMA windows; the bias, the calibration
and the PLLs they use are in the common block, and there is one reset pair
and one reference clock for both lanes. The SoC has no per-lane clock,
reset or power control, so the lanes cannot be brought up or down
separately, and the driver programs both of them in one sequence.

If the lanes should still be separate providers in devicetree, they can be
described as two phys of one node with a lane index; there is no per-lane
resource to give them separate nodes.

  reply	other threads:[~2026-11-22  3:36 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17  2:28 [PATCH v8 0/2] phy: Add CIX Sky1 USB3 PHY support Hongliang Yang
2026-11-17  2:28 ` [PATCH v8 1/2] dt-bindings: phy: Add CIX Sky1 USB3 PHY Hongliang Yang
2026-11-21  9:21   ` Krzysztof Kozlowski
2026-11-22  3:36     ` Hongliang Yang [this message]
2026-11-22  3:40       ` Hongliang Yang
2026-11-17  2:28 ` [PATCH v8 2/2] phy: cix: Add CIX Sky1 USB3 PHY driver Hongliang Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261122033600.25806-1-hongliang.yang@cixtech.com \
    --to=hongliang.yang@cixtech.com \
    --cc=Gary.Yang@cixtech.com \
    --cc=cix-kernel-upstream@cixtech.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=fugang.duan@cixtech.com \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=mani@kernel.org \
    --cc=neil.armstrong@linaro.org \
    --cc=p.zabel@pengutronix.de \
    --cc=robh@kernel.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®