From: Ian Rogers <irogers@google.com>
To: "Alex Deucher" <alexander.deucher@amd.com>,
"Christian König" <christian.koenig@amd.com>,
"David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>
Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org, llvm@lists.linux.dev,
Elkin Cruz <elkin@google.com>, Ian Rogers <irogers@google.com>
Subject: [PATCH v2 0/2] drm/amdgpu: Initialize r in VM and TTM buffer helpers
Date: Sat, 21 Nov 2026 20:53:15 -0800 [thread overview]
Message-ID: <20261122045319.18651-1-irogers@google.com> (raw)
Two fixes in drm/amdgpu for uninitialized return-value regressions
found via Clang -Wconditional-uninitialized on an x86_64
allyesconfig build:
1. Set r = 0 in the 'else if (!bo)' branch of amdgpu_vm_bo_update().
2. Set r = 0 right after the while loop before 'error:' in
amdgpu_ttm_clear_buffer().
Build-tested with LLVM=1 W=1 (-Werror) and -Wconditional-uninitialized;
not runtime-tested on AMDGPU hardware.
v2:
- Keep 'int r;' uninitialized at declaration in both functions so
future missing-assignment paths are not masked; instead set 'r = 0;'
inside 'else if (!bo)' in patch 1/2 and directly before 'error:' in
patch 2/2 (Christian König).
v1: https://lore.kernel.org/r/cover.1795106955.git.irogers@google.com
Ian Rogers (2):
drm/amdgpu: initialize r in amdgpu_vm_bo_update()
drm/amdgpu: initialize r in amdgpu_ttm_clear_buffer()
drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 2 ++
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 1 +
2 files changed, 3 insertions(+)
--
2.56.1.750.gf70dc682cf-goog
next reply other threads:[~2026-11-22 4:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-22 4:53 Ian Rogers [this message]
2026-11-22 4:53 ` [PATCH v2 1/2] drm/amdgpu: initialize r in amdgpu_vm_bo_update() Ian Rogers
2026-11-22 4:53 ` [PATCH v2 2/2] drm/amdgpu: initialize r in amdgpu_ttm_clear_buffer() Ian Rogers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261122045319.18651-1-irogers@google.com \
--to=irogers@google.com \
--cc=airlied@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=elkin@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=simona@ffwll.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®