From: "Ömer Mete Kaya" <omermetekaya0@gmail.com>
To: gregkh@linuxfoundation.org, rafael@kernel.org, dakr@kernel.org
Cc: akpm@linux-foundation.org, edumazet@google.com,
brauner@kernel.org, driver-core@lists.linux.dev,
linux-kernel@vger.kernel.org,
"Ömer Mete Kaya" <omermetekaya0@gmail.com>
Subject: [PATCH] kobject: fix use-after-free in tagged uevent broadcast
Date: Sun, 22 Nov 2026 09:17:46 +0300 [thread overview]
Message-ID: <20261122061751.178540-1-omermetekaya0@gmail.com> (raw)
kobject_uevent_net_broadcast() accesses net->uevent_sock->sk without
protection in the tagged (namespace-aware) path. During network namespace
teardown, uevent_net_exit() frees the uevent_sock while a concurrent
kobject_uevent_env() call can still reference it, causing a
use-after-free.
Extend uevent_sock_mutex to cover the tagged broadcast path and the
netlink receive path, serializing them with teardown: in
uevent_net_exit(), set net->uevent_sock to NULL under the mutex before
releasing the socket. In the tagged broadcast path and in
uevent_net_rcv_skb(), check for NULL under the same mutex before
accessing the socket.
Discovered by Sashiko, not triggered, not runtime tested.
Fixes: 5c0941c55e5f ("kobject: reduce uevent_sock_mutex scope")
Signed-off-by: Ömer Mete Kaya <omermetekaya0@gmail.com>
---
lib/kobject_uevent.c | 30 ++++++++++++++++++++++--------
1 file changed, 22 insertions(+), 8 deletions(-)
diff --git a/lib/kobject_uevent.c b/lib/kobject_uevent.c
index ddbc4d7482d2..fd61307c045e 100644
--- a/lib/kobject_uevent.c
+++ b/lib/kobject_uevent.c
@@ -411,9 +411,15 @@ static int kobject_uevent_net_broadcast(struct kobject *kobj,
devpath);
else {
const struct net *net = container_of(ns, struct net, ns);
+ struct uevent_sock *ue_sk;
- ret = uevent_net_broadcast_tagged(net->uevent_sock->sk, env,
- action_string, devpath);
+ mutex_lock(&uevent_sock_mutex);
+ ue_sk = net->uevent_sock;
+ if (ue_sk)
+ ret = uevent_net_broadcast_tagged(ue_sk->sk, env,
+ action_string,
+ devpath);
+ mutex_unlock(&uevent_sock_mutex);
}
#endif
@@ -743,6 +749,7 @@ static int uevent_net_broadcast(struct sock *usk, struct sk_buff *skb,
static int uevent_net_rcv_skb(struct sk_buff *skb, struct nlmsghdr *nlh,
struct netlink_ext_ack *extack)
{
+ struct uevent_sock *ue_sk;
struct net *net;
int ret;
@@ -760,7 +767,13 @@ static int uevent_net_rcv_skb(struct sk_buff *skb, struct nlmsghdr *nlh,
return -EPERM;
}
- ret = uevent_net_broadcast(net->uevent_sock->sk, skb, extack);
+ mutex_lock(&uevent_sock_mutex);
+ ue_sk = net->uevent_sock;
+ if (ue_sk)
+ ret = uevent_net_broadcast(ue_sk->sk, skb, extack);
+ else
+ ret = -ENODEV;
+ mutex_unlock(&uevent_sock_mutex);
return ret;
}
@@ -804,13 +817,14 @@ static int uevent_net_init(struct net *net)
static void uevent_net_exit(struct net *net)
{
- struct uevent_sock *ue_sk = net->uevent_sock;
+ struct uevent_sock *ue_sk;
- if (sock_net(ue_sk->sk)->user_ns == &init_user_ns) {
- mutex_lock(&uevent_sock_mutex);
+ mutex_lock(&uevent_sock_mutex);
+ ue_sk = net->uevent_sock;
+ net->uevent_sock = NULL;
+ if (sock_net(ue_sk->sk)->user_ns == &init_user_ns)
list_del(&ue_sk->list);
- mutex_unlock(&uevent_sock_mutex);
- }
+ mutex_unlock(&uevent_sock_mutex);
netlink_kernel_release(ue_sk->sk);
kfree(ue_sk);
--
2.56.0
reply other threads:[~2026-11-22 6:18 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261122061751.178540-1-omermetekaya0@gmail.com \
--to=omermetekaya0@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=brauner@kernel.org \
--cc=dakr@kernel.org \
--cc=driver-core@lists.linux.dev \
--cc=edumazet@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®