From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.208.41 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795334914; b=ghChY3V1jd2KjrmL+/Kpw/jwQ15/2z9hXATrptcKzfJqzekzNRvg+fuxp6U0OO8Ui/Z0 9m1fmREJnsADu4hiDHz/arouwgbt0hE235WpuVW/X79U+lI+gLLQqzs+Z6YQzuMksHgWs 67XU5KED7kn6o7BC/FLCEDamsjLLUNsDID7NSfmnw4Zx4+BBrQr8iRZUJrG5TUMzOVUtI 4QHF/0iXzOsv+ej83MAGX8mRBfkwcXbeuc/bz6aR1eEfYV6/FCuwByLxc/0pXD2wjV6e1 cJlkBZ13DiHldu3g43zFEtJCahQz1TfXDfKVzN17LevaQfHoSHBAwQHiMOPmeX9XVQw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795334914; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: From:To:Cc:Subject:Date:Message-ID:X-Mailer:In-Reply-To:References: MIME-Version:Content-Transfer-Encoding; bh=WxmR7ztyeDAM8l4U5mjs6dhsdQ8TeTXXL+OwtJ6NUO8=; b=5QsIRuySwDYO5vk344w/Z1eEleQdT8MnDSOKq6u/GeD6pHALmdKfLKAvqnEKyO/+7s8K YwysbigdmTmXpgGpTy1vNr2ckdGBPaQm8FHPLBIEKE/spx3ttXbf30FSDUnwHLS+mzbLB t2qcPkP+G6c4Ur5R9WHCnSUOp/SMlFNYFOS4Zg/9T3847tYvY/4N45saDX4zuPg1dAX0d oe6dFIbXeXengsIvq9DqJ7YxHS188Fz04TqAIwKzYs4lje07jaxoDa0bQriaJ57evL4Qy WgcjIw4fj0CaQgPcFxdj11IM7Xf7yYfQHbXHqod6Q51fLEbr4t/35EparreMptK+bGQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=CtdtwJ1P; arc=none smtp.remote-ip=209.85.208.41 Received: from mail-ed1-f41.google.com (mail-ed1-f41.google.com [209.85.208.41]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6C3D0606A320 for ; Sun, 22 Nov 2026 08:08:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 6C3D0606A320 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=CtdtwJ1P Received: by mail-ed1-f41.google.com with SMTP id 4fb4d7f45d1cf-6baa6f27904so98261a12.0 for ; Sun, 22 Nov 2026 00:08:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1795334913; x=1795939713; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=WxmR7ztyeDAM8l4U5mjs6dhsdQ8TeTXXL+OwtJ6NUO8=; b=CtdtwJ1Pb+/xE47wHtFE7BGKSoTPX0717TTaBptkIDetzjeX1GFUXZyaq61Z7h04GS SyUvknLFVGLAIVQ2pY9JX3EETkbObFND4Z9h2mtAa6Cu77auBPBuzBUWE9UmWPIy/E6C U8ECdkhV9s7qN3lbARlKs3GwveahqbCh1ZFZh/t2vojhZ/oOK8qK2wr1/imyRwA/vAmk Jr6nEDejOcyWi9H4/4+6r1zy5jlmNwva8y202M02F/T2RqUfsvvH2jc21zbFsoUdybq6 QwRe31VOZ3rGo1SYoh2qtZxaHl+IyArWJC9CU1TQME+FN1jGCB32+FHSl7BNIXqqLLdD +Ulw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1795334913; x=1795939713; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=WxmR7ztyeDAM8l4U5mjs6dhsdQ8TeTXXL+OwtJ6NUO8=; b=xhiq5q7z5iIAFW525SwzBo+AuIlfCiY/pYBMpEKtkm3u1Jy5hMR0zIFzeld4sBEsuu 389KrUnhX7i7fvuRXc1A/jI7oJCJ8h1QLmYF7Snwi82Jv/JhKQAxIlYitLQ5FHHx/k0v +Z78QKhKp0S0iiS6b7BDiJrQv/Dtfx0riptYBPgN7J6343Nf0QQnirXCEy4R2ekvkdCW yDo6/w+TPPzTIg8qgX73V6jQvxtvEvTrsopCEFtlQ2PxlU2+4z+flPlr7I6hlst15Tv7 kIcwau8deBTOKvzcb8iT+wkd3pkoy3D8iE8MDrOLwRc26U92xg+tNlJLv8Q6YflY5RlF csPw== X-Forwarded-Encrypted: i=1; AL+hErH59MMrbc+08JYmOV6Jaoo8KhG7mNUguevvS3g7ip8+yKyt6DJX7kOSyeLVzB7xuJ/HT22gDW/KFK6Tqus=@vger.kernel.org X-Gm-Message-State: APuU4Z8w3+zI3TKSOXPD9akK2D58ysqMnn5gvWHEF5NjRqQPArw+ykDx 48ebIBXvQFZ3KKyiBwemIWOJ6KBKPh5LkkZVUGJG014kTuIXQrtkNQtq X-Gm-Gg: AZFdTZe13Pba+3lFQfV0PzTMpNvxTPv1JyO+UViHED0+1iNpcrdJrXTOy14cM4eo5jL OFrxeQt5iVWF4DJyuvJ/yZ1lOml1xDpuTz2WnpOiua6zr3zDs9TZ+DdGTebzqFpHHO+PO0+1SAk gvxr2HlB43FTyHpOp1KM40rKi6/KPjHVFVXuq5JNphccmEmhxxLy4/4U4lvdX9L4MC2jA20nK48 9mDPlLkqY4phNxYBzNwbyksEHPzSMTrd5Ss7rG4C5V4HirwrejhD0bdOYIQ+Hin634rNHM4wOm7 mNu8f6vPOXJbLAtM8Fm2M4mFo3F90uMP+DOYLbqnNG7N0qPCmdb4SOkRXJqm0N2WAaYC5wt48v9 UjcC4EvTerBEh07PvEjO1vyv73CXZ2N5kEHuR4RXvSGlHA4ezSmBMoxsbO+PxfTetA2Xk+XKdbu g0nHMK74V5Bzwqw5+L/fpIP92nz7hK+WgfAV929fkAnpLGu62qwCByCGSTCx1mzMEZExOxH+p2/ JMOtkP6etAQeuJ2RoYmgMIzWmAlNDaf3s2yNgla8cQfj7GGyMfy80J8edb+IVqzOt50f4PojpZn w/juqGMIIwE//jwFzEz73RZ8UsWE+p50FR02DY2tLpx22DiLxzu4KkYRAijf4DOYh2SPtwrUUWk ACibkEcxKwA== X-Received: by 2002:a05:6402:1e90:b0:6b5:7d7b:8e9b with SMTP id 4fb4d7f45d1cf-6ba37ebe4dbmr6234640a12.39.1795334912857; Sun, 22 Nov 2026 00:08:32 -0800 (PST) Received: from xeon ([188.163.112.62]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6ba3710601esm3596014a12.27.2026.11.22.00.08.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 22 Nov 2026 00:08:31 -0800 (PST) From: Svyatoslav Ryhel To: Jonathan Cameron , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Esben Haabendal , Kuppuswamy Sathyanarayanan , Svyatoslav Ryhel , =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig=20=28The=20Capable=20Hub=29?= , Pan Chuang , Hemanth Selam , Antoniu Miclaus , Nikita Travkin Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v5 4/4] iio: light: ltr501: Add support for the LTR-659PS-01 proximity sensor Date: Sun, 22 Nov 2026 10:07:53 +0200 Message-ID: <20261122080753.36349-5-clamor95@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20261122080753.36349-1-clamor95@gmail.com> References: <20261122080753.36349-1-clamor95@gmail.com> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add support for the Lite-On LTR-659PS-01 proximity sensor. This device is nearly identical to the LTR-559ALS-01, but omits all elements related to ambient light sensing. Add a no_als_support flag, similar to how no_irq_support is used, to isolate ALS register access for the LTR-659PS-01, since ALS registers are marked as reserved and interactions with them are discouraged. The ltr501_trigger_handler relied on the scan index to identify channels. This approach is fragile regarding channel status flags and can break if the index is not strictly set. Switch to checking the channel type instead. Signed-off-by: Svyatoslav Ryhel --- drivers/iio/light/ltr501.c | 76 ++++++++++++++++++++++++++++++-------- 1 file changed, 61 insertions(+), 15 deletions(-) diff --git a/drivers/iio/light/ltr501.c b/drivers/iio/light/ltr501.c index a471c90cf0a75..37682e7067b52 100644 --- a/drivers/iio/light/ltr501.c +++ b/drivers/iio/light/ltr501.c @@ -151,6 +151,7 @@ struct ltr501_chip_info { u8 als_gain_mask; u8 als_gain_shift; bool no_irq_support; + bool no_als_support; struct iio_chan_spec const *channels; const int no_channels; }; @@ -656,6 +657,29 @@ static const struct iio_chan_spec ltr301_channels[] = { IIO_CHAN_SOFT_TIMESTAMP(2), }; +static const struct iio_chan_spec ltr659_channels[] = { + { + .type = IIO_PROXIMITY, + .address = LTR501_PS_DATA, + .info_mask_separate = BIT(IIO_CHAN_INFO_RAW) | + BIT(IIO_CHAN_INFO_SCALE), + .info_mask_shared_by_all = BIT(IIO_CHAN_INFO_SAMP_FREQ), + .info_mask_separate_available = BIT(IIO_CHAN_INFO_SCALE), + .info_mask_shared_by_all_available = BIT(IIO_CHAN_INFO_SAMP_FREQ), + .scan_index = 0, + .scan_type = { + .sign = 'u', + .realbits = 11, + .storagebits = 16, + .endianness = IIO_CPU, + }, + .event_spec = ltr501_pxs_event_spec, + .num_event_specs = ARRAY_SIZE(ltr501_pxs_event_spec), + .ext_info = ltr501_ext_info, + }, + IIO_CHAN_SOFT_TIMESTAMP(1), +}; + static int ltr501_read_info_raw(struct ltr501_data *data, struct iio_chan_spec const *chan, int *val) @@ -1230,13 +1254,24 @@ static const struct ltr501_chip_info ltr559_chip_info_tbl = { .no_channels = ARRAY_SIZE(ltr501_channels), }; +static const struct ltr501_chip_info ltr659_chip_info_tbl = { + .partid = 0x09, + .ps_gain = ltr559_ps_gain_tbl, + .ps_gain_tbl_size = ARRAY_SIZE(ltr559_ps_gain_tbl), + .no_als_support = true, + .channels = ltr659_channels, + .no_channels = ARRAY_SIZE(ltr659_channels), +}; + static int ltr501_write_contr(struct ltr501_data *data, u8 als_val, u8 ps_val) { int ret; - ret = regmap_write(data->regmap, LTR501_ALS_CONTR, als_val); - if (ret < 0) - return ret; + if (!data->chip_info->no_als_support) { + ret = regmap_write(data->regmap, LTR501_ALS_CONTR, als_val); + if (ret < 0) + return ret; + } return regmap_write(data->regmap, LTR501_PS_CONTR, ps_val); } @@ -1251,16 +1286,21 @@ static irqreturn_t ltr501_trigger_handler(int irq, void *p) aligned_s64 ts; } scan = { }; __le16 als_buf[2]; + unsigned int si; u8 mask = 0; int j = 0; int ret, psdata; /* figure out which data needs to be ready */ - if (test_bit(0, indio_dev->active_scan_mask) || - test_bit(1, indio_dev->active_scan_mask)) - mask |= LTR501_STATUS_ALS_RDY; - if (test_bit(2, indio_dev->active_scan_mask)) - mask |= LTR501_STATUS_PS_RDY; + iio_for_each_active_channel(indio_dev, si) { + const struct iio_chan_spec *chan = iio_find_channel_from_si(indio_dev, si); + + if (chan->type == IIO_INTENSITY) + mask |= LTR501_STATUS_ALS_RDY; + + if (chan->type == IIO_PROXIMITY) + mask |= LTR501_STATUS_PS_RDY; + } ret = ltr501_drdy(data, mask); if (ret < 0) @@ -1328,11 +1368,13 @@ static int ltr501_init(struct ltr501_data *data) { int ret, status; - ret = regmap_read(data->regmap, LTR501_ALS_CONTR, &status); - if (ret < 0) - return ret; + if (!data->chip_info->no_als_support) { + ret = regmap_read(data->regmap, LTR501_ALS_CONTR, &status); + if (ret < 0) + return ret; - data->als_contr = status | data->chip_info->als_mode_active; + data->als_contr = status | data->chip_info->als_mode_active; + } ret = regmap_read(data->regmap, LTR501_PS_CONTR, &status); if (ret < 0) @@ -1341,9 +1383,11 @@ static int ltr501_init(struct ltr501_data *data) data->ps_contr = status | LTR501_CONTR_ACTIVE; if (ltr501_has_irq_support(data->chip_info)) { - ret = ltr501_read_intr_prst(data, IIO_INTENSITY, &data->als_period); - if (ret < 0) - return ret; + if (!data->chip_info->no_als_support) { + ret = ltr501_read_intr_prst(data, IIO_INTENSITY, &data->als_period); + if (ret < 0) + return ret; + } ret = ltr501_read_intr_prst(data, IIO_PROXIMITY, &data->ps_period); if (ret < 0) @@ -1582,6 +1626,7 @@ static const struct i2c_device_id ltr501_id[] = { { .name = "ltr329", .driver_data = (kernel_ulong_t)<r329_chip_info_tbl }, { .name = "ltr501", .driver_data = (kernel_ulong_t)<r501_chip_info_tbl }, { .name = "ltr559", .driver_data = (kernel_ulong_t)<r559_chip_info_tbl }, + { .name = "ltr659", .driver_data = (kernel_ulong_t)<r659_chip_info_tbl }, { } }; MODULE_DEVICE_TABLE(i2c, ltr501_id); @@ -1592,6 +1637,7 @@ static const struct of_device_id ltr501_of_match[] = { { .compatible = "liteon,ltr329", .data = <r329_chip_info_tbl }, { .compatible = "liteon,ltr501", .data = <r501_chip_info_tbl }, { .compatible = "liteon,ltr559", .data = <r559_chip_info_tbl }, + { .compatible = "liteon,ltr659", .data = <r659_chip_info_tbl }, { } }; MODULE_DEVICE_TABLE(of, ltr501_of_match); -- 2.53.0