From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.208.49 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795335552; b=jJmphbVDP6MDWRgMmK1CC8DFxRr5OzKdcBHa2Mas+nbk+5eJMugw0wRxYW4kb1glQ9/F PTbZ67Y4Y9K3thDsQZJCliYrEywKwHHaTso1wdw7nqNGAhNGSManL6FU57x7MbLl6WZYk u4UV+Vlq4Vij3i5Wf3eYSFeLNKHt/7haQRJ5jJtaTTxeF1nGk8Rb3j8rv0LFKTtnL/wmP /m2ofl6J+ZmmJIP5OmlFchnTDdnN4LgGhVKecQvOctQmINdTraTFdnnJ7/KeZNhd5mXmP jaN6ZOokanmRu8Gg9+mMhH4YG3NIsaoc+3Tjh6XfeSeiizIS6D020hcriaQdQ7pguOg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795335552; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: From:To:Cc:Subject:Date:Message-ID:X-Mailer:In-Reply-To:References: MIME-Version:Content-Transfer-Encoding; bh=3z6P0aYlufuvnlooWGHkbmG4E1HPBYeLov8HTyHzM/I=; b=EWRUJDJBFXOWfIkT/08fRn1jcbYtYhm2a1mYN8y06P8RPYX5OySNy12hWLlxi1kYO0my M6JMM7vAz9GXVEjm2RvSPZ8jgXD5ISfA4HcPH8QEwKwqMWSOD/vSkQLTNHevbcXYGkAG/ A3hJqMzfWBaijrlqSoLE+iLrACg+9mDMaJdwm2lqxEgrMQIBFy9x8saUO+Jquxqs5bDiE HtVDiBxgFUOhz0Tzapcy8rMX4xX5XDOX1os5RYtgI9ZdbXrZ3scWy6TFcceh9dPIvYe/H V3cof/CiQRmD0BzOC0aPURcsJcqP/YO3SY4l8QxRs2iiMlMqD/iXG06oAVHMkKDUbWQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=nXgq32eS; arc=none smtp.remote-ip=209.85.208.49 Received: from mail-ed1-f49.google.com (mail-ed1-f49.google.com [209.85.208.49]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8D06A606A33B for ; Sun, 22 Nov 2026 08:19:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 8D06A606A33B Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=nXgq32eS Received: by mail-ed1-f49.google.com with SMTP id 4fb4d7f45d1cf-6baa6f27904so102495a12.0 for ; Sun, 22 Nov 2026 00:19:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1795335550; x=1795940350; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=3z6P0aYlufuvnlooWGHkbmG4E1HPBYeLov8HTyHzM/I=; b=nXgq32eSWi/S38LFKr3ad4V0ae7GGVX/f4p0sB3WrHLVWONLqYnLLe4BwtYRv8m/2i DgTDUpvyrV39rrSYpz/zMuM86bLcEmIsxS7kvYWIV6TSbb9lunXQsmqJxlrm3ZJLoy3W +xAQF7H/boKtDm86cjj6NnZHewJ4CLYZi7lUrNFKJNVbKZfODKoo+fZW5RX0E0DWDvRL FmAnxiepSoB/P+Wx7YplAAjc0lPY6RZMBkH/q2PZ16rw3ysHQLy7GG0LJzJcZ7KzEk6n 4HzazObs1IgnQovd+jb3yoT2QXzwbRV79kPABU4WZtIb6sS1hJJ8vRFL6n7FnBLQoui+ Q16Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1795335550; x=1795940350; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=3z6P0aYlufuvnlooWGHkbmG4E1HPBYeLov8HTyHzM/I=; b=ysRuA15dGpimo64V3eGZuWCF+Eqg85kTR9LH0Tg/HSDEWnk+spmesYF6lCel8Tf1VC Ct85oy9qzS7lkGAu5LeXt69vYvJRmNV7RsZuX7jR15q1B1iqYH/MK0scX90zo8R7FGT6 7NfgMveSKs2KPgNxpp7d82KhIxQtUQQZtodty+EKSSdhPV3v4AfPvjoeN3qx0DrXXi1r RbFJ/kQEmEyClUq5UkH6tfIpzgkRQzVFdWVYy8uhlJ0FIuZEWhwkbrZU7h3w+NAw5UTg DPS+skX0At2WyNNeQPTmYL3Wj3jkeQ44eKJhlwMh7/YdsUW3mAVmTdaFXMdFoIIVYhde 66fA== X-Forwarded-Encrypted: i=1; AL+hErHsRyG3/3ySIkvPn9Zsz+uBccuzxbIBPfJ7v7rBk5PHSs+JKnpj2N4fBPWI+AHhqu7iuvcxgJk/qfVQT/w=@vger.kernel.org X-Gm-Message-State: APuU4Z+sHsEhrMlaruS0W3V9EQrBwDYMf8MyY7wMxwtEUKufTwzBF/YH KKrMHxHTmrMU+7RKkYgj4If8gLA+Dj+Vujxj2O6XeHh1EvQtdqPOpgHu X-Gm-Gg: AZFdTZfrgEs7L3n9VUW3Mv2EBbCZhVWEnyq19s+9FsYxDL6wVr5PyXC625FsMPB3Hl6 7dlxFIagWc/BtMadgZ2cMDgH59gKpyNsFH0KeTVThvNq0i+JGH/rj2aAOYyhLcwFkfJV2NM1D/d My0/ZEFR95Ph9EnFbwFqjLl7pXOxR4Rd15YUtHfJrfAjn68JmzffB9QXnr+VgIpOib76TBfO4Sk 3iks5IYL+PWF4BLv1Ht3hZoFYAzU0Kk6S/FNuYYAtPRqTz4WKanIIQ05VnLdgX5oB1jMTeUV12i JaFtQaJkwu2HfYvZ4PVl1IUflivRlVJLmKSo/zxU0wiVo50mLG32Y8M10uj2RQcckMSivlhoSaN PuSYam1YZRyr/FM/+LSfnlZHGlqyHotMGJ8wW0rxzxHabBcC4bEs/FZbcxG2+Qn0N4fo0TtxcYL c3vkSlNQ0rn/njhduP+XJNYiJWlebO0TBl4EJLR6P55F5Ycn6k1SPocgVFgSX8nxXHf+0js+Ltr qC1wY9Z0c7xJDLSVCAW8N4R0lRVUbiIFmEkpVXDr4xJsE2whJ/yHE8gMaiBH0CZr3NzvNGdu/Do kV/DQ0xqQs+t7kHMXp8sd8+xclcpoZCGe+KcLRkGSzixAOzgWjjQi0jnk8FDzVQ37t4gR0mburq GjjjQOHsPvA== X-Received: by 2002:a05:6402:274d:b0:6ba:92c3:fef7 with SMTP id 4fb4d7f45d1cf-6ba92c4088cmr876330a12.19.1795335550008; Sun, 22 Nov 2026 00:19:10 -0800 (PST) Received: from xeon ([188.163.112.62]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6ba370e8ad0sm3617167a12.18.2026.11.22.00.19.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 22 Nov 2026 00:19:08 -0800 (PST) From: Svyatoslav Ryhel To: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Thierry Reding , Jonathan Hunter , Neil Armstrong , Jessica Zhang , Mikko Perttunen , Svyatoslav Ryhel Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v8 10/12] drm/tegra: rgb: Parameterize configuration based on bus flags Date: Sun, 22 Nov 2026 10:18:18 +0200 Message-ID: <20261122081820.53199-11-clamor95@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20261122081820.53199-1-clamor95@gmail.com> References: <20261122081820.53199-1-clamor95@gmail.com> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Parameterize configuration based on bus flags passed from the bridge or panel. The list of supported flags includes now pixel clock polarity, display enable (DE) polarity, and data alignment. Signed-off-by: Svyatoslav Ryhel --- drivers/gpu/drm/tegra/rgb.c | 39 +++++++++++++++++++++++++++++++++---- 1 file changed, 35 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/tegra/rgb.c b/drivers/gpu/drm/tegra/rgb.c index d48d498068ac8..faecd6f94359f 100644 --- a/drivers/gpu/drm/tegra/rgb.c +++ b/drivers/gpu/drm/tegra/rgb.c @@ -5,6 +5,7 @@ */ #include +#include #include #include @@ -106,6 +107,7 @@ static void tegra_rgb_encoder_enable(struct drm_encoder *encoder, struct tegra_output *output = encoder_to_output(encoder); struct tegra_rgb *rgb = to_rgb(output); struct drm_connector_state *conn_state; + struct drm_bridge_state *bridge_state; struct drm_crtc_state *crtc_state; struct drm_connector *connector; struct drm_display_mode *mode; @@ -117,12 +119,21 @@ static void tegra_rgb_encoder_enable(struct drm_encoder *encoder, crtc_state = drm_atomic_get_new_crtc_state(state, conn_state->crtc); mode = &crtc_state->adjusted_mode; + /* Get but flags from the bridge state. */ + bridge_state = drm_atomic_get_new_bridge_state(state, output->bridge); + if (bridge_state) + bus_flags = bridge_state->input_bus_cfg.flags; + else + bus_flags = DRM_BUS_FLAG_PIXDATA_SAMPLE_NEGEDGE | + DRM_BUS_FLAG_DE_HIGH | + DRM_BUS_FLAG_DATA_MSB_TO_LSB; + tegra_dc_write_regs(rgb->dc, rgb_enable, ARRAY_SIZE(rgb_enable)); value = DE_SELECT_ACTIVE | DE_CONTROL_NORMAL; tegra_dc_writel(rgb->dc, value, DC_DISP_DATA_ENABLE_OPTIONS); - /* configure H- and V-sync signal polarities */ + /* configure H- and V-sync and pixel clock signal polarities */ value = tegra_dc_readl(rgb->dc, DC_COM_PIN_OUTPUT_POLARITY(1)); if (mode->flags & DRM_MODE_FLAG_NHSYNC) @@ -135,11 +146,31 @@ static void tegra_rgb_encoder_enable(struct drm_encoder *encoder, else value &= ~LVS_OUTPUT_POLARITY_LOW; + if (bus_flags & DRM_BUS_FLAG_PIXDATA_SAMPLE_POSEDGE) + value &= ~BIT(PIN_LSC0); + else + value |= BIT(PIN_LSC0); + tegra_dc_writel(rgb->dc, value, DC_COM_PIN_OUTPUT_POLARITY(1)); - /* XXX: parameterize? */ - value = DISP_DATA_FORMAT_DF1P1C | DISP_ALIGNMENT_MSB | - DISP_ORDER_RED_BLUE; + /* configure DE signal polarities */ + value = tegra_dc_readl(rgb->dc, DC_COM_PIN_OUTPUT_POLARITY(3)); + + if (bus_flags & DRM_BUS_FLAG_DE_LOW) + value |= BIT(PIN_LSPI); + else + value &= ~BIT(PIN_LSPI); + + tegra_dc_writel(rgb->dc, value, DC_COM_PIN_OUTPUT_POLARITY(3)); + + /* configure DATA order and alignment */ + value = DISP_DATA_FORMAT_DF1P1C | DISP_ORDER_RED_BLUE; + + if (bus_flags & DRM_BUS_FLAG_DATA_LSB_TO_MSB) + value |= DISP_ALIGNMENT_LSB; + else + value &= ~DISP_ALIGNMENT_LSB; + tegra_dc_writel(rgb->dc, value, DC_DISP_DISP_INTERFACE_CONTROL); tegra_dc_commit(rgb->dc); -- 2.53.0