From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.208.47 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795335545; b=abRLWzbgzDcBQ69NfDiKaAzr2+YWxJJLEboJQYDc8UKe7UxHEA20ymvlLdZ09yZcOZup zmLZ/kZPkNpu5Xe1BpDxjHmhg3T1K3o1+SGKo0pL2t2LeQun52H18FXsBPmDLBSz5M7Ng Je7c5UeoXMxCarxCQPipeSbJqB9enqkLVGh87z/oT3IVl9gw8k2b3crVvp7RxJ4VHzGIk vMVj8zOAn+LY1QDC4ch2YFbMJr26gRfR1HjIS/YMnLn1NUt2EWjRzTRYNPlZcswZkDl0s ZfXVJIi+wLjanzB78QPWCnQkpOv3BQrbUBtidYDSpfT7rWQ4OLMCrJWzMmU0vpVh6ng== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795335545; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: From:To:Cc:Subject:Date:Message-ID:X-Mailer:In-Reply-To:References: MIME-Version:Content-Transfer-Encoding; bh=raX6dCAIomOIJ7ELRGbL6/J7HJwcKSM4UvEKLE/Febc=; b=dG7auzTwPWrLs8TcZlNM4jNASPiKYdcEXhtFCCNhGH4Qp5Bv2YQZkVzLtP/xGVAzXIqd sCb1IiPm/NjfdT6do2YZvkeMatAyLin2ccrwCczeY4Q8C/Ny7aFgWy6okASkfL7wblhlC wQqj4wiFLNX25kK6fQTux2yXXv7WGJjYqZm2QK6zuDO8RhNOVasVV5qqELAtNQC/gt74J y+uQnOf+2D+BnLu1HzWyz9L6Lyx+ICRlsujIL4TFfgK7jlj2YTuaB8O+mdYA+EIzrX58i 6HdklVN4oszl4/pf+Ez8kOooIt4bajW0RxD5igflHrkcfw+vdz4wBxCG1X3wxha7N2g== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=LvBo5S7y; arc=none smtp.remote-ip=209.85.208.47 Received: from mail-ed1-f47.google.com (mail-ed1-f47.google.com [209.85.208.47]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 515C8606A32C for ; Sun, 22 Nov 2026 08:19:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 515C8606A32C Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=LvBo5S7y Received: by mail-ed1-f47.google.com with SMTP id 4fb4d7f45d1cf-6b167ffd132so3459354a12.1 for ; Sun, 22 Nov 2026 00:19:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1795335544; x=1795940344; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=raX6dCAIomOIJ7ELRGbL6/J7HJwcKSM4UvEKLE/Febc=; b=LvBo5S7yvr0z7KdgzrGRmCXs33lPM1QkxpmPhP2ZLyKNJU7Q/ynRbp/RIAU6gfelwc rS1F4qlfTc1bxfwZM+rEYhu8EOwmNa8T81NAeZC9eUs7B6J5VgmDto0pLM2kocFwcTs9 Cc5TAnXMWdPMRuCiI2bBJxsZbBRUu+ilA4vm74i94CUjvCPwKOxHkg+Z2JJ30ymzrBVH IAUehypO41YGi31S2P5jnJ/4XJD9MILbY53k6UEuiuQbmCoeJbS+E8wv5CmWlCuMI1uA 9A96EFliEBU8KBWtjwcMkilAQYJffUTUvJ9/pSRCKLxpt5ReRi0N7fdA77b1epcNm1NV JqTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1795335544; x=1795940344; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=raX6dCAIomOIJ7ELRGbL6/J7HJwcKSM4UvEKLE/Febc=; b=rdjFDihR5fzA5NSQEL1H5tgliGkChXdJRC5YZEhwOgjHT4FWy75Vs3608//7XlAfOF 7xbJIG/1I1+dx/RaENkdadf7Q100EEg0o3bnXzwf5gIdwsw7ZE3/YEmaowHG9AIfgl2j VqEahl+XI/E2rObOWIyTwDOCoRN7UOJvHJ9pohv/F+UY61cfT3T9AE5vDt0c/1INSKjK dqw+2UPD+6flxH+16HBRfwCF3Bb+jwcVMvjVTnNTLX6Q3KhrWYZme703rpD/6pJVErbG KbMwmhPyTopTLzCE8c5DRHi/JXh/oV4F+9hi54TvZi76O9dYjQGFaX0gVgOP4vzI5NRY eRTg== X-Forwarded-Encrypted: i=1; AL+hErHgBiamcW2zqFxa4xGp6QNu2aPH9+C0XbBPJlWNmgEiwgZ5mdYgbKlt9FzSA3AhGjtvrQtA7X3bsTVt2Cw=@vger.kernel.org X-Gm-Message-State: APuU4Z9jWggiolTqKDVM11a1LSoaDVSx9gqMRPD8LVlZ1YneNi/oaczv OfwZv39pfSx6sBo/2KDCJ1AgRv3zpChJKktYNfwqHNrV629IacK2XYRB X-Gm-Gg: AZFdTZfv/9q3lU+JCpyu/oCRc/GUigGaHfWtX0cOuRTY9u8hpo9Yc5i7rq/VCOQ5gGf 5uFOx6SGFdi0IlZQq3zwEjNOO0zqxrPZD00YSfObZIKPfogWABBFKyLembla9T7O82zqHRsU3KR s1YsWjFako2ylWvnH0flpy0fBWvedv0BOEkIWgAvll4h9GVaVAUxH/Xn253JllFAL4eKP3sVpAl a0f6PXNxbQvIOvrpPIgaIH45bRqCRdz1CVryGdaft3kEem4YY8HZjFcPcQeL70TOnm7aWLoxLNM 8YsLO3J4NTn6/P32Z9ajC4eAAFOZPYO0dR1x8xuwM2zMpdv+YIhc7+4HPzsLcT4um/kVGrBH48j K77k8cS98xLLf+z28j0AIDvB4OEKXXqVSugMqahZ3NNYp8pzUDSVthE+feMS/h6pw/f4xIKBV1X +aAf4qToDW5HDOGWBFH4cMyKpES1HdxzntL+JOatsjlzXTVNQDo+v0lyym5pyYXr0mJrK/2bhid 5ZcngBxcnjwDxpXvZTGfGIYTVCE7JtZi4+5eKyYfY87rZkWjl/WDIiGSLwaoeiqQiEqPUBXC1+g qSmogfKsX9hjPZzMOeFuQ18OcQ8eoaVKiEJJMZtCMlg+oTHd90YwaeK7X7L0ztIEEGIgA/e34LQ 6OZfFDTQ6qw== X-Received: by 2002:a05:6402:1512:b0:6ba:12e2:46f2 with SMTP id 4fb4d7f45d1cf-6ba37d18d2emr4447226a12.8.1795335543575; Sun, 22 Nov 2026 00:19:03 -0800 (PST) Received: from xeon ([188.163.112.62]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6ba370e8ad0sm3617167a12.18.2026.11.22.00.18.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 22 Nov 2026 00:19:01 -0800 (PST) From: Svyatoslav Ryhel To: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Thierry Reding , Jonathan Hunter , Neil Armstrong , Jessica Zhang , Mikko Perttunen , Svyatoslav Ryhel Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v8 08/12] drm/tegra: output: Make panel parsing configurable Date: Sun, 22 Nov 2026 10:18:16 +0200 Message-ID: <20261122081820.53199-9-clamor95@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20261122081820.53199-1-clamor95@gmail.com> References: <20261122081820.53199-1-clamor95@gmail.com> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The tegra_output_probe() function performs panel parsing unconditionally, even for devices that do not require it or that handle panel parsing on their own (like DSI). This causes devices with dual DSI panels to fail, because they rely on the OF graph to find the secondary DSI controller, whereas tegra_output_probe() treats this port as a direct connection to the panel. An example of such a device is the Xiaomi Mi Pad. Make panel parsing configurable. Signed-off-by: Svyatoslav Ryhel --- drivers/gpu/drm/tegra/drm.h | 2 +- drivers/gpu/drm/tegra/dsi.c | 2 +- drivers/gpu/drm/tegra/hdmi.c | 2 +- drivers/gpu/drm/tegra/output.c | 52 ++++++++++++++++++---------------- drivers/gpu/drm/tegra/rgb.c | 2 +- drivers/gpu/drm/tegra/sor.c | 2 +- 6 files changed, 32 insertions(+), 30 deletions(-) diff --git a/drivers/gpu/drm/tegra/drm.h b/drivers/gpu/drm/tegra/drm.h index bc720ae8d95e1..e53fe68161cb8 100644 --- a/drivers/gpu/drm/tegra/drm.h +++ b/drivers/gpu/drm/tegra/drm.h @@ -156,7 +156,7 @@ static inline struct tegra_output *connector_to_output(struct drm_connector *c) } /* from output.c */ -int tegra_output_probe(struct tegra_output *output); +int tegra_output_probe(struct tegra_output *output, bool get_panel); void tegra_output_remove(struct tegra_output *output); int tegra_output_init(struct drm_device *drm, struct tegra_output *output); void tegra_output_exit(struct tegra_output *output); diff --git a/drivers/gpu/drm/tegra/dsi.c b/drivers/gpu/drm/tegra/dsi.c index b5806a53e75ac..6d6adc485e51e 100644 --- a/drivers/gpu/drm/tegra/dsi.c +++ b/drivers/gpu/drm/tegra/dsi.c @@ -1617,7 +1617,7 @@ static int tegra_dsi_probe(struct platform_device *pdev) if (err < 0) return err; - err = tegra_output_probe(&dsi->output); + err = tegra_output_probe(&dsi->output, false); if (err < 0) return err; diff --git a/drivers/gpu/drm/tegra/hdmi.c b/drivers/gpu/drm/tegra/hdmi.c index 3a94968bd983a..e8c4347f09e69 100644 --- a/drivers/gpu/drm/tegra/hdmi.c +++ b/drivers/gpu/drm/tegra/hdmi.c @@ -1855,7 +1855,7 @@ static int tegra_hdmi_probe(struct platform_device *pdev) hdmi->output.dev = &pdev->dev; - err = tegra_output_probe(&hdmi->output); + err = tegra_output_probe(&hdmi->output, true); if (err < 0) return err; diff --git a/drivers/gpu/drm/tegra/output.c b/drivers/gpu/drm/tegra/output.c index eebf0ec0eea0a..d7d7f6ce0a8c3 100644 --- a/drivers/gpu/drm/tegra/output.c +++ b/drivers/gpu/drm/tegra/output.c @@ -93,7 +93,7 @@ static irqreturn_t hpd_irq(int irq, void *data) return IRQ_HANDLED; } -int tegra_output_probe(struct tegra_output *output) +int tegra_output_probe(struct tegra_output *output, bool get_panel) { struct device_node *ddc, *panel; const void *edid; @@ -103,31 +103,33 @@ int tegra_output_probe(struct tegra_output *output) if (!output->of_node) output->of_node = output->dev->of_node; - err = drm_of_find_panel_or_bridge(output->of_node, -1, -1, - &output->panel, &output->bridge); - if (err && err != -ENODEV) - return err; - - panel = of_parse_phandle(output->of_node, "nvidia,panel", 0); - if (panel) { - /* - * Don't mix nvidia,panel phandle with the graph in a - * device-tree. - */ - WARN_ON(output->panel || output->bridge); - - if (output->panel) { - drm_panel_put(output->panel); - output->panel = NULL; - } - - output->panel = of_drm_find_panel(panel); - of_node_put(panel); - - if (IS_ERR(output->panel)) { - err = PTR_ERR(output->panel); - output->panel = NULL; + if (get_panel) { + err = drm_of_find_panel_or_bridge(output->of_node, -1, -1, + &output->panel, &output->bridge); + if (err && err != -ENODEV) return err; + + panel = of_parse_phandle(output->of_node, "nvidia,panel", 0); + if (panel) { + /* + * Don't mix nvidia,panel phandle with the graph in a + * device-tree. + */ + WARN_ON(output->panel || output->bridge); + + if (output->panel) { + drm_panel_put(output->panel); + output->panel = NULL; + } + + output->panel = of_drm_find_panel(panel); + of_node_put(panel); + + if (IS_ERR(output->panel)) { + err = PTR_ERR(output->panel); + output->panel = NULL; + return err; + } } } diff --git a/drivers/gpu/drm/tegra/rgb.c b/drivers/gpu/drm/tegra/rgb.c index 40a02cf5939aa..227a178f761bd 100644 --- a/drivers/gpu/drm/tegra/rgb.c +++ b/drivers/gpu/drm/tegra/rgb.c @@ -236,7 +236,7 @@ int tegra_dc_rgb_probe(struct tegra_dc *dc) rgb->output.of_node = np; rgb->dc = dc; - err = tegra_output_probe(&rgb->output); + err = tegra_output_probe(&rgb->output, true); if (err < 0) return err; diff --git a/drivers/gpu/drm/tegra/sor.c b/drivers/gpu/drm/tegra/sor.c index 061c5dbb738be..ebac9068b670f 100644 --- a/drivers/gpu/drm/tegra/sor.c +++ b/drivers/gpu/drm/tegra/sor.c @@ -3803,7 +3803,7 @@ static int tegra_sor_probe(struct platform_device *pdev) if (err < 0) goto put_aux; - err = tegra_output_probe(&sor->output); + err = tegra_output_probe(&sor->output, true); if (err < 0) { dev_err_probe(&pdev->dev, err, "failed to probe output\n"); goto put_aux; -- 2.53.0