From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=74.125.82.169 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795343784; b=NcWVJ+Yr1J2WXjXS921U2EsA0WMMl+B+f0QJWy6L33HzUH49SoCZJVJMVykhklYMEKcg gst8nHJc7EF7GKw6OTWVPwfMFfhZ7KSMTL9kp5G/11UOcZCzChVGHudwGpHyDzJdFZeso Ul9rKKy7/VnwUfBL4XCdLcPm8zq9WWWPlDl/XmtETOtMCUhcrdNVX0LRU4KlZhx3IlCPk 2TQtBEe8U+qfuyO94a34Vgu0LvuTFTNE1EoiRS/1vMJDjQwzBsiRCMfFZ2k+xvklStcbK xTzAsNpXfLhgLSypCk/GOklGM04i5hxzKbFGS19xylIDBS9aeHvcAknS7RJzxEB0gfA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795343784; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: From:To:Cc:Subject:Date:Message-ID:X-Mailer:In-Reply-To:References: MIME-Version:Content-Transfer-Encoding; bh=NFO8ABB2++Lb4Qniw60fNu+n6Ox71u5p1UIy7s61ddc=; b=SZsxC5gofZX6EdUEg7matPk9QjXPjeb4MSr7bXQHNGW+/iJh6nCqoyWoYBc/o+unzwzW vJ91SUrQ7bwbYsP4P1o9EGJorF+3RQxbwn/8XisynZ7No0PYKne9YxGKVja1Yaw08ZCDp QopLIL4qN4ZBxuKjPwTTNt2AOjfJ16G3yTppg7X3s72+X+PQZJ8iSMw8KPKgEjFsGjLh8 qqDv0whrt7yU7B8GUbKJG6UVLPWBI/4ISAA5GGRJ6/lOpQ6/1r0v+OYiqWToDTEwNwCn0 A9EYLOBewJkmxS/TKvfr3z7DcXu94M9e84I5ozxVCCy8dfXcsGdv/3onNJ8cX8yDW6A== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=bCcPs84Q; arc=none smtp.remote-ip=74.125.82.169 Received: from mail-dy1-f169.google.com (mail-dy1-f169.google.com [74.125.82.169]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 55863606A335 for ; Sun, 22 Nov 2026 10:36:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 55863606A335 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=bCcPs84Q Received: by mail-dy1-f169.google.com with SMTP id 5a478bee46e88-380b40312e2so5474923eec.1 for ; Sun, 22 Nov 2026 02:36:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1795343782; x=1795948582; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=NFO8ABB2++Lb4Qniw60fNu+n6Ox71u5p1UIy7s61ddc=; b=bCcPs84Q8MYdYT0X0Bg0dhFEe41xvC4BLYFYIgvjMg22VLdC9WSL47hQ+tfl47Cc/u OktulD8NotuMYcw4+w0akb+FEpn+QcdMWFtGMNyhRT6wjIdzK0tiwfGuC8QDjEStM3Bi 5UBP7f5nMjSDbmNUVycWUpwL0dJYSwg1x8V4jXy4N34AXF2lXp5tzF9vt3lVOLb3yVRS 17oKRQN040/K49pauZHoR1u1voRXfmnOmgSIbrNFbh7JTH4Zi7pUf0i+iq8PqYRxVHXk xe0j0LMUw4uEZBbuFnYm9BuDXtRe6sc705osle31d37Iab39b7mc0NU3921rMfrL5BKv VKTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1795343782; x=1795948582; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=NFO8ABB2++Lb4Qniw60fNu+n6Ox71u5p1UIy7s61ddc=; b=cAGVDToHfJ4mbcNvqPwQKFJdWXOyegXAtmH4fnKSHCe02WdUyTMv437E6RktXd16Gn 15aDftRITEQMXtOdMdquAS+TC3d/6q5NTSIQN0Nudy/qJtoAm8lsdwPKsu26xPQOUt1/ YB7t20nX0g6pK8N3dLBMk/82RgkO7zQSQXjGJyJZBGETr49lW7iJ0PYjPGXEwsFiQB// eESmZnZ1AscQNV7DcDNDlnyiIl71/AbmfeKwFblbu6XTtwgktk2DaXZNgBGOZpXxMip0 cGVXDaXXPeYnjAxeSNh2YrFKbaP82+/LFxbQJzTJBiMQxnwvprxTrBhgZtSxuNHS9Ips R6nA== X-Forwarded-Encrypted: i=1; AL+hErFtDgf/mo/zpjJC+amfX63EMRBgAno+M+OmHGHxgFL/GsZcUofR06BwHHYOOl/qj2fbcwxfhIVT/rw8QP4=@vger.kernel.org X-Gm-Message-State: APuU4Z+awetOkQNl1NWQUZqzPoWgEZjTh5/WyshAWqa1TnAXaU18zTsg HIMYq7Vj27DDRPE7s6kSX/kAMVkHt8z3HG9fea+JOAo1zhEefBQd21KG X-Gm-Gg: AZFdTZdySZjWll8ai2UUpKvzFzioyLx+gx7JDIoGTce1GWXB+aBJPHqCK9MfpbHv2O6 Zs03dSvT+B3JejHM5i67wGjt7gTJbKvkzBYWVJB+lZ/P056pKTGznb0KPnT9IJ87xcyPOykzr+l 6ox2lO+Q+9s+Fwm8nb1a2o6LZY5qZG0F/iLFS3W2UpICUUMacOc0j5T+hKyhwt+anui9lb1pFoS AjorBWgBAI9YZO0ohAZEuDS+rCIDeYcQewfsBaLKm6YV7g0cd9aGlQNOG9o5Yz2hNSRYr2aAF8/ pP/UrTJZb6mGeI5GUi+p/jzRtc8NAkeaUnVzBmdQYC/gLG35s1fawYgArBOpo/Pglszm8Y/Z/63 BID41L5NQH5tZsxbQQ3uezRsbR2yU8hPVlV4mJAQk5jKF9Z7g24YGE0fwnVh1NJFTXm3g7CNeV9 gqD0YzwSuUe5gmrPqZccZQGA3wpmwvqEyphajgm6PZOFTxK1kWN2m/If3R5fOEthm8dWY7Mfu+x S0kcUvyFC5+qF0FSHaHkYQEDgrhlMwCnZK1+0Q4MwXs9d4sgvzcGx8tta8ubRJauYSPCTgRj5Gd aVj7+0tMk9LTEUULtSFG55y7egSzCqa0FImgJbdAkVOPoei9cP7J/ipr2MgFDTdlve66v96ajmn FKbZlFDWSmFyq3fEAvZhAA2kjON2fORGRu2nJWbLP X-Received: by 2002:a05:7300:f68e:b0:369:f291:49da with SMTP id 5a478bee46e88-38571814b1dmr8880157eec.40.1795343782479; Sun, 22 Nov 2026 02:36:22 -0800 (PST) Received: from nugod-NUC15CRHU5.tail9f095a.ts.net ([218.237.104.87]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-385667decc2sm26176803eec.9.2026.11.22.02.36.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 22 Nov 2026 02:36:21 -0800 (PST) From: HyeongJun An To: Takashi Iwai Cc: Jaroslav Kysela , Mark Brown , Shuah Khan , linux-sound@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, HyeongJun An , stable@vger.kernel.org Subject: [PATCH 1/2] ALSA: seq: ump: Don't drop MIDI 2.0 RPN and NRPN for MIDI 1.0 clients Date: Sun, 22 Nov 2026 19:36:10 +0900 Message-ID: <20261122103611.3264343-2-sammiee5311@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20261122103611.3264343-1-sammiee5311@gmail.com> References: <20261122103611.3264343-1-sammiee5311@gmail.com> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The cvt_ump_midi2_to_midi1() converts MIDI 2.0 channel voice messages for a UMP MIDI 1.0 client. It has no case for the RPN and NRPN messages, so they fall into the default case and are dropped. A pitch bend range or a tuning set by a MIDI 2.0 client never reaches a MIDI 1.0 client. The core converter, cvt_ump_midi2_to_legacy(), turns the same messages into CC 101 and 100 (99 and 98 for NRPN) followed by CC 6 and 38. The program change case here already sends the bank select CCs ahead of the program in the same way. To fix this, deliver the four CCs that cvt_ump_midi2_to_legacy() produces. Fixes: e9e02819a98a ("ALSA: seq: Automatic conversion of UMP events") Cc: stable@vger.kernel.org Signed-off-by: HyeongJun An --- sound/core/seq/seq_ump_convert.c | 36 ++++++++++++++++++++++++++++++++ 1 file changed, 36 insertions(+) diff --git a/sound/core/seq/seq_ump_convert.c b/sound/core/seq/seq_ump_convert.c index b42a7ffbf31e..e76fdb54df17 100644 --- a/sound/core/seq/seq_ump_convert.c +++ b/sound/core/seq/seq_ump_convert.c @@ -432,6 +432,38 @@ static int cvt_ump_midi1_to_midi2(struct snd_seq_client *dest, atomic, hop); } +/* send a MIDI 2.0 RPN/NRPN as the four MIDI 1.0 CCs that select and set it */ +static int cvt_ump_midi2_rpn_to_midi1(struct snd_seq_client *dest, + struct snd_seq_client_port *dest_port, + struct snd_seq_ump_event *ev_cvt, + const union snd_ump_midi2_msg *midi2, + int atomic, int hop) +{ + union snd_ump_midi1_msg *midi1 = (union snd_ump_midi1_msg *)ev_cvt->ump; + bool rpn = midi2->rpn.status == UMP_MSG_STATUS_RPN; + u16 v = downscale_32_to_14bit(midi2->rpn.data); + const unsigned char cc[4][2] = { + { rpn ? UMP_CC_RPN_MSB : UMP_CC_NRPN_MSB, midi2->rpn.bank }, + { rpn ? UMP_CC_RPN_LSB : UMP_CC_NRPN_LSB, midi2->rpn.index }, + { UMP_CC_DATA, v >> 7 }, + { UMP_CC_DATA_LSB, v & 0x7f }, + }; + int i, err = 0; + + midi1->cc.status = UMP_MSG_STATUS_CC; + for (i = 0; i < ARRAY_SIZE(cc); i++) { + midi1->cc.index = cc[i][0]; + midi1->cc.data = cc[i][1]; + err = __snd_seq_deliver_single_event(dest, dest_port, + (struct snd_seq_event *)ev_cvt, + atomic, hop); + if (err < 0) + return err; + } + + return err; +} + /* convert UMP packet from MIDI 2.0 to MIDI 1.0 and deliver it */ static int cvt_ump_midi2_to_midi1(struct snd_seq_client *dest, struct snd_seq_client_port *dest_port, @@ -499,6 +531,10 @@ static int cvt_ump_midi2_to_midi1(struct snd_seq_client *dest, midi1->pb.data_msb = v >> 7; midi1->pb.data_lsb = v & 0x7f; break; + case UMP_MSG_STATUS_RPN: + case UMP_MSG_STATUS_NRPN: + return cvt_ump_midi2_rpn_to_midi1(dest, dest_port, &ev_cvt, + midi2, atomic, hop); default: return 0; } -- 2.43.0