mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alex Markuze <amarkuze@redhat.com>
To: Daolong Zhang <dlzhangak@isoftstone.com>
Cc: Ilya Dryomov <idryomov@gmail.com>,
	Viacheslav Dubeyko <slava@dubeyko.com>,
	ceph-devel@vger.kernel.org, Jonathan Corbet <corbet@lwn.net>,
	Shuah Khan <skhan@linuxfoundation.org>,
	linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ceph: add compression_hint mount option
Date: Sun, 22 Nov 2026 17:37:00 +0000	[thread overview]
Message-ID: <20261122173700.1281165-1-amarkuze@redhat.com> (raw)
In-Reply-To: <1795169573.6B001D21.006.4jWB3k0l79z3mds@fangwg01>

Hi Daolong,

If a mount starts with compression_hint=compressible and is later
reconfigured without that option, ceph_init_fs_context() allocates a
zeroed options structure and ceph_reconfigure_fc() unconditionally
copies its alloc_hint_flags into the live mount. The reconfiguration
therefore clears the selected hint, so later writes stop sending it even
though the compression option was not changed.

Could the existing value be preserved when the option is omitted, while
still allowing compression_hint=none to clear it explicitly?

Could you also check that the patch applies cleanly to the latest
ceph-client testing branch?

Thanks,
Alex


      reply	other threads:[~2026-11-22 17:37 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-20 10:12 Daolong Zhang
2026-11-22 17:37 ` Alex Markuze [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261122173700.1281165-1-amarkuze@redhat.com \
    --to=amarkuze@redhat.com \
    --cc=ceph-devel@vger.kernel.org \
    --cc=corbet@lwn.net \
    --cc=dlzhangak@isoftstone.com \
    --cc=idryomov@gmail.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=skhan@linuxfoundation.org \
    --cc=slava@dubeyko.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®