mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mervyn Pretorius <mervynpretorius.oss@gmail.com>
To: Pinkesh Vaghela <pinkesh.vaghela@einfochips.com>
Cc: Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Paul Walmsley <pjw@kernel.org>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Alexandre Ghiti <alex@ghiti.fr>,
	Andi Shyti <andi.shyti@kernel.org>,
	Mika Westerberg <mika.westerberg@linux.intel.com>,
	linux-i2c@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org,
	Min Lin <linmin@eswincomputing.com>,
	Yulin Lu <luyulin@eswincomputing.com>,
	Samuel Holland <samuel.holland@sifive.com>,
	Darshan Prajapati <darshan.prajapati@einfochips.com>,
	Pritesh Patel <pritesh.patel@einfochips.com>
Subject: Re: [PATCH v5 0/7] riscv: eswin: eic7700: Add support for clocks, resets, pinctrl, HSP bus, I2C and watchdog
Date: Sun, 22 Nov 2026 19:18:42 +0000	[thread overview]
Message-ID: <20261122191842.2183685-1-mervynpretorius.oss@gmail.com> (raw)
In-Reply-To: <20261015125454.1381941-1-pinkesh.vaghela@einfochips.com>

Hi,

I tried this series on a DeepComputing DC-ROMA RISC-V Mainboard II
(FML13V03). It uses an EIC7702X, i.e. two EIC7700X dies, with 32 GiB.

Setup: v7.4-rc3 (4843f6873f7c) + this series + a minimal local board dts
that includes eic7700.dtsi and eic7700-pinctrl.dtsi and describes die 0
(4 of the 8 harts, uart0, the firmware reserved-memory regions). Boot
chain: OpenSBI v1.3, U-Boot 2024.01, GRUB (EFI); the kernel takes its
memory from the EFI memory map, so it also uses die 1's RAM. Initramfs
only, no storage.

Config: defconfig + PINCTRL_EIC7700, DW_WATCHDOG and RISCV_SBI_V01 (the
firmware's SBI is v1.0, so earlycon=sbi needs the legacy console call).

With clk_ignore_unused, the non-I2C parts of this series probe cleanly:
eic7700-clock, eic7700-reset, pinctrl-eic7700 (with a fixed 3.3 V vrgmii
supply; no pinmux consumers yet), the four dw_wdt instances and the hsp
simple-pm-bus. The console, interrupts, timer and SBI reboot work. I
left the I2C controllers disabled, so patches 5/7 and 6/7 are only
build-tested here, and for patch 3/7 none of the pinmux states in
eic7700-pinctrl.dtsi were exercised. I'm therefore replying with
Tested-by only to patches 1/7, 2/7, 4/7 and 7/7 rather than to this
cover letter.

Without clk_ignore_unused, the board hangs during/after
clk_disable_unused(). That looks like an issue in the already-merged
drivers/clk/eswin/clk-eic7700.c rather than in this series (I don't
have a single-die EIC7700X to see whether it is EIC7702X-specific), so
I'm reporting it separately to linux-clk and the clock driver
maintainers ("clk: eswin: eic7700: EIC7702X hangs when disabling unused
D2D/PVT gates").

One build note on patch 6/7: eic7700.dtsi now references i2c0_pins ..
i2c11_pins, which are defined in eic7700-pinctrl.dtsi. A board dts must
therefore include eic7700-pinctrl.dtsi too (as the P550 dts does),
otherwise dtc fails with:

  ERROR (phandle_references): /soc/i2c@50950000: Reference to non-existent node or label "i2c0_pins"

Is that intended, or should eic7700.dtsi include eic7700-pinctrl.dtsi
itself (or the pinctrl-0 properties move to the board files) so that
the SoC dtsi stays self-contained?

Thanks,
Mervyn Pretorius

      parent reply	other threads:[~2026-11-22 19:18 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-15 12:54 Pinkesh Vaghela
2026-10-15 12:54 ` [PATCH v5 1/7] riscv: dts: eswin: add reset generator for EIC7700 SoC Pinkesh Vaghela
2026-11-22 19:18   ` Mervyn Pretorius
2026-10-15 12:54 ` [PATCH v5 2/7] riscv: dts: eswin: add clock " Pinkesh Vaghela
2026-11-22 19:19   ` Mervyn Pretorius
2026-10-15 12:54 ` [PATCH v5 3/7] riscv: dts: eswin: eic7700: add pinctrl support Pinkesh Vaghela
2026-10-15 12:54 ` [PATCH v5 4/7] riscv: dts: eswin: add hsp bus node Pinkesh Vaghela
2026-11-22 19:19   ` Mervyn Pretorius
2026-10-15 12:54 ` [PATCH v5 5/7] dt-bindings: i2c: dw: add ESWIN EIC7700 SoC I2C controller Pinkesh Vaghela
2026-10-15 12:54 ` [PATCH v5 6/7] riscv: dts: eswin: add I2C controller support Pinkesh Vaghela
2026-10-15 12:54 ` [PATCH v5 7/7] riscv: dts: eswin: add watchdog support Pinkesh Vaghela
2026-11-22 19:19   ` Mervyn Pretorius
2026-11-06  7:53 ` [PATCH v5 0/7] riscv: eswin: eic7700: Add support for clocks, resets, pinctrl, HSP bus, I2C and watchdog Pinkesh Vaghela
2026-11-22 19:18 ` Mervyn Pretorius [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261122191842.2183685-1-mervynpretorius.oss@gmail.com \
    --to=mervynpretorius.oss@gmail.com \
    --cc=alex@ghiti.fr \
    --cc=andi.shyti@kernel.org \
    --cc=aou@eecs.berkeley.edu \
    --cc=conor+dt@kernel.org \
    --cc=darshan.prajapati@einfochips.com \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linmin@eswincomputing.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=luyulin@eswincomputing.com \
    --cc=mika.westerberg@linux.intel.com \
    --cc=palmer@dabbelt.com \
    --cc=pinkesh.vaghela@einfochips.com \
    --cc=pjw@kernel.org \
    --cc=pritesh.patel@einfochips.com \
    --cc=robh@kernel.org \
    --cc=samuel.holland@sifive.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®