From: Jonathan Cameron <jic23@kernel.org>
To: Arnav Kapoor <kapoorarnav43@gmail.com>
Cc: "David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Andy Shevchenko" <andriy.shevchenko@intel.com>,
"Gwendal Grignou" <gwendal@chromium.org>,
"Joshua Crofts" <joshua.crofts1@gmail.com>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 0/3] iio: proximity: sx93xx: keep the IRQ balanced across suspend and resume
Date: Sun, 22 Nov 2026 20:49:29 +0000 [thread overview]
Message-ID: <20261122204929.326a730a@jic23-hlaptop> (raw)
In-Reply-To: <20261114073601.23404-1-kapoorarnav43@gmail.com>
On Sat, 14 Nov 2026 13:05:54 +0530
Arnav Kapoor <kapoorarnav43@gmail.com> wrote:
> sx9310, sx9324 and sx9360 disable the interrupt in suspend before
> anything that can fail, and don't enable it again when suspend or resume
> fails. One patch per driver, as the Fixes tags differ.
Applied to the testing branch of iio.git and marked for stable.
Given we hope that failure in suspend and resume is incredibly rare
and we are now someway into this cycle I'm not going to rush these in.
>
> Changes in v5:
> - Disable the interrupt with disable_irq() before taking the mutex,
> and enable it again if suspend fails. v4 called disable_irq_nosync()
> at the end of suspend, so a threaded handler woken during the
> register writes could run after suspend returned. Found by Sashiko.
> - Move the register accesses into a *_sleep() helper per driver so the
> mutex is released before the interrupt is re-enabled on failure
> - Rebase on fixes-togreg
>
> v4: https://lore.kernel.org/all/20261101102518.22757-1-kapoorarnav43@gmail.com/
> v3: https://lore.kernel.org/all/20261028220444.70121-1-kapoorarnav43@gmail.com/
> v2: https://lore.kernel.org/all/20261026112342.65917-1-kapoorarnav43@gmail.com/
> v1:
> https://lore.kernel.org/all/20261026100322.16720-1-kapoorarnav43@gmail.com/
> https://lore.kernel.org/all/20261026100408.16874-1-kapoorarnav43@gmail.com/
> https://lore.kernel.org/all/20261026100450.17023-1-kapoorarnav43@gmail.com/
>
> Compile-tested only (W=1); I don't have the hardware and haven't
> reproduced a failing suspend.
>
> Arnav Kapoor (3):
> iio: proximity: sx9310: keep the IRQ balanced across suspend and
> resume
> iio: proximity: sx9324: keep the IRQ balanced across suspend and
> resume
> iio: proximity: sx9360: keep the IRQ balanced across suspend and
> resume
>
> drivers/iio/proximity/sx9310.c | 54 ++++++++++++++++++++++------------
> drivers/iio/proximity/sx9324.c | 43 ++++++++++++++++++---------
> drivers/iio/proximity/sx9360.c | 45 ++++++++++++++++++----------
> 3 files changed, 94 insertions(+), 48 deletions(-)
>
>
> base-commit: a6d9114f68c4b5507b2d945bd6d1e37415f913c5
prev parent reply other threads:[~2026-11-22 20:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-14 7:35 Arnav Kapoor
2026-11-14 7:35 ` [PATCH v5 1/3] iio: proximity: sx9310: " Arnav Kapoor
2026-11-14 7:35 ` [PATCH v5 2/3] iio: proximity: sx9324: " Arnav Kapoor
2026-11-14 7:35 ` [PATCH v5 3/3] iio: proximity: sx9360: " Arnav Kapoor
2026-11-22 20:49 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261122204929.326a730a@jic23-hlaptop \
--to=jic23@kernel.org \
--cc=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=gwendal@chromium.org \
--cc=joshua.crofts1@gmail.com \
--cc=kapoorarnav43@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®