From: Mikael Pettersson <mikpe@it.uu.se>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: Mikael Pettersson <mikpe@it.uu.se>,
"Mohd. Faris" <mohdfarisq2010@gmail.com>,
Kautuk Consul <consul.kautuk@gmail.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] arm: vfp: Raising SIGFPE on invalid floating point operation
Date: Fri, 3 Feb 2012 15:41:20 +0100 [thread overview]
Message-ID: <20267.61968.579756.647011@pilspetsen.it.uu.se> (raw)
In-Reply-To: <20120203140621.GK889@n2100.arm.linux.org.uk>
Russell King - ARM Linux writes:
> On Fri, Feb 03, 2012 at 02:32:14PM +0100, Mikael Pettersson wrote:
> > No, a SIGFPE delivered at the wrong point in time with the wrong
> > context in its sigframe is MUCH worse than not getting a SIGFPE
> > at all. (And likewise for all other trap signals, SEGV, ILL, etc.)
>
> If your FP is pipelined, then you won't get a SIGFPE for a div0 situation
> as soon as the instruction appears in the program. Think about what's
> happening.
>
> 1. The FP hardware may be occupied with a computation.
> 2. The program issues the divide instruction, the FP hardware accepts
> this. Meanwhile, the integer part of the core continues processing
> instructions.
> 3. The FP hardware completes its computation, and gets to execute the
> divide instruction.
> 4. The FP hardware discovers a divide-by-zero situation, and flags it
> in its status register.
>
> At this point, there's no way for the FP hardware to flag that situation
> to the integer core (there's no interrupt.) The failure gets flagged
> when the program executes the next FP instruction, and is raised by the
> FP hardware refusing to accept that instruction with an exception status.
It's OK to deliver on the next FP insn, that's a fairly common design
and not too difficult to handle (at least not for what I've used it for,
namely to use FP exns instead of explicit NaN/Inf checks in the runtime
of the Erlang VM, and to turn the FP exns into language-level exceptions).
My reaction was against delivering at some random point in the future
where possibly incorrect decisions have already been made, and where
the state is arbitrarily different from the one at the exn origin.
However, having read Dave Martin's response I now think the problem is
a buggy application or libc, and not something the kernel should care
about.
prev parent reply other threads:[~2012-02-03 14:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-03 8:36 Kautuk Consul
2012-02-03 13:27 ` Dave Martin
2012-02-03 14:37 ` Kautuk Consul
2012-02-03 15:11 ` Russell King - ARM Linux
2012-02-03 14:45 ` Mikael Pettersson
2012-02-03 13:32 ` Mikael Pettersson
2012-02-03 14:06 ` Russell King - ARM Linux
2012-02-03 14:41 ` Mikael Pettersson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20267.61968.579756.647011@pilspetsen.it.uu.se \
--to=mikpe@it.uu.se \
--cc=consul.kautuk@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mohdfarisq2010@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®