From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S933270AbcINQnf (ORCPT <rfc822;w@1wt.eu>);
        Wed, 14 Sep 2016 12:43:35 -0400
Received: from cloudserver094114.home.net.pl ([79.96.170.134]:44363 "HELO
        cloudserver094114.home.net.pl" rhost-flags-OK-OK-OK-OK)
        by vger.kernel.org with SMTP id S932645AbcINQnd (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 14 Sep 2016 12:43:33 -0400
From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Hoan Tran <hotran@apm.com>
Cc: Len Brown <lenb@kernel.org>,
        Prashanth Prakash <pprakash@codeaurora.org>,
        Ashwin Chaugule <ashwin.chaugule@linaro.org>,
        linux acpi <linux-acpi@vger.kernel.org>,
        lkml <linux-kernel@vger.kernel.org>, Loc Ho <lho@apm.com>,
        Duc Dang <dhdang@apm.com>, Ashwin Chaugule <ashwinch@google.com>
Subject: Re: [PATCH] ACPI: CPPC: Support PCC with interrupt flag
Date: Wed, 14 Sep 2016 18:49:41 +0200
Message-ID: <2027903.xXCTulqOxA@vostro.rjw.lan>
User-Agent: KMail/4.11.5 (Linux/4.8.0-rc2+; KDE/4.11.5; x86_64; ; )
In-Reply-To: <CAFHUOYx69g7zQwzMQHfBixmbSU3meq0CA3xNz49_kDOPYPrBUQ@mail.gmail.com>
References: <1469135265-27048-1-git-send-email-hotran@apm.com> <CAFHUOYxi1=K9RSgxA0HLXH4Tq3iyCLMrYbyGmVowATwWc1KU_g@mail.gmail.com> <CAFHUOYx69g7zQwzMQHfBixmbSU3meq0CA3xNz49_kDOPYPrBUQ@mail.gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="utf-8"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wednesday, September 14, 2016 08:45:14 AM Hoan Tran wrote:
> On Tue, Aug 30, 2016 at 11:20 AM, Hoan Tran <hotran@apm.com> wrote:
> > On Thu, Jul 21, 2016 at 2:07 PM, Hoan Tran <hotran@apm.com> wrote:
> >> For PCC mailbox with interrupt flag, CPPC should call mbox_chan_txdone()
> >> function to notify the mailbox framework about TX completion.
> >>
> >> Signed-off-by: Hoan Tran <hotran@apm.com>
> >> ---
> >> This patch is tested on top and depends on patch[1]:
> >> [1] http://www.spinics.net/lists/linux-acpi/msg66041.html
> >>  - [PATCH v3] mailbox: pcc: Support HW-Reduced Communication Subspace type 2
> >>
> >>  drivers/acpi/cppc_acpi.c | 6 +++++-
> >>  1 file changed, 5 insertions(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/acpi/cppc_acpi.c b/drivers/acpi/cppc_acpi.c
> >> index 2e98173..19606aa 100644
> >> --- a/drivers/acpi/cppc_acpi.c
> >> +++ b/drivers/acpi/cppc_acpi.c
> >> @@ -191,7 +191,11 @@ static int send_pcc_cmd(u16 cmd)
> >>                         last_cmd_cmpl_time = ktime_get();
> >>         }
> >>
> >> -       mbox_client_txdone(pcc_channel, ret);
> >> +       if (pcc_channel->mbox->txdone_irq)
> >> +               mbox_chan_txdone(pcc_channel, ret);
> >> +       else
> >> +               mbox_client_txdone(pcc_channel, ret);
> >> +
> >>         return ret;
> >>  }
> >>
> >> --
> >> 1.9.1
> >>
> >
> > Any feedbacks.
> >
> > Thanks
> > Hoan
> 
> Hi Rafael,
> 
> Do you have any comments on this patch ?

No, but can you please resend it (with the Reviewed-by tag from Prashanth,
preferably)?  And please make sure it applies on my linux-next branch.

Thanks,
Rafael