From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4891DC433DF for ; Mon, 12 Oct 2020 19:17:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F2E2F20725 for ; Mon, 12 Oct 2020 19:17:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390885AbgJLTRZ convert rfc822-to-8bit (ORCPT ); Mon, 12 Oct 2020 15:17:25 -0400 Received: from lithops.sigma-star.at ([195.201.40.130]:57204 "EHLO lithops.sigma-star.at" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729890AbgJLTRY (ORCPT ); Mon, 12 Oct 2020 15:17:24 -0400 Received: from localhost (localhost [127.0.0.1]) by lithops.sigma-star.at (Postfix) with ESMTP id A63AF6125F33; Mon, 12 Oct 2020 21:17:21 +0200 (CEST) Received: from lithops.sigma-star.at ([127.0.0.1]) by localhost (lithops.sigma-star.at [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id 0sY4GwlcOtH7; Mon, 12 Oct 2020 21:17:20 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by lithops.sigma-star.at (Postfix) with ESMTP id 1558A61D8A8D; Mon, 12 Oct 2020 21:17:20 +0200 (CEST) Received: from lithops.sigma-star.at ([127.0.0.1]) by localhost (lithops.sigma-star.at [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id VOYcOp75qzIk; Mon, 12 Oct 2020 21:17:19 +0200 (CEST) Received: from lithops.sigma-star.at (lithops.sigma-star.at [195.201.40.130]) by lithops.sigma-star.at (Postfix) with ESMTP id DEBF16125F33; Mon, 12 Oct 2020 21:17:19 +0200 (CEST) Date: Mon, 12 Oct 2020 21:17:19 +0200 (CEST) From: Richard Weinberger To: Vignesh Raghavendra Cc: Miquel Raynal , Sergei Shtylyov , linux-mtd , linux-kernel Message-ID: <2029402034.189005.1602530239737.JavaMail.zimbra@nod.at> In-Reply-To: <20201012070958.11083-1-vigneshr@ti.com> References: <20201012070958.11083-1-vigneshr@ti.com> Subject: Re: [PATCH] mtd: hyperbus: Fix build failure when only RPCIF_HYPERBUS is enabled MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT X-Originating-IP: [195.201.40.130] X-Mailer: Zimbra 8.8.12_GA_3807 (ZimbraWebClient - FF78 (Linux)/8.8.12_GA_3809) Thread-Topic: hyperbus: Fix build failure when only RPCIF_HYPERBUS is enabled Thread-Index: Uh0XQbUp09aZK/SHpd4OdKcrRr0PTg== Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ----- Ursprüngliche Mail ----- > Von: "Vignesh Raghavendra" > An: "Vignesh Raghavendra" , "Miquel Raynal" , "richard" > CC: "Sergei Shtylyov" , "linux-mtd" , "linux-kernel" > > Gesendet: Montag, 12. Oktober 2020 09:09:58 > Betreff: [PATCH] mtd: hyperbus: Fix build failure when only RPCIF_HYPERBUS is enabled > commit 5de15b610f78 ("mtd: hyperbus: add Renesas RPC-IF driver") leads > to build failure[1] with COMPILE_TEST and RPCIF_HYPERBUS enabled. This > is because driver needs functions RENESAS_RPCIF which is only buildable > for CONFIG_ARCH_RENESAS. > > Fix this by dropping COMPILE_TEST from RPCIF_HYPERBUS Kconfig entry. > This ensures driver can be built only when RENESAS_RPCIF is also > selected. > > [1]: > rpc-if.c:(.text+0x20): undefined reference to `rpcif_disable_rpm' ld: > drivers/mtd/hyperbus/rpc-if.o: in function `rpcif_hb_prepare_read': > rpc-if.c:(.text+0xd6): undefined reference to `rpcif_prepare' ld: > drivers/mtd/hyperbus/rpc-if.o: in function `rpcif_hb_read16': > [...] > > Fixes: 5de15b610f78 ("mtd: hyperbus: add Renesas RPC-IF driver") leads > Reported-by: Richard Weinberger > Signed-off-by: Vignesh Raghavendra > --- > > Based on mtd/next > > Richard, > > Could you please pull this into mtd/next? Applied! :-) Thanks, //richard