From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Yangtao Li <tiny.windzz@gmail.com>
Cc: viresh.kumar@linaro.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] cpufreq: ia64: Remove unused header files
Date: Mon, 17 Dec 2018 12:44:20 +0100 [thread overview]
Message-ID: <2029526.yj18hjzxFf@aspire.rjw.lan> (raw)
In-Reply-To: <20181205154449.15725-1-tiny.windzz@gmail.com>
On Wednesday, December 5, 2018 4:44:49 PM CET Yangtao Li wrote:
> seq_file.h does not need to be included, so remove it. Moreover deleted
> a line of meaningless return and some useless blank lines. In a function
> whose return type is void, returning on the last line is not required.
>
> Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
> ---
> changes in v2:
> -revert modify of MODULE_
> -delete some blank lines
> ---
> drivers/cpufreq/ia64-acpi-cpufreq.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/cpufreq/ia64-acpi-cpufreq.c b/drivers/cpufreq/ia64-acpi-cpufreq.c
> index dd5440d3372d..80c5bf590acb 100644
> --- a/drivers/cpufreq/ia64-acpi-cpufreq.c
> +++ b/drivers/cpufreq/ia64-acpi-cpufreq.c
> @@ -16,7 +16,6 @@
> #include <linux/init.h>
> #include <linux/cpufreq.h>
> #include <linux/proc_fs.h>
> -#include <linux/seq_file.h>
> #include <asm/io.h>
> #include <linux/uaccess.h>
> #include <asm/pal.h>
> @@ -28,7 +27,6 @@ MODULE_AUTHOR("Venkatesh Pallipadi");
> MODULE_DESCRIPTION("ACPI Processor P-States Driver");
> MODULE_LICENSE("GPL");
>
> -
> struct cpufreq_acpi_io {
> struct acpi_processor_performance acpi_data;
> unsigned int resume;
> @@ -348,10 +346,7 @@ acpi_cpufreq_exit (void)
> pr_debug("acpi_cpufreq_exit\n");
>
> cpufreq_unregister_driver(&acpi_cpufreq_driver);
> - return;
> }
>
> -
> late_initcall(acpi_cpufreq_init);
> module_exit(acpi_cpufreq_exit);
> -
>
Applied, thanks!
prev parent reply other threads:[~2018-12-17 11:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-05 15:44 Yangtao Li
2018-12-17 11:44 ` Rafael J. Wysocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2029526.yj18hjzxFf@aspire.rjw.lan \
--to=rjw@rjwysocki.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=tiny.windzz@gmail.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®