From: Joakim Tjernlund <Joakim.Tjernlund@infinera.com>
To: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"perex@perex.cz" <perex@perex.cz>,
"michael@ralston.id.au" <michael@ralston.id.au>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"tiwai@suse.com" <tiwai@suse.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>
Cc: "stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [PATCH] ALSA: usb-audio: Fix "cannot set freq 48000 to ep 0x3" msgs
Date: Thu, 1 Jun 2023 14:28:05 +0000 [thread overview]
Message-ID: <202bbbc0f51522e8545783c4c5577d12a8e2d56d.camel@infinera.com> (raw)
In-Reply-To: <20230601131116.1014250-1-joakim.tjernlund@infinera.com>
Adding Michael Ralston <michael@ralston.id.au>
He did have problems with his behringer UMC404HD device when this whole seq. was removed.
Ralston, can you try if the below change affects your device?
Jocke
On Thu, 2023-06-01 at 15:11 +0200, Joakim Tjernlund wrote:
> On some USB speaker devices(Jabra/Logitech) we see above error
> msg when connecting device to computer and kernel is probing the device.
>
> Moving the snd_usb_init_sample_rate() to after usb_set_interface() makes
> the error go away.
>
> Signed-off-by: Joakim Tjernlund <joakim.tjernlund@infinera.com>
> Cc: stable@vger.kernel.org
> ---
> sound/usb/stream.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/usb/stream.c b/sound/usb/stream.c
> index f10f4e6d3fb8..d9ac8663a48b 100644
> --- a/sound/usb/stream.c
> +++ b/sound/usb/stream.c
> @@ -1226,8 +1226,8 @@ static int __snd_usb_parse_audio_interface(struct snd_usb_audio *chip,
> /* try to set the interface... */
> usb_set_interface(chip->dev, iface_no, 0);
> snd_usb_init_pitch(chip, fp);
> - snd_usb_init_sample_rate(chip, fp, fp->rate_max);
> usb_set_interface(chip->dev, iface_no, altno);
> + snd_usb_init_sample_rate(chip, fp, fp->rate_max);
> }
> return 0;
> }
next prev parent reply other threads:[~2023-06-01 14:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-01 13:11 Joakim Tjernlund
2023-06-01 14:28 ` Joakim Tjernlund [this message]
2023-06-05 7:39 ` Takashi Iwai
2023-06-05 13:21 ` Joakim Tjernlund
2023-06-05 13:43 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202bbbc0f51522e8545783c4c5577d12a8e2d56d.camel@infinera.com \
--to=joakim.tjernlund@infinera.com \
--cc=alsa-devel@alsa-project.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael@ralston.id.au \
--cc=perex@perex.cz \
--cc=stable@vger.kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®