From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f173.google.com (mail-yw1-f173.google.com [209.85.128.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C4F553C061D for ; Sat, 1 Aug 2026 22:01:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785621694; cv=none; b=fH9KonhHpMu3n0bWNwIQH3xxVMU1LcGYkM4PPL9X6S3ZkEkpinGeZbyzxxVNzWRtjWlyjIFcZaT23N8KqHsNuH5wwdlF1acatGtSQuXYt3L2o9SJlm9XfStBPVGJnL18Djmhp5um/kEovMtPJN2P1iRR66Y4w9eI92ekgMKMSSg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785621694; c=relaxed/simple; bh=8eaNHjlxdd2m/7vaM8HHzpWZ1ndxEHRbTTCO2KCwplQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=XCl0n7WcJ3DgvZULxslO+Asf4rKdqU/DK4cqH0QKKX4GU4rN8lTO6/86hBb8HHd9luAkz08KcbN/ZVEkt4gTtKjBAxI94XbsKjnHZSjAoE/4eprZwWkOqddaJ0xiCGlKnUfLsGC4wrao9wrmucsnTfsUWxtA3uh9oYotvJzv1A4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Yun8d6rU; arc=none smtp.client-ip=209.85.128.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Yun8d6rU" Received: by mail-yw1-f173.google.com with SMTP id 00721157ae682-80cebd41372so32695827b3.3 for ; Sat, 01 Aug 2026 15:01:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785621686; x=1786226486; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=3pK8MlUvCqFzPv9m7RxaKBOJ8dELfs23G8cRNXDTowI=; b=Yun8d6rU0GoHZQcKyHCKysFS1cmF1+vOzb36IhO1iprimsJcB5E5iDw8v63y5vqL9b etNPkdTEm2nZfFCgJ9AIc+/vVJxP8roJGK9j2AXQilPM/2Cw2gDL2XdmBQtOUaV0sftj +rM0JHXCUz0P8wP2syNvzwrhjLipikksShz8Fo1f1Il703+AjjJAlQE8Dceo91k6cxbO QwKMnPaHb6dyxYmHOQVBOp2pwUEhHARdJroXbUAQ8UWKSSnj6IJihONCyXuBWozTaAxg bNWrQZjA+C+eEaOxdxtb8D8Aj+zV+DseLbs8obh7rIc6EsdLqJjFjnVQP8t583vhk8OZ Yx2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785621686; x=1786226486; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=3pK8MlUvCqFzPv9m7RxaKBOJ8dELfs23G8cRNXDTowI=; b=jtXFWRLdELzyGSL1LhtAeWFNUCs9DhrDe4+VDSOBf8FuWKZDx0BWmjvoe4MyfqaPQB 1whiRdZ10/Wx2rAE84C8YkZSaCXPTkUizi7ANosQxGKm5/F34TyXZtf7OKJjmRJV2hNQ hImV8BY3DN8NMg0B7UVbdR6wAESmp0kfFAakoroU4vpd/4sZTxRRZ4BEVSQW8Z1J0TKm Hc1OgLUGdKskoofpLHJexBpwXPOKXeGs8mrj7q7bhE/CBkTWyIMXu0r/npHvcdlmuXj6 I5C/8f3W/hMpzIWzkvq/upf4DklEyhIoxjCJnG0vZ4qQ38MshwAtgu6OIb+AS+T8w04K 80uQ== X-Forwarded-Encrypted: i=1; AHgh+RqcBkucE2P6DW06hnaJsgXedIGfjk9ZgoQfDTCqe2hvgcL7q2QBoOtnCnwYnDfXWb5xzZahkQlgoUgAmIk=@vger.kernel.org X-Gm-Message-State: AOJu0YwMBxngbBdJ2yiqhqgB7GyhwgRctEJ+/HGCh8k9zElv699jbar7 BUWnkYZkqfviQ9sy7bhIh3rodtXTLlTAPejDDf2BFZy6WqY8PgSP/10L X-Gm-Gg: AR+sD12XYQBYgVcDXlreolcx5lGPcVWn0P3t6f1IPOQ05hTLDGug7KDKRBxymRiJhgX 4kRdX/GLQvqPuAIbfoE1i5bSvXeApYo4XLQNGk7C2x+VOh27u2tWAMNQqvCg3m6zoihfVngwQSt Y6AiUEeWljpIb19zC1NDCC17vRXsjOVz/gGpst40oAnw5PUZ/AmgoWNjJixWg/UusjjmPGWYazK A3g/nT4TrZhiSTQeRy+kDYdMugNpol7ASPWazQVx2fLFxKfvGU1iJVwsv3+3kBkmSRTHcTG3Yf6 wsaMjRxQpPd0NG0i9ajrpnnIkLi7Tlw7WtEr6jXVbWCnWXCgJ01flVccvnzXGmEdnRI0B7WjY+5 U67tkj0duY/VPD0urh09YssDxnrmBrAQ0sfHEQzHZZrZLvn6cxS3ftfQB0PBaQYSLWahiMweuHj xhHKDA/Ak3WaTIA616HN78h2iO/f2zYCiZkr+WQBG8uKea1GiT2gfO6fX/6TLxkWZwZx9/i0rk8 Vc1elY= X-Received: by 2002:a05:690c:6f10:b0:80e:5236:b930 with SMTP id 00721157ae682-81fd4c9064cmr74857937b3.36.1785621685651; Sat, 01 Aug 2026 15:01:25 -0700 (PDT) Received: from syssplab.cs.fiu.edu (nat1.cs.fiu.edu. [131.94.134.89]) by smtp.gmail.com with ESMTPSA id 00721157ae682-81fcd0d6fbbsm29903767b3.25.2026.08.01.15.01.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 01 Aug 2026 15:01:24 -0700 (PDT) From: Chao Shi To: Jan Kara , Christian Brauner , Alexander Viro , Matthew Wilcox , linux-fsdevel@vger.kernel.org Cc: Theodore Ts'o , Andreas Dilger , Baokun Li , Ojaswin Mujoo , Ritesh Harjani , Zhang Yi , Bob Copeland , Namjae Jeon , Sungjong Seo , Yuezhang Mo , OGAWA Hirofumi , Mark Fasheh , Joel Becker , Joseph Qi , Andreas Gruenbacher , linux-ext4@vger.kernel.org, ocfs2-devel@lists.linux.dev, gfs2@lists.linux.dev, linux-karma-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, Chao Shi Subject: [PATCH 11/19] fat: check for a metadata write error with buffer_write_io_error() Date: Sat, 1 Aug 2026 18:00:55 -0400 Message-ID: <202c109fe73ff6899235aab9dc19ba15eeda0d5d.1785621505.git.coshi036@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit fat_sync_bhs() waits for the writes it issued and then tests !buffer_uptodate() to find the ones that failed. That relies on the write completion handler clearing BH_Uptodate on error, which this series removes: a buffer whose write failed still holds the data the filesystem asked to be written, so declaring it not up to date is wrong and makes callers re-read it. Test BH_Write_EIO, which is what the completion handler sets and what this code actually wants to know. No behaviour change today - a failed write sets BH_Write_EIO and clears BH_Uptodate together. It stops being a no-op at the end of the series, where the new test is the one that still works. Signed-off-by: Chao Shi --- fs/fat/misc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/fat/misc.c b/fs/fat/misc.c index be18f6b5819b..4a4cd0111e47 100644 --- a/fs/fat/misc.c +++ b/fs/fat/misc.c @@ -356,7 +356,7 @@ int fat_sync_bhs(struct buffer_head **bhs, int nr_bhs) for (i = 0; i < nr_bhs; i++) { wait_on_buffer(bhs[i]); - if (!err && !buffer_uptodate(bhs[i])) + if (!err && buffer_write_io_error(bhs[i])) err = -EIO; } return err; -- 2.43.0