mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Crazy Audio <daniel@matuschek.net>
To: Daniel Matuschek <daniel@matuschek.net>
Cc: alsa-devel@alsa-project.org,
	Dimitris.Papastamos@wolfsonmicro.com,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
	Takashi Iwai <tiwai@suse.de>,
	patches@opensource.wolfsonmicro.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: wm8804: Cleanup of post_table
Date: Sun, 12 Jan 2014 18:03:22 +0100	[thread overview]
Message-ID: <20301DDF-0676-4B70-BC73-9322A5ABDD41@crazy-audio.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1401121222180.3093@parallels-Parallels-Virtual-Platform>

Please ignore this patch. I did some regression tests, that shows, that it does not work correctly with MCLK=256xfs
I will create a new patch...


Am 12.01.2014 um 12:31 schrieb Daniel Matuschek <daniel@matuschek.net>:

> 
> Signed-off-by: Daniel Matuschek <inof@crazy-audio.com>
> 
> Existing post_table has duplicate settings for some PLL settings.
> Only the first setting was used with mclk_div=1
> With the updated post_table, the driver
> uses mclk_div=0 whenever it is possible. This allows the WM8804
> to work at 256xfs internal clock and only use 128xfs
> internal clock for high sample rates where 256xfs is not
> supported anymore.
> 
> ---
> sound/soc/codecs/wm8804.c |    2 --
> 1 file changed, 2 deletions(-)
> 
> diff --git a/sound/soc/codecs/wm8804.c b/sound/soc/codecs/wm8804.c
> index 1704b1e..f605b8b 100644
> --- a/sound/soc/codecs/wm8804.c
> +++ b/sound/soc/codecs/wm8804.c
> @@ -307,9 +307,7 @@ static struct {
> 	unsigned int mclkdiv;
> } post_table[] = {
> 	{  2,  0, 0 },
> -	{  4,  0, 1 },
> 	{  4,  1, 0 },
> -	{  8,  1, 1 },
> 	{  8,  2, 0 },
> 	{ 16,  2, 1 },
> 	{ 12,  3, 0 },
> -- 
> 1.7.9.5
> 


      reply	other threads:[~2014-01-12 17:03 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-12 11:31 Daniel Matuschek
2014-01-12 17:03 ` Crazy Audio [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20301DDF-0676-4B70-BC73-9322A5ABDD41@crazy-audio.com \
    --to=daniel@matuschek.net \
    --cc=Dimitris.Papastamos@wolfsonmicro.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=patches@opensource.wolfsonmicro.com \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®