From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4000736E463 for ; Fri, 6 Mar 2026 05:57:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772776637; cv=none; b=ADIjjSwtMJfyOWXLa41h1fPb1qyBt1OneE4s7OZ8M0RPlIEK+i2/yY4+RMdeTF7ZJnurz5R4Xj9jkJZ/AjGy1SsyeE1hJwR8qPvRCTDAoCiNPLPNe82LHomExmQVf/gdMP04Wn9G598XiEbQ7hpWSdgz3AKZdOJ64sNka0wsdpw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772776637; c=relaxed/simple; bh=XRshhNWCUls58Ec0Kd4jJCVhaUfesTsvoPyvZA++FtU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=S8VsrTX9KwFVYUF9pEFlOUM+PAqu3JvYDbneWLbrwOkdCXUf9kDFk2Ij6s4NKdOBbqZ6vFHvvLezamUAwvZ8x5lJ5qQlvaMUmTWCJyIIS3rJ9j4hlsGvW14WDUn9tY932IrkKKCMO5nIXnfuf0KnEjPIUwdeHxoc+3PrYkpUk7s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=DID515sq; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=TDB/soW+; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="DID515sq"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="TDB/soW+" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6265V6Rj3382967 for ; Fri, 6 Mar 2026 05:57:15 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= MiXXC9Y+HRfo/jOm96rMU2xnZoWoXsElrX39FtTY000=; b=DID515sqloTkGjjK Vui+++KEzoj0Wxds/W4mV/0g10ClKvTW3vPTjZ964veVCtbjD809lgLtEmEdDQAO b22bd9QJyFlYBqRnHEdG1aJB85TekWY8EZy/RcMITCHj11ZDfSPbiHJ/SANnpeA4 +D+mTJkT0oiwML1XU95qCTl2CDvIAXlkxe6e38EzHrMwqAhiej8itSubDrc3pkLM K3ANdeURHnJta5Z0WUDxVWcs/W+0FOQw+jEMNgAUiVs7asxzpXTbZyVQ8Q6Kokg9 LV52HSK2KbpWijGSJ8wkcuhgsOosLtKm8N0az+DiHVQLsJwsWLQ/zh+DsddmDNwb hNphYg== Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cqruk82j3-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 06 Mar 2026 05:57:15 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2ae53ec06b0so233988745ad.0 for ; Thu, 05 Mar 2026 21:57:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1772776634; x=1773381434; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=MiXXC9Y+HRfo/jOm96rMU2xnZoWoXsElrX39FtTY000=; b=TDB/soW+z+JlevVnzYPNEBMQt6xu9xIel6ZSmGjwZTxQNrTfNkgE8iU7HFDaFCLNc6 ra/jX3jOX6hOvWqTSJfJgNuipWUHLLxdY7FFVH+3dNxRsVMxapbysY8QpqYwsOtv5pwh vEZcJjKPe2XihrNLRp+xqZ8nNe9aKL0PsY7Y2mLez5SutvmQZrJDWwrFLmy9JFusFoS1 m6d1hTd6hEkzLFTeMKX5dH8ms2dJRP1aiGPt6D0y18f7fsq7hvJVJ9XTYyhBXo5jcqte IxItZvthfsKcnz1bFg1hHpbE0WwMK1SWG9Q28iG9lWfNZx1W6lhKUyQ3Lik/qYmovP8M GM9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772776634; x=1773381434; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=MiXXC9Y+HRfo/jOm96rMU2xnZoWoXsElrX39FtTY000=; b=dLG9beEKf17tlLNTEIrzDkQqgd0UqHd7/+C+k2ShkaYS+1A2C9x0waXTT1H7C2m1Kp cP7b17+AMSyTxoWtRc9wK1RqeHCrKVVMenl4QPdn9NW7C+jjD10eBq4+xB+fs/biBHEw nJ9Wkzxq0CpCwa8PecSizeCZJN2ZtRB1eodolMnzowzbYfpsa+aobS1k1w8cnuvqXE6M ypDCW6CKdC5WUMUy5b5IRJQ8lo68beYv1RBX6FNNLJzX+zlNp7HAufujX82J9fb+HvLl LYod2eGGePVr9eQ5QRRdaC/CdZ/eCMmFoAW4pt74+aYVwi4gDE0lo0fA4dNtObH6MdOU uLYg== X-Forwarded-Encrypted: i=1; AJvYcCWEb+YXkdZ08ojpuky3vWBrZPGHwJdvfq1QK6VghHfRR/GYOQnR+PKNpD3YFq5IohnwzNIc984uo/0ecpw=@vger.kernel.org X-Gm-Message-State: AOJu0YwN6m05EW8KPhr1+OgMMHxF9qXnrMEmpGjO5VuDQ54/CsbH+uxO AVm7+YgT/lOmLChel5MHq1R2CxVAx/eeo/bMnj2iDroevHGOtYQP54rgGs7hdX5aenLvg87cwFC puJPlNr+buuiJNobLsv61AmS2uLGpxFqcPW6n8zWLHVzBjYAI68b6YZlh+Flxe0HYnj8= X-Gm-Gg: ATEYQzznerAJHGhGLIvy/pkJW3BD4/m1GpaF6JEgr68pDG+ShfAE/SzVJbrQKPNFicC pfAfguEnycA7/SbHTCtzIMLy4X8kQ0ylUyxtAg21pVBwLLprrqHA8QCYCUBVdu+muODH/bIbxqd yotzP4zbKMaM/CrTvQ/VDz28RoGdzXzmg7m4XLHAPrd2GiC1vBgrt4ec6j7rTsEyYRUoC7wSoM1 PwSQ9P9x20R7VLjz0r4N4Vuh4n3Hof7V9MH7qe3TO84mmzCgWBSD51RulZe7n/NLnpq3rEO6+z0 GxClOyJmYbc5aA6lkUgVVqre9HbKQUBUqW/BK6O2FrxOEoF9FNUDsDAEIV2XSwherPmxEYqJPkk /tEhnaFaHyZQxsT2GEm5nYl/BPR+oH1QIyN5dhogIBo9LqRPRGDI= X-Received: by 2002:a17:903:2ece:b0:2ae:567f:fd7f with SMTP id d9443c01a7336-2ae8249ad12mr12630525ad.53.1772776634041; Thu, 05 Mar 2026 21:57:14 -0800 (PST) X-Received: by 2002:a17:903:2ece:b0:2ae:567f:fd7f with SMTP id d9443c01a7336-2ae8249ad12mr12630055ad.53.1772776633508; Thu, 05 Mar 2026 21:57:13 -0800 (PST) Received: from [10.218.7.34] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ae83fa81d5sm5952335ad.71.2026.03.05.21.57.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 05 Mar 2026 21:57:13 -0800 (PST) Message-ID: <20301a77-2f75-4447-979a-f2dd4431c85c@oss.qualcomm.com> Date: Fri, 6 Mar 2026 11:27:03 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V11 3/4] iio: adc: Add support for QCOM PMIC5 Gen3 ADC To: Jonathan Cameron Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, agross@kernel.org, andersson@kernel.org, lumag@kernel.org, dmitry.baryshkov@oss.qualcomm.com, konradybcio@kernel.org, daniel.lezcano@linaro.org, sboyd@kernel.org, amitk@kernel.org, thara.gopinath@gmail.com, lee@kernel.org, rafael@kernel.org, subbaraman.narayanamurthy@oss.qualcomm.com, david.collins@oss.qualcomm.com, anjelique.melendez@oss.qualcomm.com, kamal.wadhwa@oss.qualcomm.com, rui.zhang@intel.com, lukasz.luba@arm.com, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, cros-qcom-dts-watchers@chromium.org, quic_kotarake@quicinc.com, neil.armstrong@linaro.org, stephan.gerhold@linaro.org References: <20260209105438.596339-1-jishnu.prakash@oss.qualcomm.com> <20260209105438.596339-4-jishnu.prakash@oss.qualcomm.com> <20260228193946.2e60ea5e@jic23-huawei> Content-Language: en-US From: Jishnu Prakash In-Reply-To: <20260228193946.2e60ea5e@jic23-huawei> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzA2MDA1NSBTYWx0ZWRfX5jmeiYlZqP+c 2O/8aG3FHil7Lb8D3j9rIvtHMwc2eOPKZb0D/lpS7MBjG1pvikudMbJmlid3EWAQeS6zb4QAZev iqyU1FMbN0GCXSDWgOm0q6yArgNo/xGxfQCTaKD8izd6+NLFQaOfDwqtDctrQ+O3kqfqJtWb/4a jLUe3Vz/ABHSFBPFGB6lAD0iIPk72ya1F7Ju728oxWqjkB3Fi3y2iaUABjgl4yEuT/xMxDhk6wD CCL7c0CwRwqV9bqZ28EfhJCjpbchBTUzQ9xog6NDIwht+dC1r6Xq7eI2xpeUbE+wjBW+wkgf95S 83aYuSY1qJbvBw8mQkNjUi6UaEuWzI+Of2LEz0E8z07vAiaxOo0Pwnp+iVM0j+R8P1V+m+tr1Bb LqoqHO56gkm2s3/hlTbdn+98puecAQamwGAwqm5kzEvLxkN0nckCR+TvyE7Wo0PlDSqTEdUqP0T V4yqAJ02M3rxhWuqTKA== X-Proofpoint-ORIG-GUID: W_MRQDB1r9CN6I5as5Y_Y-ttVftEvO9J X-Authority-Analysis: v=2.4 cv=DvZbOW/+ c=1 sm=1 tr=0 ts=69aa6cbb cx=c_pps a=IZJwPbhc+fLeJZngyXXI0A==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=UEldCo81gXLG25mkEUsA:9 a=QEXdDO2ut3YA:10 a=uG9DUKGECoFWVXl0Dc02:22 X-Proofpoint-GUID: W_MRQDB1r9CN6I5as5Y_Y-ttVftEvO9J X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-06_02,2026-03-04_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 impostorscore=0 malwarescore=0 bulkscore=0 adultscore=0 suspectscore=0 clxscore=1015 phishscore=0 priorityscore=1501 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603060055 Hi Jonathan, On 3/1/2026 1:09 AM, Jonathan Cameron wrote: > On Mon, 9 Feb 2026 16:24:37 +0530 > Jishnu Prakash wrote: > >> The ADC architecture on PMIC5 Gen3 is similar to that on PMIC5 Gen2, >> with all SW communication to ADC going through PMK8550 which >> communicates with other PMICs through PBS. >> >> One major difference is that the register interface used here is that >> of an SDAM (Shared Direct Access Memory) peripheral present on PMK8550. >> There may be more than one SDAM used for ADC5 Gen3 and each has eight >> channels, which may be used for either immediate reads (same functionality >> as previous PMIC5 and PMIC5 Gen2 ADC peripherals) or recurring measurements >> (same as ADC_TM functionality). >> >> By convention, we reserve the first channel of the first SDAM for all >> immediate reads and use the remaining channels across all SDAMs for >> ADC_TM monitoring functionality. >> >> Add support for PMIC5 Gen3 ADC driver for immediate read functionality. >> ADC_TM is implemented as an auxiliary thermal driver under this ADC >> driver. >> >> Signed-off-by: Jishnu Prakash > Ah. I just realized I built the immutable branch from v10 not this. > I wasn't seeing any review outstanding on that version and didn't read your > email closely enough :( > > I'd rather not cause more confusion by ripping it down and creating a new > one. From a quick look none of the changes since v10 look vital. > Perhaps we can spin a follow up patch to pull into IIO to make those > tweaks if you want them? That way the immutable branch remains > the same. > Thanks for picking the patches. Picking v10 shouldn't be a problem, I can make separate refactoring patches for the v10->v11 differences later. Since you have made the immutable branch now picking patches 1-3, is it possible for the thermal maintainers to pick v10 patch 4 now or are there any other procedures to be completed? Thanks, Jishnu > Thanks, > > Jonathan > > >> --- >> Changes since v10: >> - Made following changes to address Jonathan's comments: >> - Replaced inclusion of device.h header file in >> include/linux/iio/adc/qcom-adc5-gen3-common.h with forwards declaration >> of struct device. >> - Updated all for() loops to declare and initialize the loop iterator >> inside the for() loop statement. >> - Moved initializations for drvdata, completion struct and mutex within >> adc5_gen3_probe(). >> >> Changes since v8: >> - Dropped the common module (drivers/iio/adc/qcom-adc5-gen3-common.c) and moved >> all of its contents to drivers/iio/adc/qcom-spmi-adc5-gen3.c as suggested by Dmitry. >> - Made following changes to address Dmitry's comment to use module_auxiliary_driver() >> in auxiliary driver patch, by simplifying auxiliary device structures: