From: Richard Fitzgerald <rf@opensource.cirrus.com>
To: "Martin Povišer" <povik+lin@cutebit.org>,
"James Schulman" <james.schulman@cirrus.com>,
"David Rhodes" <david.rhodes@cirrus.com>,
"Lucas Tanure" <tanureal@opensource.cirrus.com>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Mark Brown" <broonie@kernel.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Jaroslav Kysela" <perex@perex.cz>,
"Takashi Iwai" <tiwai@suse.com>
Cc: Charles Keepax <ckeepax@opensource.cirrus.com>,
ChiYuan Huang <cy_huang@richtek.com>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
Lukas Bulwahn <lukas.bulwahn@gmail.com>,
Matt Flax <flatmax@flatmax.com>,
- <patches@opensource.cirrus.com>, <alsa-devel@alsa-project.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<asahi@lists.linux.dev>
Subject: Re: [PATCH 04/10] ASoC: cs42l42: Split probe() and remove() into stages
Date: Fri, 9 Sep 2022 16:55:41 +0100 [thread overview]
Message-ID: <20342329-8525-9081-e1c1-f67067883c72@opensource.cirrus.com> (raw)
In-Reply-To: <20220909135334.98220-5-povik+lin@cutebit.org>
On 09/09/2022 14:53, Martin Povišer wrote:
> +static int cs42l42_init(struct cs42l42_private *cs42l42)
> +{
> + unsigned int reg;
> + int devid, ret;
> +
> /* initialize codec */
> devid = cirrus_read_device_id(cs42l42->regmap, CS42L42_DEVID_AB);
> if (devid < 0) {
> @@ -2320,15 +2331,15 @@ static int cs42l42_i2c_probe(struct i2c_client *i2c_client)
> /* Setup headset detection */
> cs42l42_setup_hs_type_detect(cs42l42);
>
> + /*
> + * Set init_done before unmasking interrupts so any triggered
> + * immediately will be handled.
> + */
> + cs42l42->init_done = true;
> +
> /* Mask/Unmask Interrupts */
> cs42l42_set_interrupt_masks(cs42l42);
>
> - /* Register codec for machine driver */
> - ret = devm_snd_soc_register_component(cs42l42->dev,
> - &soc_component_dev_cs42l42, &cs42l42_dai, 1);
> - if (ret < 0)
> - goto err_shutdown;
> -
> return 0;
>
> err_shutdown:
> @@ -2337,34 +2348,69 @@ static int cs42l42_i2c_probe(struct i2c_client *i2c_client)
> regmap_write(cs42l42->regmap, CS42L42_PWR_CTL1, 0xff);
>
> err_disable:
> - if (i2c_client->irq)
> - free_irq(i2c_client->irq, cs42l42);
> -
These 3 lines should not be removed. cs42l42_init() must free
the irq in the error paths.
next prev parent reply other threads:[~2022-09-09 15:57 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-09 13:53 [PATCH 00/10] Support for CS42L83 on Apple machines Martin Povišer
2022-09-09 13:53 ` [PATCH 01/10] ASoC: dt-bindings: cs42l42: Add 'cs42l83' compatible Martin Povišer
2022-09-09 14:48 ` Krzysztof Kozlowski
2022-09-09 13:53 ` [PATCH 02/10] ASoC: cs42l42: Add bitclock frequency argument to cs42l42_pll_config() Martin Povišer
2022-09-09 13:53 ` [PATCH 03/10] ASoC: cs42l42: Use cs42l42->dev instead of &i2c_client->dev Martin Povišer
2022-09-09 13:53 ` [PATCH 04/10] ASoC: cs42l42: Split probe() and remove() into stages Martin Povišer
2022-09-09 15:55 ` Richard Fitzgerald [this message]
2022-09-15 9:08 ` Martin Povišer
2022-09-09 13:53 ` [PATCH 05/10] ASoC: cs42l42: Split cs42l42_resume into two functions Martin Povišer
2022-09-09 13:53 ` [PATCH 06/10] ASoC: cs42l42: Pass component and dai defs into common probe Martin Povišer
2022-09-09 13:53 ` [PATCH 07/10] ASoC: cs42l42: Split I2C identity into separate module Martin Povišer
2022-09-09 15:40 ` Richard Fitzgerald
2022-09-09 15:44 ` Martin Povišer
2022-09-09 16:00 ` Richard Fitzgerald
2022-09-09 13:53 ` [PATCH 08/10] ASoC: cs42l42: Export regmap elements to core namespace Martin Povišer
2022-09-09 13:53 ` [PATCH 09/10] ASoC: cs42l83: Extend CS42L42 support to new part Martin Povišer
2022-09-09 14:47 ` Krzysztof Kozlowski
2022-09-09 15:10 ` Martin Povišer
2022-09-09 15:33 ` Krzysztof Kozlowski
2022-09-09 13:53 ` [PATCH 10/10] ASoC: cs42l42: Implement 'set_bclk_ratio' Martin Povišer
2022-09-09 16:16 ` [PATCH 00/10] Support for CS42L83 on Apple machines Richard Fitzgerald
2022-09-09 17:27 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20342329-8525-9081-e1c1-f67067883c72@opensource.cirrus.com \
--to=rf@opensource.cirrus.com \
--cc=alsa-devel@alsa-project.org \
--cc=asahi@lists.linux.dev \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=cy_huang@richtek.com \
--cc=david.rhodes@cirrus.com \
--cc=devicetree@vger.kernel.org \
--cc=flatmax@flatmax.com \
--cc=james.schulman@cirrus.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
--cc=patches@opensource.cirrus.com \
--cc=perex@perex.cz \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=povik+lin@cutebit.org \
--cc=robh+dt@kernel.org \
--cc=tanureal@opensource.cirrus.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®