From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73C63C2D0EA for ; Wed, 8 Apr 2020 05:35:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3EC6E20730 for ; Wed, 8 Apr 2020 05:35:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Xnn4RHbR" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726545AbgDHFfl (ORCPT ); Wed, 8 Apr 2020 01:35:41 -0400 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:21775 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726345AbgDHFfl (ORCPT ); Wed, 8 Apr 2020 01:35:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1586324140; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DKKitWhcmQp3vV4NVp+aFS/cFmyiwETlBaGYg7qvVcg=; b=Xnn4RHbRS3oZ9HSOE2kWM/gXtOcnxrSPJuzjlQumnqMYy5rKyO1WglO1LEQTQaFch3tTVO lEGm1y6Jhakq2T8JqkqN0XO0OkRkP+Gd2XTk8xgLk3cGLHZ90VXUoZ7z9nP+7ETfU1Ea0i H0xyfVDShZVLC5jp7i5TZKFoDPh7HOY= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-181-KVTf7G1cO_q7TRiC3MLF6Q-1; Wed, 08 Apr 2020 01:35:38 -0400 X-MC-Unique: KVTf7G1cO_q7TRiC3MLF6Q-1 Received: by mail-wm1-f71.google.com with SMTP id p18so1819363wmk.9 for ; Tue, 07 Apr 2020 22:35:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=DKKitWhcmQp3vV4NVp+aFS/cFmyiwETlBaGYg7qvVcg=; b=lKoyXRXY8Parttx/4B3wpOswhe4rUAlFPnZ5r3TNCeVJnZEsQN5qCUyF35S0zN1Xys hZcfGHtw+nJ9ZO93hFWkiTsocmpnVFr9t1O9nX3K103NrkH/vnSMOooBu9DiWKWgCyOv f/n5mLo9mCvWCVnSB8RKwxWI7866BSfXi77qLpsxCOelXRb26RaNksnjJJ3C2SHWi7Zk B0dkIli5yWGR5iS5BTu7NHVJ1TDcctCHa4uIGwOfiv2TqENdq/kfwicqA1X7EDx2WR2H qiQFURRigK/ckHS5RQKdpVGXzOV8wB4nNSXa4z7XT/r7QohAbZ3tNaVtQuTKxh9qC8vK 2iXQ== X-Gm-Message-State: AGi0PuYJj6Qw9/bGGjCvWZbuVO2KPjHxbvzBYgcT4veCjm/nZ4o3GI4g orLzwy7DX0kjk7kF2CkgNmgjdSQCTpY+EtxHcYJJMvhgUnXXWAVRkJdZlRlMc0j9oQGALryf9ET hTFGzC+fTkgqBFVfK0gxPbaJL X-Received: by 2002:a5d:51cf:: with SMTP id n15mr5925794wrv.195.1586324137171; Tue, 07 Apr 2020 22:35:37 -0700 (PDT) X-Google-Smtp-Source: APiQypKVQ6jZnquj60J3lHFYTbd2lZIBqpDJo2lkuyyEwCh61W49kQbylHv8LwYeofyA5MUiATbDSA== X-Received: by 2002:a5d:51cf:: with SMTP id n15mr5925770wrv.195.1586324136872; Tue, 07 Apr 2020 22:35:36 -0700 (PDT) Received: from x1.bristot.me ([87.19.200.153]) by smtp.gmail.com with ESMTPSA id a12sm5179399wmj.22.2020.04.07.22.35.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Apr 2020 22:35:36 -0700 (PDT) Subject: Re: [RFC PATCH 2/3] docs: scheduler: Add scheduler overview documentation To: Jonathan Corbet Cc: Peter Zijlstra , John Mathew , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, mingo@redhat.com, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, tsbogend@alpha.franken.de, lukas.bulwahn@gmail.com, x86@kernel.org, linux-mips@vger.kernel.org, tglx@linutronix.de, mostafa.chamanara@basemark.com References: <20200401100029.1445-1-john.mathew@unikie.com> <20200401100029.1445-3-john.mathew@unikie.com> <20200401103520.GA20713@hirez.programming.kicks-ass.net> <9614b346-a848-3e01-eea7-6237b759dad6@redhat.com> <20200407134028.44d0d16a@lwn.net> From: Daniel Bristot de Oliveira Message-ID: <20358dfa-4216-9e84-79a6-b34accbc4280@redhat.com> Date: Wed, 8 Apr 2020 07:35:34 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <20200407134028.44d0d16a@lwn.net> Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/7/20 9:40 PM, Jonathan Corbet wrote: > On Wed, 1 Apr 2020 13:47:04 +0200 > Daniel Bristot de Oliveira wrote: > >>> And that is a prime example of why I hates RST, it pretty much mandates >>> you view this with something other than a text editor. >> The good thing about the dot format is that we can convert it to many other >> formats, including text: >> >> [bristot@x1 ~]$ cat sched_transition.dot | graph-easy >> >> * >> >> | >> | task >> | forks >> v >> +------------------------------------+ >> | TASK_NEW | >> | (Ready to run) | >> +------------------------------------+ >> | >> | >> v >> + - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -+ >> ' int ' >> ' ' >> ' +------------------------------------+ ' >> ' | TASK_RUNNING | ' >> ' +--------------> | (Ready to run) | <--+ ' >> ' | +------------------------------------+ | ' >> ' | | | ' >> ' | | schedule() calls context_switch() | task is pre-empted ' >> ' | v | ' >> ' | +------------------------------------+ | ' >> ' | | TASK_RUNNING | | ' >> ' | | (Running) | ---+ ' >> ' | event occurred +------------------------------------+ ' >> ' | | ' >> ' | | - - - - - - - - - - - -+ >> ' | | ' >> ' | | task needs to wait for event ' >> ' | v ' >> ' | +------------------------------------+ ' >> ' | | TASK_INTERRUPTIBLE | ' >> ' | | TASK_UNINTERRUPTIBLE | ' >> ' +--------------- | TASK_WAKEKILL | ' >> ' +------------------------------------+ ' >> ' ' >> + - - - - - - - - - - - - - - - - - - - - - - - - - - - - - + >> | >> | task exits via do_exit() >> v >> +------------------------------------+ >> | TASK_DEAD | >> | EXIT_ZOMBIE | >> +------------------------------------+ >> >> >> Is there a way to also add this representation, while hiding it >> when using a graphical reader? > Better, honestly, to just put the ascii art into the doc as a literal > block. I don't see any real reason to embed Dot stuff unless there's > really no alternative. I agree. I think that their idea was focused on a media that could translate the "source-code in .dot" into a graphical representation, which is good. But that is not the case for this file and its audience. But, maybe, it would be nice to have the .dot somewhere (not in the document, I agree) as a "source code" for future updates. -- Daniel