mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Hoan Tran <hotran@apm.com>
Cc: Viresh Kumar <viresh.kumar@linaro.org>,
	pprakash@codeaurora.org, Al Stone <ahs3@redhat.com>,
	linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
	lho@apm.com, Duc Dang <dhdang@apm.com>
Subject: Re: [PATCH] cpufreq: CPPC: Avoid overflow when calculating desired_perf
Date: Thu, 15 Sep 2016 02:50:09 +0200	[thread overview]
Message-ID: <2037077.Sk8HnobN5X@vostro.rjw.lan> (raw)
In-Reply-To: <1473894508-22270-1-git-send-email-hotran@apm.com>

On Wednesday, September 14, 2016 04:08:28 PM Hoan Tran wrote:
> This patch fixes overflow issue when calculating the desired_perf.
> 
> Signed-off-by: Hoan Tran <hotran@apm.com>
> ---
>  drivers/cpufreq/cppc_cpufreq.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/cpufreq/cppc_cpufreq.c b/drivers/cpufreq/cppc_cpufreq.c
> index 894e465..3e0961e 100644
> --- a/drivers/cpufreq/cppc_cpufreq.c
> +++ b/drivers/cpufreq/cppc_cpufreq.c
> @@ -84,7 +84,8 @@ static int cppc_cpufreq_set_target(struct cpufreq_policy *policy,
>  
>  	cpu = all_cpu_data[policy->cpu];
>  
> -	cpu->perf_ctrls.desired_perf = target_freq * policy->max / cppc_dmi_max_khz;
> +	cpu->perf_ctrls.desired_perf =
> +		(u64)target_freq * policy->max / cppc_dmi_max_khz;
>  	freqs.old = policy->cur;
>  	freqs.new = target_freq;

That's on top of the CPPC material in linux-next I gather?

Which commit does it fix?

Thanks,
Rafael

  reply	other threads:[~2016-09-15  0:44 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-14 23:08 Hoan Tran
2016-09-15  0:50 ` Rafael J. Wysocki [this message]
2016-09-15  3:06   ` Hoan Tran
2016-09-19 18:54     ` Al Stone

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2037077.Sk8HnobN5X@vostro.rjw.lan \
    --to=rjw@rjwysocki.net \
    --cc=ahs3@redhat.com \
    --cc=dhdang@apm.com \
    --cc=hotran@apm.com \
    --cc=lho@apm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=pprakash@codeaurora.org \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®