From: "Ding, Shenghao" <shenghao-ding@ti.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: "broonie@kernel.org" <broonie@kernel.org>,
"andriy.shevchenko@linux.intel.com"
<andriy.shevchenko@linux.intel.com>,
"13564923607@139.com" <13564923607@139.com>,
"13916275206@139.com" <13916275206@139.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Xu, Baojun" <baojun.xu@ti.com>,
"Baojun.Xu@fpt.com" <Baojun.Xu@fpt.com>,
"Ji, Jesse" <jesse-ji@ti.com>
Subject: RE: [EXTERNAL] Re: [PATCH v1] ALSA: hda/tas2781: Enable init_profile_id for device initialization
Date: Thu, 21 Aug 2025 09:01:45 +0000 [thread overview]
Message-ID: <203d0937f1974417ac64b4ed6a6f2e69@ti.com> (raw)
In-Reply-To: <87cy8p6t4t.wl-tiwai@suse.de>
> -----Original Message-----
> From: Takashi Iwai <tiwai@suse.de>
> Sent: Thursday, August 21, 2025 3:17 PM
> To: Ding, Shenghao <shenghao-ding@ti.com>
> Cc: broonie@kernel.org; andriy.shevchenko@linux.intel.com;
> 13564923607@139.com; 13916275206@139.com; alsa-devel@alsa-
> project.org; linux-kernel@vger.kernel.org; Xu, Baojun <baojun.xu@ti.com>;
> Baojun.Xu@fpt.com; Ji, Jesse <jesse-ji@ti.com>
> Subject: [EXTERNAL] Re: [PATCH v1] ALSA: hda/tas2781: Enable
> init_profile_id for device initialization
>
> On Wed, 20 Aug 2025 10: 21: 23 +0200, Shenghao Ding wrote: > > Optimize
> the time consumption of profile switching, init_profile saves > the common
> settings of different profiles, such as the dsp coefficients, > etc, which can
> greatly ZjQcmQRYFpfptBannerStart This message was sent from outside of
> Texas Instruments.
> Do not click links or open attachments unless you recognize the source of
> this email and know the content is safe.
> <https://us-phishalarm-
> ewt.proofpoint.com/EWT/v1/G3vK!vxdrHf3mV2Ub4obsvxtoX4FTV-yYd_C-
> 6ngQtFeUFpCRaEESj8_B-sZXmuX5JN2I2u4Qx-lD$>
> Report Suspicious
>
> ZjQcmQRYFpfptBannerEnd
> On Wed, 20 Aug 2025 10:21:23 +0200,
> Shenghao Ding wrote:
> >
> > Optimize the time consumption of profile switching, init_profile saves
> > the common settings of different profiles, such as the dsp
> > coefficients, etc, which can greatly reduce the profile switching time
> > comsumption and remove the repetitive settings.
> >
..............................
> The patch causes build errors:
>
> sound/hda/codecs/side-codecs/tas2781_hda_i2c.c: In function
> ʽtasdevice_dspfw_initʼ:
> sound/hda/codecs/side-codecs/tas2781_hda_i2c.c:468:29: error: ʽstruct
> tasdevice_rcaʼ has no member named ʽinit_profile_idʼ
> 468 | if (tas_priv->rcabin.init_profile_id >= 0)
> | ^
> ....
>
> Something still not landed in my tree yet.
I will resubmit it after your tree is ready.
>
>
> thanks,
>
> Takashi
next prev parent reply other threads:[~2025-08-21 9:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-20 8:21 Shenghao Ding
2025-08-21 7:17 ` Takashi Iwai
2025-08-21 9:01 ` Ding, Shenghao [this message]
2025-08-21 9:30 ` [EXTERNAL] " Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=203d0937f1974417ac64b4ed6a6f2e69@ti.com \
--to=shenghao-ding@ti.com \
--cc=13564923607@139.com \
--cc=13916275206@139.com \
--cc=Baojun.Xu@fpt.com \
--cc=alsa-devel@alsa-project.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=baojun.xu@ti.com \
--cc=broonie@kernel.org \
--cc=jesse-ji@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome