From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760021AbcAMMiP (ORCPT ); Wed, 13 Jan 2016 07:38:15 -0500 Received: from smtp03.udag.de ([62.146.106.29]:57750 "EHLO smtp03.udag.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754419AbcAMMiN (ORCPT ); Wed, 13 Jan 2016 07:38:13 -0500 X-Greylist: delayed 480 seconds by postgrey-1.27 at vger.kernel.org; Wed, 13 Jan 2016 07:38:13 EST Date: Wed, 13 Jan 2016 13:30:10 +0100 (CET) From: Karol Herbst Reply-To: Karol Herbst To: Dan Carpenter , David Airlie Cc: linux-kernel , kernel-janitors , dri-devel Message-ID: <2041787627.38787.1452688210630.JavaMail.open-xchange@www.ud-mail.de> In-Reply-To: <20160113122152.GC19993@mwanda> References: <20160113122152.GC19993@mwanda> Subject: Re: [patch] drm/nouveau/pci: reversed condition in nvkm_pcie_set_link() MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Priority: 3 Importance: Medium X-Mailer: Open-Xchange Mailer v7.6.2-Rev44 X-Originating-Client: open-xchange-appsuite Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Dan, yeah I also catched that. I assume something went wrong in the review process, because I am sure I didn't added that "pci ||" check myself ;) but who knows, maybe I was tired working with ben on that, cause it was like 4am while doing the last polishing steps. nvm, I already send a patch to the nouveau ML: http://lists.freedesktop.org/archives/nouveau/2016-January/023772.html I just tried to poke ben the last day like several times, but he didn't seem to be there yesterday > Dan Carpenter hat am 13. Januar 2016 um 13:21 > geschrieben: > > The condition is reversed so this function is a no-op. > > Fixes: bcc19d9bf5cd ('drm/nouveau/pci: implement generic code for pcie speed > change') > Signed-off-by: Dan Carpenter > > diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/pci/pcie.c > b/drivers/gpu/drm/nouveau/nvkm/subdev/pci/pcie.c > index b32954f..d71e5db 100644 > --- a/drivers/gpu/drm/nouveau/nvkm/subdev/pci/pcie.c > +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/pci/pcie.c > @@ -119,7 +119,7 @@ nvkm_pcie_set_link(struct nvkm_pci *pci, enum > nvkm_pcie_speed speed, u8 width) > struct pci_bus *pbus; > int ret; > > - if (pci || !pci_is_pcie(pci->pdev)) > + if (!pci || !pci_is_pcie(pci->pdev)) > return 0; > pbus = pci->pdev->bus; >