From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753302AbaIYXdX (ORCPT ); Thu, 25 Sep 2014 19:33:23 -0400 Received: from v094114.home.net.pl ([79.96.170.134]:56014 "HELO v094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1752991AbaIYXdW (ORCPT ); Thu, 25 Sep 2014 19:33:22 -0400 From: "Rafael J. Wysocki" To: Viresh Kumar Cc: Rasmus Villemoes , Andrew Morton , Linux Kernel Mailing List , "linux-pm@vger.kernel.org" Subject: Re: [PATCH 11/22] cpufreq: Replace strnicmp with strncasecmp Date: Fri, 26 Sep 2014 01:53:12 +0200 Message-ID: <2042736.or0GtPEZK6@vostro.rjw.lan> User-Agent: KMail/4.11.5 (Linux/3.16.0-rc5+; KDE/4.11.5; x86_64; ; ) In-Reply-To: References: <1410900696-6481-1-git-send-email-linux@rasmusvillemoes.dk> <1410900696-6481-12-git-send-email-linux@rasmusvillemoes.dk> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday, September 16, 2014 02:22:49 PM Viresh Kumar wrote: > On 16 September 2014 13:51, Rasmus Villemoes wrote: > > The kernel used to contain two functions for length-delimited, > > case-insensitive string comparison, strnicmp with correct semantics > > and a slightly buggy strncasecmp. The latter is the POSIX name, so > > strnicmp was renamed to strncasecmp, and strnicmp made into a wrapper > > for the new strncasecmp to avoid breaking existing users. > > > > To allow the compat wrapper strnicmp to be removed at some point in > > the future, and to avoid the extra indirection cost, do > > s/strnicmp/strncasecmp/g. > > > > Cc: "Rafael J. Wysocki" > > Cc: Viresh Kumar > > Cc: linux-pm@vger.kernel.org > > Signed-off-by: Rasmus Villemoes > > --- > > drivers/cpufreq/cpufreq.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > Not really sure about the implementation of these routines but the > changes look fine. > > Acked-by: Viresh Kumar Queued up for 3.18, thanks! -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center.