From: David Howells <dhowells@redhat.com>
To: Rudolf Polzer <rpolzer@google.com>
Cc: dhowells@redhat.com, keyrings@vger.kernel.org,
David Woodhouse <David.Woodhouse@intel.com>,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
linux-security-module@vger.kernel.org
Subject: Re: [RFC PATCH 1/4] X.509: Fix leap year handling again
Date: Wed, 20 Jan 2016 15:18:32 +0000 [thread overview]
Message-ID: <20452.1453303112@warthog.procyon.org.uk> (raw)
In-Reply-To: <CABwpRLRu_VaD-yWRYvn_nbR-Og5LhRYt4E6Mk7W424-PAFdd+g@mail.gmail.com>
Rudolf Polzer <rpolzer@google.com> wrote:
> A small nit: could it be that the month_lengths array also exists elsewhere
> in the kernel? Can it possibly be shared? A quick glance around didn't pop
> up anything that's not static, so, looks like it's okay to add yet another
> one...
Fair point, but outside of the scope of this patch. The array already exists
that I'm fixing. It's definitely material for a future patch though.
Note that the following:
git grep 'month.*[[]'
trawls up a few candidates.
David
next prev parent reply other threads:[~2016-01-20 15:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-04 22:16 [PATCH 0/4] X.509: Fix time handling David Howells
2016-01-04 22:17 ` [RFC PATCH 1/4] X.509: Fix leap year handling again David Howells
2016-01-20 15:12 ` Rudolf Polzer
2016-01-20 15:18 ` David Howells [this message]
2016-01-04 22:17 ` [RFC PATCH 2/4] Handle ISO 8601 leap seconds and encodings of midnight in mktime64() David Howells
2016-01-04 22:17 ` [RFC PATCH 3/4] X.509: Support leap seconds David Howells
2016-01-20 15:08 ` Rudolf Polzer
2016-01-04 22:17 ` [RFC PATCH 4/4] X.509: Handle midnight alternative notation in GeneralizedTime David Howells
2016-01-20 15:08 ` Rudolf Polzer
2016-01-20 15:20 ` David Howells
2016-01-20 15:30 ` One Thousand Gnomes
2016-02-03 16:25 ` David Howells
2016-02-03 16:28 ` David Howells
2016-02-04 17:38 ` One Thousand Gnomes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20452.1453303112@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=David.Woodhouse@intel.com \
--cc=keyrings@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=rpolzer@google.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®