mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Stefan Wahren <stefan.wahren@i2se.com>
To: Joe Perches <joe@perches.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
	linux-kernel@vger.kernel.org, Mark Brown <broonie@kernel.org>,
	stable@vger.kernel.org
Subject: Re: [PATCH] regulator: core: fix constraints debug output
Date: Thu, 21 May 2015 08:42:43 +0200 (CEST)	[thread overview]
Message-ID: <2047496795.32464.1432190563718.JavaMail.open-xchange@oxbsltgw07.schlund.de> (raw)
In-Reply-To: <1432154105.20840.8.camel@perches.com>

Hi Joe,

> Joe Perches <joe@perches.com> hat am 20. Mai 2015 um 22:35 geschrieben:
>
>
> On Wed, 2015-05-20 at 20:17 +0000, Stefan Wahren wrote:
> > In the case uV_offset is greater than 0 the debug output before
> > is accidentally overwritten. So take care of the output count.
>
> If you are going to take care, please change all of these
> sprintf calls to snprintf.

thanks for pointing out. I will create a second version.

But using scnprintf should be better here.

>
> The buf array may not be big enough [80] to hold the longest
> possible output string.
>

Stefan

      reply	other threads:[~2015-05-21  6:42 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-20 20:17 Stefan Wahren
2015-05-20 20:35 ` Joe Perches
2015-05-21  6:42   ` Stefan Wahren [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2047496795.32464.1432190563718.JavaMail.open-xchange@oxbsltgw07.schlund.de \
    --to=stefan.wahren@i2se.com \
    --cc=broonie@kernel.org \
    --cc=joe@perches.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®