From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EEAA2C433DB for ; Sat, 26 Dec 2020 07:04:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B7DCA20829 for ; Sat, 26 Dec 2020 07:04:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728058AbgLZHEP (ORCPT ); Sat, 26 Dec 2020 02:04:15 -0500 Received: from smtprelay0215.hostedemail.com ([216.40.44.215]:36956 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726345AbgLZHEP (ORCPT ); Sat, 26 Dec 2020 02:04:15 -0500 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay03.hostedemail.com (Postfix) with ESMTP id 131BC837F27E; Sat, 26 Dec 2020 07:03:30 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: cake09_2c178b227480 X-Filterd-Recvd-Size: 2210 Received: from [192.168.1.159] (unknown [47.151.137.21]) (Authenticated sender: joe@perches.com) by omf10.hostedemail.com (Postfix) with ESMTPA; Sat, 26 Dec 2020 07:03:28 +0000 (UTC) Message-ID: <204aeca57b8649b311745c8f9c56f48dfcf36a85.camel@perches.com> Subject: Re: [PATCH] mfd: ab8500-debugfs: Remove extraneous curly brace From: Joe Perches To: Nathan Chancellor , Linus Torvalds Cc: Linus Walleij , Lee Jones , Thomas Gleixner , linux-kernel@vger.kernel.org Date: Fri, 25 Dec 2020 23:03:27 -0800 In-Reply-To: <20201226013549.1973451-1-natechancellor@gmail.com> References: <20201226013549.1973451-1-natechancellor@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.38.1-1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2020-12-25 at 18:35 -0700, Nathan Chancellor wrote: > Clang errors: > > ../drivers/mfd/ab8500-debugfs.c:1526:2: error: non-void function does > not return a value [-Werror,-Wreturn-type] >         } >         ^ > ../drivers/mfd/ab8500-debugfs.c:1528:2: error: expected identifier or '(' > return 0; >         ^ > ../drivers/mfd/ab8500-debugfs.c:1529:1: error: extraneous closing brace ('}') > } > ^ > 3 errors generated. > > The cleanup in ab8500_interrupts_show left a curly brace around, remove > it to fix the error. > > Fixes: 886c8121659d ("mfd: ab8500-debugfs: Remove the racy fiddling with irq_desc") > Signed-off-by: Nathan Chancellor > --- >  drivers/mfd/ab8500-debugfs.c | 1 - >  1 file changed, 1 deletion(-) > > diff --git a/drivers/mfd/ab8500-debugfs.c b/drivers/mfd/ab8500-debugfs.c [] > @@ -1521,7 +1521,6 @@ static int ab8500_interrupts_show(struct seq_file *s, void *p) >   line + irq_first, >   num_interrupts[line], >   num_wake_interrupts[line]); > - } >   seq_putc(s, '\n'); It looks as if this seq_putc should be removed as well as the seq_printf above already ends in a newline. >   } >   > > > base-commit: 61d791365b72a89062fbbea69aa61479476da946