mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Zhijian Li (Fujitsu)" <lizhijian@fujitsu.com>
To: Zhu Yanjun <yanjun.zhu@linux.dev>,
	"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"zyjzyj2000@gmail.com" <zyjzyj2000@gmail.com>,
	"jgg@ziepe.ca" <jgg@ziepe.ca>,
	"leon@kernel.org" <leon@kernel.org>,
	"Daisuke Matsuda (Fujitsu)" <matsuda-daisuke@fujitsu.com>,
	Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
Subject: Re: [PATCH] RDMA/rxe: Fix null pointer dereference in ODP MR check
Date: Thu, 3 Apr 2025 02:59:05 +0000	[thread overview]
Message-ID: <20551f6e-df87-460b-9927-70c93b8d6149@fujitsu.com> (raw)
In-Reply-To: <a0eb561e-9fa9-46ab-bb0a-6e68a8e0d834@linux.dev>



On 02/04/2025 16:58, Zhu Yanjun wrote:
> 
> Previously I once discussed with Bob Pearson about the function names.

This is a frequently raised question, yet I have not discovered a definitive
coding style(Please let me know if you have). According to my understanding,
the common practice I adhere to is as follows:

- Functions utilized within a single file often do not require a prefix, as current situation.
- If a function is to be used across multiple files, I believe a prefix is essential.

Thanks
Zhijian

> Perhaps it is better to rename is_odp_mr to rxe_is_odp_mr?
> 
> Since sometimes we debug in rdma, with a lot of functions with the same name, it is difficult to recognize the modules that this function belongs to.
> 
> Thus, in rxe module, it is better to add rxe_ prefix to the function name. But anyway, this commit is fine.

  reply	other threads:[~2025-04-03  3:00 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-02  3:26 Li Zhijian
2025-04-02  5:11 ` Daisuke Matsuda (Fujitsu)
2025-04-02  8:58 ` Zhu Yanjun
2025-04-03  2:59   ` Zhijian Li (Fujitsu) [this message]
2025-04-03 13:33     ` Zhu Yanjun
2025-04-07 18:23 ` Jason Gunthorpe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20551f6e-df87-460b-9927-70c93b8d6149@fujitsu.com \
    --to=lizhijian@fujitsu.com \
    --cc=jgg@ziepe.ca \
    --cc=leon@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=matsuda-daisuke@fujitsu.com \
    --cc=shinichiro.kawasaki@wdc.com \
    --cc=yanjun.zhu@linux.dev \
    --cc=zyjzyj2000@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®